Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1147107iog; Wed, 15 Jun 2022 23:08:47 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vxBifKusvcEYdQUHzGrh2QbBBIxaUQm9vsDHsbHV65XoC/n3cDkroXh+gU8jQVPK9/SamP X-Received: by 2002:a17:907:9605:b0:6f5:c66:7c13 with SMTP id gb5-20020a170907960500b006f50c667c13mr2996294ejc.66.1655359727038; Wed, 15 Jun 2022 23:08:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655359727; cv=none; d=google.com; s=arc-20160816; b=vCtl/92A8FRg6eWqCNXKg9JF0CyNtjMOJlE0wbq7CyjZmZvIVg45T89BYRwOcNHExJ Pb+1+XBSHPmDwgBgPP/hZrvJyyWvGfRU4PGt4D+xgPZ3C7Z/HMIrUzKBgAlvrWoWZAvd ZeIO4cGRWYc9h7VVcJOomt97jAqQxBe1WKKsOidKwfo+pbtn9TbNO+eFvRrSMISFIkD/ N7iPKk2ipmzQAIFnHBuE8zyZ9h2RpofvFMbgOb+kNY8En99WlWhtxxVqLvtU//rmTzy1 LLKlRCTVCgbDiqxQ77nrg+LGYWx7o30e62LSxLjBpmnj/vn+hLbW2ixssJ/GlZVfSOGD AhGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=tSVh6y1olykW7nj/dJBld+0a6Q0G5NJvC78CUpStSoI=; b=VTvkwqyfzTdLZvPI13tv8Z0AAuMpze8JJwqFmhI+fJKawN2TUy2QELRInOZU9zqoB7 DQz9n1TrbeEZ0z8BPREm8tVjRmIshyFjOVO3MJIQr7wpNXtfppzImFxgG7Jc+XD5ucZO LQO/ju7Ea0hNYNpF0X9sK3yN+VY4OzOZIv4oPVeJOFua6F6pk0+huLTkxXNoO+I0yVxw Wiztsj3sgwMz6IASDjcnSj7rdBWc/Dt0uFsuo7kBi4dA7IaBzhyKCoocY4rV/NPrl6m9 +oxXvzE4TkXdaFIqauG+F1sD33lpO6eykXt8Ntt6NpRRnlt4L32bvj7bKABP2KdKm0/O YKnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sChJCXGS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ht21-20020a170907609500b006feb04902a8si675726ejc.824.2022.06.15.23.08.21; Wed, 15 Jun 2022 23:08:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sChJCXGS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358844AbiFPGAl (ORCPT + 99 others); Thu, 16 Jun 2022 02:00:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbiFPGAj (ORCPT ); Thu, 16 Jun 2022 02:00:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A234A1CB12; Wed, 15 Jun 2022 23:00:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 02EB461947; Thu, 16 Jun 2022 06:00:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AEB8C34114; Thu, 16 Jun 2022 06:00:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655359237; bh=NNnILUBInXhE03zKMmprxCx+9V9Y5yxU7wfeUteCX0k=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=sChJCXGScaKUfNyG807me1PLVDKKuLPNI0xji9h2rVvkokzayL8rbsefMmSCKdXu2 sKU0djUcd3ulPlzhSCScAXapZjFBDCnDZVpZV2CypISFMGxdgC0OmVLDfi7rpTq+me nrUPHXf3S5szbYWvEfW8JXeKduhg+fsz6SBQbCJX6t1fqpWAIMBYbBJzuqaMd6jcIK +R9Fs5X95pCneWrpWy5Ma3/n7vAjjzqGi/F5V1+NqxpgY6DCugkQWvlE1Rt4jBekro MzlhrCRYMUKg88FUlKyyAVBv7HeG6q0u+JFKlDSLPAIgOw9sxRLh+XFfT1x6S1rrn4 m2ZdaDTBhHsaw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220616033622.3975621-1-windhl@126.com> References: <20220616033622.3975621-1-windhl@126.com> Subject: Re: [PATCH v2] clk: tegra: (clk-tegra30) Add missing of_node_put() From: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, windhl@126.com To: Liang He , jonathanh@nvidia.com, mturquette@baylibre.com, pdeschrijver@nvidia.com, pgaikwad@nvidia.com, thierry.reding@gmail.com Date: Wed, 15 Jun 2022 23:00:35 -0700 User-Agent: alot/0.10 Message-Id: <20220616060037.5AEB8C34114@smtp.kernel.org> X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The subject should match historical subjects $ git log --oneline -3 -- drivers/clk/tegra/clk-tegra30.c shows mostly "clk: tegra: ". Can you also combine this with the other tegra patch? Don't think we need two patches for essentially the same thing. Quoting Liang He (2022-06-15 20:36:22) > In tegra30_clock_init, of_find_matching_node() will return a node > pointer with refcount incremented. We should use of_node_put() when > the node pointer is not used anymore. >=20 > Signed-off-by: Liang He > --- > changelog: >=20 > v2: use real name for Sob Thanks! > v1: fix missing bug