Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220616032448.3974916-1-windhl@126.com>
References: <20220616032448.3974916-1-windhl@126.com>
Subject: Re: [PATCH v2] drivers: clk: (clk-nomadik) Add missing of_node_put()
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org, windhl@126.com
To:     Liang He <windhl@126.com>, linus.walleij@linaro.org,
        mturquette@baylibre.com
Date:   Wed, 15 Jun 2022 23:02:23 -0700
User-Agent: alot/0.10
Message-Id: <20220616060225.3495EC34114@smtp.kernel.org>
Precedence: bulk

Same subject line comment applies here. Look at previous patches to the
file.

Quoting Liang He (2022-06-15 20:24:48)
> diff --git a/drivers/clk/clk-nomadik.c b/drivers/clk/clk-nomadik.c
> index bad2677e11ae..48d5772b36a5 100644
> --- a/drivers/clk/clk-nomadik.c
> +++ b/drivers/clk/clk-nomadik.c
> @@ -99,7 +99,7 @@ static void __init nomadik_src_init(void)
>         if (!src_base) {
>                 pr_err("%s: must have src parent node with REGS (%pOFn)\n=
",
>                        __func__, np);
> -               return;
> +               goto out_put;
>         }
> =20
>         /* Set all timers to use the 2.4 MHz TIMCLK */
> @@ -132,6 +132,9 @@ static void __init nomadik_src_init(void)
>         }
>         writel(val, src_base + SRC_XTALCR);
>         register_reboot_notifier(&nomadik_clk_reboot_notifier);
> +      =20
> +output:
> +    of_node_put(np);  =20

tabbed incorrectly?