Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH -next] power: supply: ab8500: add missing
 destroy_workqueue in ab8500_charger_bind
To:     Sebastian Reichel <sebastian.reichel@collabora.com>,
        Linus Walleij <linus.walleij@linaro.org>
CC:     <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <gaochao49@huawei.com>
References: <20220512093844.1109923-1-zhengbin13@huawei.com>
 <20220609222239.5fssqczkdqy4inoz@mercury.elektranox.org>
From:   "Zhengbin (OSKernel)" <zhengbin13@huawei.com>
Message-ID: <27654cfe-4d6e-8b5f-aaee-9f9a3117b3a2@huawei.com>
Date:   Thu, 16 Jun 2022 14:10:17 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.0
MIME-Version: 1.0
In-Reply-To: <20220609222239.5fssqczkdqy4inoz@mercury.elektranox.org>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 2022/6/10 6:22, Sebastian Reichel wrote:
> Hi,
>
> On Thu, May 12, 2022 at 05:38:44PM +0800, Zheng Bin wrote:
>> ab8500_charger_bind misses destroy_workqueue in error path,
>> this patch fixes that.
>>
>> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
>> ---
> LGTM, but adding Linus to Cc and waiting a bit to give him time to
> react.
>
> -- Sebastian
ping
>
>>   drivers/power/supply/ab8500_charger.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
>> index d04d087caa50..a5d055a628e7 100644
>> --- a/drivers/power/supply/ab8500_charger.c
>> +++ b/drivers/power/supply/ab8500_charger.c
>> @@ -3378,6 +3378,7 @@ static int ab8500_charger_bind(struct device *dev)
>>   	ret = component_bind_all(dev, di);
>>   	if (ret) {
>>   		dev_err(dev, "can't bind component devices\n");
>> +		destroy_workqueue(di->charger_wq);
>>   		return ret;
>>   	}
>>
>> --
>> 2.31.1
>>