Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1156412iog; Wed, 15 Jun 2022 23:29:09 -0700 (PDT) X-Google-Smtp-Source: AGRyM1ucRrv50F2QS1Q7QFlTJIb/A8k2FOUHhT5hypKmxng6b6Ee5xp2zZ1X5LHr9yDAi9ZtttjO X-Received: by 2002:a17:902:f7c7:b0:169:a8b:def7 with SMTP id h7-20020a170902f7c700b001690a8bdef7mr202458plw.128.1655360949265; Wed, 15 Jun 2022 23:29:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655360949; cv=none; d=google.com; s=arc-20160816; b=zxDcQvy5AVJpunnNlCg2fF1dY1QjQ/71CbiJvOI3UuxIL4eEaCvYv+1HKRlaAARtmg 36QscWIV8oSqbgRRMfFgvINOwXRufiRRp44c6dy5/GzT6/v+BZ1zHsIHdynS7hyUT51m p9sNBXUtsY+ytOtnp+4NTAbPaWitNe4EqFgEsRcm5JjxV2NpNABi3TEjSF93eSSjGD2D OVZ0Z+Cyr4T15ZA4vJN61iVl0ldpkGUXn3YxQpC3kkBRf8Q2n+EdQxYimr0YUc5JqqVc CVIORlIl2RCaQwOTowa1XctTbsVsGnRdHVUL/TL2Mc/RPyP/YkV4Zdli2Ru1jxXVLPpG /h8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9IlCM4qscouDgJZ0O1z3XWz1+iaMBhBno5bdb5wFRH8=; b=P+Kj+8xB6ZHHxfuSOlpaPJgjc2id8uG/t2G38J3skqAJM4Vwgof6332CPa4v75HYws PHdtfKD/SGgexIlz8Y7E2B9YhlwG7I01iruVaSMbXCPRIsvNqeYh2j+1ojGuz65BToZw b6o1td9frEYSor9Reb4ONvpD2jlBTePVgyn8sNlJ4k3cGHHVK3po16swaLYxNykhaMXX uWY6jIBOpHFPViI9UabWKT75uZTUfhznPRnmRZGFYVnNqJlZjLO5hlK8dvfioDyWgeQ7 IRMrFrw4rLj7e+owyJOVZ2nXhtFJnkmw8P5/A6s1UIIIznFtyEKAiYWf8D6/M3CNrsV/ iprQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=M8OgglVh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s23-20020a170902b19700b001690142da59si1590485plr.100.2022.06.15.23.28.56; Wed, 15 Jun 2022 23:29:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=M8OgglVh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359053AbiFPGIr (ORCPT + 99 others); Thu, 16 Jun 2022 02:08:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358995AbiFPGId (ORCPT ); Thu, 16 Jun 2022 02:08:33 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CBB625C78 for ; Wed, 15 Jun 2022 23:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9IlCM4qscouDgJZ0O1z3XWz1+iaMBhBno5bdb5wFRH8=; b=M8OgglVh3AX1hsPInRYzOJXos9 SuP6xskoKN4YfAz5d3S2WUsmR+vgytQC6M7HzxKyIraBfBZuYr6kF5e1QnGAE4HdzpfQuMPcp9h36 8BxfiRzAFYRduVUtPF1YLq1LSAc9Wz45p+p0ylZdIN2oA8rSrwVdEXrqIdo4Kt3oPR4ejgmxEosA0 +Iyf57annfxAa5EMyqriqPM22o6xIWyl7xgA4hH6wtXfrBdHow11TS/6Lmn/ZEAaCZHwXjp3dZwsZ WfQNrPeCfELcXAtZhNAQyagR6ogOL/VqYRVCkUhIAmaBy0gWyq1iYiuAObZ4iOWcJDrUeIFPgdI4V RxpNzhRg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1ig2-000gS2-Ji; Thu, 16 Jun 2022 06:08:22 +0000 Date: Wed, 15 Jun 2022 23:08:22 -0700 From: Christoph Hellwig To: Jan Kara Cc: LKML , Christoph Hellwig , Greg Kroah-Hartman , linux-mm@kvack.org, Suzuki K Poulose , Guenter Roeck , Alexandru Elisei Subject: Re: [PATCH] init: Initialize noop_backing_dev_info early Message-ID: References: <20220615214815.6901-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220615214815.6901-1-jack@suse.cz> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 15, 2022 at 11:48:15PM +0200, Jan Kara wrote: > +extern int bdi_init(struct backing_dev_info *bdi); No need for the extern. Otherwise looks good: Reviewed-by: Christoph Hellwig And this remind me that I really want to kill noop_backing_dev_info and just use a NULL bdi for this case eventually..