Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v2 2/2] mm/swapfile: release swap info when swap device is
 unpluged
To:     Christoph Hellwig <hch@infradead.org>
CC:     <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>, <ying.huang@intel.com>,
        <willy@infradead.org>, <vbabka@suse.cz>, <surenb@google.com>,
        <peterx@redhat.com>, <neilb@suse.de>, <naoya.horiguchi@nec.com>,
        <minchan@kernel.org>, <louhongxiang@huawei.com>,
        <linfeilong@huawei.com>, liubo <liubo254@huawei.com>
References: <20220615070228.2858170-1-liubo254@huawei.com>
 <20220615070228.2858170-3-liubo254@huawei.com>
 <YqnA+nZzkPYsw6CI@infradead.org>
From:   Miaohe Lin <linmiaohe@huawei.com>
Message-ID: <94b554c5-50cc-141c-c494-14005425930a@huawei.com>
Date:   Thu, 16 Jun 2022 15:00:24 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <YqnA+nZzkPYsw6CI@infradead.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2022/6/15 19:22, Christoph Hellwig wrote:
> Sorry, but this is simply broken.  We can't just do d_path magic
> here.  That being said the problem is real, and I think the right
> answer is to offer a swapoff variant that doesn't need to open the
> underlying device or file, but useѕ some kind of handle.  I'm just

When swap device is unplugged, the swap_file->f_path.dentry will be in the
d_unlinked() status. Could we use it to detect the problem instead? IMHO, we
can found the unplugged swap devices this way and further get the right swap
device to swapoff through comparing the swap device name with @specialfile.
Or am I miss something?

> not sure what would be a good handle here.

Using handle sounds like a good idea too. :) But can the above solution be acceptable?

> .
> 

Thanks!