Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <74f94464-a095-f539-746a-853b8f1d52ca@os.amperecomputing.com>
Date:   Thu, 16 Jun 2022 14:25:14 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.10.0
Subject: Re: [PATCH v8 1/3] ipmi: ssif_bmc: Add SSIF BMC driver
Content-Language: en-US
To:     Randy Dunlap <rdunlap@infradead.org>,
        Corey Minyard <minyard@acm.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Brendan Higgins <brendanhiggins@google.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@aj.id.au>,
        Wolfram Sang <wsa@kernel.org>,
        openipmi-developer@lists.sourceforge.net,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org,
        linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org
Cc:     Open Source Submission <patches@amperecomputing.com>,
        Phong Vo <phong@os.amperecomputing.com>,
        "Thang Q . Nguyen" <thang@os.amperecomputing.com>
References: <20220615090259.1121405-1-quan@os.amperecomputing.com>
 <20220615090259.1121405-2-quan@os.amperecomputing.com>
 <8b7841a9-9313-b1d5-8a80-a65cfa8e7b4d@infradead.org>
From:   Quan Nguyen <quan@os.amperecomputing.com>
In-Reply-To: <8b7841a9-9313-b1d5-8a80-a65cfa8e7b4d@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cHRVZlprSURSbk51TEdObnFhczRaL2tuN0F2TkF6Y20xMGllNE9yWVY3dXZw?=
 =?utf-8?B?ZXFUdFY2Y3BMNTdjb1VINjl3NVdSL2l5OWQ1RGM2VGxVV3ZFUCtXVGtvQ2th?=
 =?utf-8?B?Mng0ektoejIzVlV5K0hTTllFUXphY1ppQ1Z0dnJ5Z250UHBDZVVhNE95TDV3?=
 =?utf-8?B?RTR3b0VxRmxpOWpRVko4ZFVaWDlyZFE4clhyaHJtWnZEQzZMd3Y4UXZ0MW1M?=
 =?utf-8?B?M0NlYnF0cFFTMFJMaFN0VUZGYnY2NEJ5NlROU0pYUW9TeTlMbnpTaHhyNjBB?=
 =?utf-8?B?alpiNjNMNCtZRk9lTm9YUUVReFJOYVNkSCtmdWZjSlFlZ014WXBHdWhlc2xm?=
 =?utf-8?B?V3BCKzJ5L2xzbGJXTGlsQlRlcUxEN3MrSW1GU05CS0crckZkLzVBTmNrOVpW?=
 =?utf-8?B?S2cvOGFJR3d0VVdIOTVDY0k3QjA0dlk1RmhaZTh0UlJvOGZnZGFPR21tRXM1?=
 =?utf-8?B?VW8zdkJzd3VaYTNWaTRIOU5RRG5NOVowV3dZTThRaVBNQUJwbWZaTlo2NlVV?=
 =?utf-8?B?U3BzQ2ZiMGM5L0xYOEFtdzVSOTIrRDB0b2R1TjY5SHdDSlptc2FON1huZm42?=
 =?utf-8?B?bTFja3hGeEtWWGNVWHVhUXFNd09YUUVVd2gvT1BjOEsyNVJSa20rUk1mV09G?=
 =?utf-8?B?b29CSUF2QmtPZ1BLWHM1WWt0YitzbEVIR2RUVHQ5NWlTNzliRUxVTXU1am9Y?=
 =?utf-8?B?RkV3eEM0Z1luaG54RUpmSVcxRkJzckdLa2RzaEsyNkdNMVNYNzZwY0NHUjV2?=
 =?utf-8?B?NUZvMVVHZUl0T1d0aGNYMEs0S0ZhQkQ0S2FTd0JjeEdMWTlMNmFTc0N4T2NB?=
 =?utf-8?B?d2F4S2N0Ri9HNE0vVUR1WjhjU0dSTmQ5aEM0QjV2eG84QlpodnNZU01tLzdn?=
 =?utf-8?B?bUluM1pjZjFCN2h3dVhMRXVlQXVwVXZIWlJCb3U3dExjSXRpaTFaWHJRS01q?=
 =?utf-8?B?NzhTbGtycS9Td21EdmozSVB3UmlSdXR3cUJIRW0wa2pPUzM3aVJ0aHhFakxl?=
 =?utf-8?B?M3VHSVUzeU1GbHNqZjFaY2VtZVJ1b0J0YzVpSGhiR2pCVmpweDZwaDFoRTd6?=
 =?utf-8?B?d3Zuem5IdWIwc0trdnJxakFPZWszZ2c2YVI4MUlzcSs0S1JWeVJVUlVKOC90?=
 =?utf-8?B?TkwvWGM4azlIMmdOZ3YzSkliVHpUQ2ViU1Y5cktOcGprMFBkeGhUMHBoVXd3?=
 =?utf-8?B?WlpVYndtVkZyMXBucDFRbEV3TkY2V0ZFM0w3YzlWcnJqdHkvREZGZms5L2JC?=
 =?utf-8?B?SkVOOTNDeUc2T3U4T2w3RzBLMmJEbmZjTVQydEd2L21pMVorb0twSVIrRGdS?=
 =?utf-8?B?cTEydWN5d20xT3JMNzh1UlAyOUxJUThwbFJ5UnE3M1p5SzNDNHJHWG1HRkc1?=
 =?utf-8?B?NlpWMUN2dm9Yc0Nyb01TSDJrN0hSMU00M1gwNnl2UEhCTWFrc0M2bnVsa1lP?=
 =?utf-8?B?dWZiRGhrL2s1THMwQXdUUjNZMlVoc2NlYmRwWmsybGtpam45YmVZY1F2YXpN?=
 =?utf-8?B?WFR4U1laMitDT2t3Ny9YQVVxODAzaEMyYXAvNEJXQ0YrUE9GMGtsSC9MWnNN?=
 =?utf-8?B?aTFudmpuVEllQnN1VHBKUzdNQm1LU2ZNRnEzZ2xOTmtQdXFOSVIrWFFGTzVn?=
 =?utf-8?B?MGxlekNjemNMM3dIc1lLVlRXUTZ2Ri9XV2ZONEx4bG56MFQvQ0s0OU1YSGtz?=
 =?utf-8?B?R204ZkwxdkFneGhJRURieEpROC9iQnFaUVZvNGkvU1QvOXcvYmlXVGFGWTZr?=
 =?utf-8?B?eE42a1oranpTMHg3aGpsaG01dVNFY2F1K0hpbjF5akgvbm4zU3lEQUdRWldu?=
 =?utf-8?B?SmVtejFFYzFDRFoxNmdtV1V6aVJRZTBGQk5wSVlEYjQzQXpROVd0Z25Iblp3?=
 =?utf-8?B?ZkUwQnh1RElJczg5SGtYWjVDYmsyTko1dytZOUQvaHNiSVlVNXR0RjZ5d3pU?=
 =?utf-8?B?djc0R2l4RWFMNHZlc2toOXdWMGlrU2xSSkNDUW5lSmRKN1RhdXlOM2tCNW41?=
 =?utf-8?B?dUVZV2cwanVYVG1QaGhRVjZFZ1dPVVRDUGlwQk5EVGRyM2RrakdTczUySG5n?=
 =?utf-8?B?L1RBcDZzZGdtTVFNcjU3Zk02WXBDY1RNbXJFZm03aldoamhCaTgrY3UwNzVv?=
 =?utf-8?B?SkJLVWhaWTRONVBDV2pxdkgrWFhJOG5XbS9vWUppZWhEZ0pZRm1QdXZjSzVi?=
 =?utf-8?B?RDZvemRyRlpOa1dLWDNaRnQwN09BQmpMc3FlKzBHNFV1WDdNNmd1Mks5WXgw?=
 =?utf-8?B?NkxPT3Z3VWFpMXR4eS9vOHowaThUK2lBS0NrdDJiRk56SXBjWVBFSnV4Yzkv?=
 =?utf-8?B?T3BoOVYxV3NWbFlVNnJuVmpBY3lZOWhQd252K0JOR1IxZUtWblRaUTNxZnFH?=
 =?utf-8?Q?5mJ4OwykjmaPoykPCj5JWBkixBACEIAmL3QXQ?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2b5dd06-411f-4af8-2289-08da4f696319
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR01MB7282.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2022 07:25:28.5025
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Hzt+lPH04neB8PYyFyXTzcpI8nmyCY7ht91kPxFKGQvOaXZwfhSz8stmHp/lF0hyM7pZMtEnHroljByX2dCHU9qItsSqGdUEt5xK+AsE0Xg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR0101MB3099
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 15/06/2022 23:06, Randy Dunlap wrote:
> 
> 
> On 6/15/22 02:02, Quan Nguyen wrote:
>> diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig
>> index b061e6b513ed..18a89093d64e 100644
>> --- a/drivers/char/ipmi/Kconfig
>> +++ b/drivers/char/ipmi/Kconfig
>> @@ -169,6 +169,17 @@ config ASPEED_BT_IPMI_BMC
>>   	  found on Aspeed SOCs (AST2400 and AST2500). The driver
>>   	  implements the BMC side of the BT interface.
>>   
>> +config SSIF_IPMI_BMC
>> +	tristate "SSIF IPMI BMC driver"
>> +	select I2C
> 
> No. That should be:
> 	depends on I2C
> 
> We don't select an entire subsystem just to satisfy one driver.
> 
>> +	select I2C_SLAVE
>> +	help
>> +	  This enables the IPMI SMBus system interface (SSIF) at the
>> +	  management (BMC) side.
>> +
>> +	  The driver implements the BMC side of the SMBus system
>> +	  interface (SSIF).
>> +
> 
> Thanks.

Thanks Randy,
it should be change to "depends on I2C && I2C_SLAVE"

Thanks,
- Quan