Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1215151iog; Thu, 16 Jun 2022 01:14:23 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u4PLdTXQpO/BbQMrJVW6u4PKJEJNEDJ8af/ejV3YqPaA1GOho4wXP1vX4DWemHWg6Dn1TE X-Received: by 2002:a17:902:e80c:b0:167:5e77:e696 with SMTP id u12-20020a170902e80c00b001675e77e696mr3728766plg.119.1655367263468; Thu, 16 Jun 2022 01:14:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655367263; cv=none; d=google.com; s=arc-20160816; b=rSWKiAv2DRzZa1AJ464hNjVfbLi9Da6QzeFkpT0H1u5MUB/yYfRTejbYs1kXOlB0il nVgG5Jm9MWBREn5nHl3LZeNZEV+OTXtb0RXtjU02th8DCiR9Y4J51cviWhFlHh5mibos +unvbGR61bjbsqlXSHIShqthDOV/uLP4ptxLCnc+tQsAAq1MBnyLy1ZDa4yfxn2wYbX3 KSmTXE559vJgMuHH6g5tkmfv4PgN6MtsuO0/BlMU6Bf93Go/MUF7+DvovDFFv4JgiXX0 OqZn85zv4g2FA0hOcR2NKxXxTTf6AN768yyjO+/0bryNEtmZHWrDeDuofnE81M+VE3A/ 5oLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :feedback-id:dkim-signature:dkim-signature; bh=wG8AKxotIC4hOqs7tLCZFx1yAYerGnafok9svmkMztY=; b=kWhaWnfWM1rnaKV99rGrNJ4Xkep2uuLH480wsMfM3uym/2ON+0gFFbPpWqo9X1J6kZ om37BewS3NE1HTw24fSw7vXjC2YkNT/XarT7GUwghppPBxG701wcYr9rAhYHlPn76cDm 8YdYTLYgWPzz+UMDu+dL+l7/YF5Mn3YH1/5EQTUt+k4fHkPbhsxUUJ323tjYEC8dBKDE D5zB/MTH30Ge8Fg7J6GmpW/QpysSzJvR+ztGiCJGOPWmU8pFdRc/FsMOGl0smJdXoVD/ BsySjR3fH3q/HfPyYEoKaOJyq33Vokn1xZjSUUom80qEKsY+yfRqJN0mrrHIdvgji6QN Zalg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm1 header.b=At1KF5yY; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b="Iu0/ri7w"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a20-20020a170902b59400b001624d7f36acsi1556656pls.592.2022.06.16.01.14.09; Thu, 16 Jun 2022 01:14:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm1 header.b=At1KF5yY; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b="Iu0/ri7w"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359127AbiFPHxT (ORCPT + 99 others); Thu, 16 Jun 2022 03:53:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359467AbiFPHxN (ORCPT ); Thu, 16 Jun 2022 03:53:13 -0400 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5E1E183B5 for ; Thu, 16 Jun 2022 00:53:12 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 39F1B5C02F5; Thu, 16 Jun 2022 03:53:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 16 Jun 2022 03:53:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1655365992; x= 1655452392; bh=wG8AKxotIC4hOqs7tLCZFx1yAYerGnafok9svmkMztY=; b=A t1KF5yYBildNv/cPjbipuAlP1QT1ynvD+gCjnrzazE/qWno7Q8cElZJhaS/QUF7g 2DpO3joO/yBPXs3HoyJ09M9Xwu/kMs4ACokFazmPQBAzGYXTDCWlCN1e+9EFzVEl Q3anL4Fd8uYYL/LFXcgNSpxsC+R8n20NGVT0MLxpPXN8FdlR5eYPJMAv5e/11pOu pGKOxpikPNdOumkdRFMIBzmwyyFJK1B8KYQmgjDu/eY3aA772K2EKZWNgcppzSPv LcabTueTDKnWj6JIeFdErfkZLfzfawmoAsysTIu5+JUnNcrOfr58Hjkj5Umx0Q0X il1F+0cQXXYTiSJNPo2aA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1655365992; x= 1655452392; bh=wG8AKxotIC4hOqs7tLCZFx1yAYerGnafok9svmkMztY=; b=I u0/ri7wBl8TnhW+xXSY9Lww5W7sWjep8d61JpS8QYqV1XvM+PukkizXdK3E7QQan gHmCuhMp0E0vjb0mjno2dz3iQsYiYT9AGY/KHpbr6ZstKce/KPk0jsQ561SXAeRH zKKKgD/Rit1d3cmSVM7pIoXH50ywUaolR/4ezmUr6N+bmJ1VqvmIe0VPEyEc1EbM laoVdZJLkHu8h15De/1+bPUI6I5AbuKLp2TDbRVOxR1PZw1dt6BKveKn3VDqgb4z 7UgX5GkWBfEAHyWwlk1/dzVEOqJq2gojpBruRL2oEeeJo7GhfyYaKaOtdYIga74z gxkzuRZM6g3cBDAGzgirg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedruddvvddguddvfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfgggtgfesthekredtredtjeenucfhrhhomhepofgr gihimhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtf frrghtthgvrhhnpeeuieeggffhffffieefheduieeuvdetgeeufeffvefgtedvffehheek ffevudefieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Jun 2022 03:53:11 -0400 (EDT) From: Maxime Ripard To: Chen-Yu Tsai , Samuel Holland , Maxime Ripard , Jernej Skrabec Cc: Maxime Ripard , linux-sunxi@lists.linux.dev, Ondrej Jirman , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, David Airlie , linux-kernel@vger.kernel.org, Daniel Vetter Subject: Re: [PATCH] drm/sun4i: Fix crash during suspend after component bind failure Date: Thu, 16 Jun 2022 09:53:06 +0200 Message-Id: <165536598378.1275350.14174129398362283973.b4-ty@cerno.tech> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220615054254.16352-1-samuel@sholland.org> References: <20220615054254.16352-1-samuel@sholland.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Jun 2022 00:42:53 -0500, Samuel Holland wrote: > If the component driver fails to bind, or is unbound, the driver data > for the top-level platform device points to a freed drm_device. If the > system is then suspended, the driver passes this dangling pointer to > drm_mode_config_helper_suspend(), which crashes. > > Fix this by only setting the driver data while the platform driver holds > a reference to the drm_device. > > [...] Applied to drm/drm-misc (drm-misc-fixes). Thanks! Maxime