Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ab92690c-c3ee-ab92-5763-376db208aebb@kylinos.cn>
Date:   Thu, 16 Jun 2022 16:24:08 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v4 -next] usb: xhci: disable irq during initialization
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>,
        Hongyu Xie <xy521521@gmail.com>
Cc:     mathias.nyman@intel.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, 125707942@qq.com, wangqi@kylinos.cn,
        xiongxin@kylinos.cn, kernel test robot <lkp@intel.com>
References: <20220616080933.1238309-1-xiehongyu1@kylinos.cn>
 <Yqrl3jGyUx7sZVdL@kroah.com>
From:   =?UTF-8?B?6LCi5rOT5a6H?= <xiehongyu1@kylinos.cn>
In-Reply-To: <Yqrl3jGyUx7sZVdL@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi greg,

On 2022/6/16 16:12, Greg KH wrote:
> On Thu, Jun 16, 2022 at 04:09:33PM +0800, Hongyu Xie wrote:
>> irq is disabled in xhci_quiesce(called by xhci_halt, with bit:2 cleared
>> in USBCMD register), but xhci_run(called by usb_add_hcd) re-enable it.
>> It's possible that you will receive thousands of interrupt requests
>> after initialization for 2.0 roothub. And you will get a lot of
>> warning like, "xHCI dying, ignoring interrupt. Shouldn't IRQs be
>> disabled?". This amount of interrupt requests will cause the entire
>> system to freeze.
>> This problem was first found on a device with ASM2142 host controller
>> on it.
>>
>> Signed-off-by: Hongyu Xie <xiehongyu1@kylinos.cn>
>> Reported-by: kernel test robot <lkp@intel.com>
> 
> the test robot did not find this original problem, it only found
> problems with your original submission, which is different.
> 
"Reported-by" shouldn't had been put here.
Quote from the last email test robot sent to me，
"If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>"
Where should I put this? Or just ignore it?