Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1252049iog; Thu, 16 Jun 2022 02:17:40 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tRvnxiIIL0BBOQZhXOx9gbflA7crepOQSITMyvTDqeJ+IuIux8hUnDJO3QPRZYwFHus12B X-Received: by 2002:aa7:c744:0:b0:42d:f68f:13de with SMTP id c4-20020aa7c744000000b0042df68f13demr5133319eds.294.1655371059980; Thu, 16 Jun 2022 02:17:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655371059; cv=none; d=google.com; s=arc-20160816; b=I/k/x+84qmmbaIuAvdaet5ddIKxcmcg6lhfkFi1hAp6Jl3Bf1dTVR2BU2KbESwLQDP pDcoq/ZisXv1crI60TrfsJgrIxQPCNFKWVDJC8M6cU0+QDm+iGLSy4puFJwbGuR30aRs IYXhZMkYACI2RcY0NJzGmvx1O5boJ34O0IYV7jTP29D6zH5YuKTJvnpG799jQGSLOoGT Y80cF6j6wYDm8EnWJOtIyap/rn121xfU+TyzauUKk3rvPTtc2lSQy+WiQUko0tE6pAuH ha/vvThEfxnEfnZNQfDaVCYeN8JDSwUY6wFu36qZuVCqAhfcQnttpsjj5hkG3IZ9FOXH bD/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=jdSWLIZ0MenzYUp3ew5KMxJnPoWDDocCxMR1XJe5vcs=; b=ilXOpdJZSMO+GOWXGZGYiOOFt7CqUubCd0dMpGPQVGqTcnufpFLqTHouqT7sGOmJ/S um+ee6BysLhdc42w/U93B2c5zeEHlHn3zviAZnhSfCblStiEdlbaJQ8dBDdQ4gkYRcd2 aXP5Hdk9gZ5pL+Vq3nLLJmzj2iUw5KFMgZu/O/N+14dQt1++SXnNqNvCcTjDT4Dd6KsL M16dGtBjAYJHDDsGRkkFryTn1QFm26mMreInkQM8P1n+znYyCM33krHMgfw/MtDzxK4C ThOIsH0PF9dQ81byEUJWiF+a4DiR8HhKeeUq19NwexUAYcN/MI4HuOthBRbJXcss6fZe UuyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p18-20020a17090664d200b006f37e31bf80si1199732ejn.120.2022.06.16.02.17.08; Thu, 16 Jun 2022 02:17:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376406AbiFPJE3 (ORCPT + 99 others); Thu, 16 Jun 2022 05:04:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229630AbiFPJE2 (ORCPT ); Thu, 16 Jun 2022 05:04:28 -0400 Received: from out199-17.us.a.mail.aliyun.com (out199-17.us.a.mail.aliyun.com [47.90.199.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CFD92FE5C; Thu, 16 Jun 2022 02:04:25 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R851e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=15;SR=0;TI=SMTPD_---0VGZs4Mm_1655370252; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VGZs4Mm_1655370252) by smtp.aliyun-inc.com; Thu, 16 Jun 2022 17:04:20 +0800 From: Jiapeng Chong To: neal_liu@aspeedtech.com Cc: balbi@kernel.org, gregkh@linuxfoundation.org, joel@jms.id.au, andrew@aj.id.au, sumit.semwal@linaro.org, christian.koenig@amd.com, linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, Jiapeng Chong Subject: [PATCH] usb: gadget: Remove unnecessary print function dev_err() Date: Thu, 16 Jun 2022 17:04:10 +0800 Message-Id: <20220616090410.128483-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The print function dev_err() is redundant because platform_get_irq() already prints an error. This was found by coccicheck: ./drivers/usb/gadget/udc/aspeed_udc.c:1546:2-9: line 1546 is redundant because platform_get_irq() already prints an error. Signed-off-by: Jiapeng Chong --- drivers/usb/gadget/udc/aspeed_udc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c index 1fc15228ff15..2c3dc80d6b8c 100644 --- a/drivers/usb/gadget/udc/aspeed_udc.c +++ b/drivers/usb/gadget/udc/aspeed_udc.c @@ -1543,7 +1543,6 @@ static int ast_udc_probe(struct platform_device *pdev) /* Find interrupt and install handler */ udc->irq = platform_get_irq(pdev, 0); if (udc->irq < 0) { - dev_err(&pdev->dev, "Failed to get interrupt\n"); rc = udc->irq; goto err; } -- 2.20.1.7.g153144c