Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 16 Jun 2022 11:00:52 +0200
From:   Jan Kara <jack@suse.cz>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Jan Kara <jack@suse.cz>, LKML <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-mm@kvack.org, Suzuki K Poulose <suzuki.poulose@arm.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Alexandru Elisei <alexandru.elisei@arm.com>
Subject: Re: [PATCH] init: Initialize noop_backing_dev_info early
Message-ID: <20220616090052.6xhfljxcis7ymqlb@quack3.lan>
References: <20220615214815.6901-1-jack@suse.cz>
 <YqrI1kS/BxEQ+39V@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YqrI1kS/BxEQ+39V@infradead.org>
Precedence: bulk

On Wed 15-06-22 23:08:22, Christoph Hellwig wrote:
> On Wed, Jun 15, 2022 at 11:48:15PM +0200, Jan Kara wrote:
> > +extern int bdi_init(struct backing_dev_info *bdi);
> 
> No need for the extern.

Yes, fixed up.

> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks for review!

> And this remind me that I really want to kill noop_backing_dev_info
> and just use a NULL bdi for this case eventually..

Yes, I'm just not sure whether the checks for bdi / wb being NULL in lots
of places will not be too annoying... But maybe you'll be able to come up
with some wrappers that will make things bearable.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR