Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 16 Jun 2022 11:34:51 +0200
From:   Oleksij Rempel <o.rempel@pengutronix.de>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Jakub Kicinski <kuba@kernel.org>,
        Michal Kubecek <mkubecek@suse.cz>,
        Jonathan Corbet <corbet@lwn.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
        kernel@pengutronix.de, Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next v1 1/1] net: phy: add remote fault support
Message-ID: <20220616093451.GA28995@pengutronix.de>
References: <20220608093403.3999446-1-o.rempel@pengutronix.de>
 <YqS+zYHf6eHMWJlD@lunn.ch>
 <20220613125552.GA4536@pengutronix.de>
 <YqdQJepq3Klvr5n5@lunn.ch>
 <20220614185221.79983e9b@kernel.org>
 <YqlUCtJhR1Iw3o3F@lunn.ch>
 <20220614220948.5f0b4827@kernel.org>
 <Yqo8BuxL+XKw8U+a@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <Yqo8BuxL+XKw8U+a@lunn.ch>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Wed, Jun 15, 2022 at 10:07:34PM +0200, Andrew Lunn wrote:
> On Tue, Jun 14, 2022 at 10:09:48PM -0700, Jakub Kicinski wrote:
> > On Wed, 15 Jun 2022 05:37:46 +0200 Andrew Lunn wrote:
> > > > Does this dovetail well with ETHTOOL_A_LINKSTATE_EXT_STATE /
> > > > ETHTOOL_A_LINKSTATE_EXT_SUBSTATE ?
> > > > 
> > > > That's where people who read extended link state out of FW put it
> > > > (and therefore it's read only now).  
> > > 
> > > I did wonder about that. But this is to do with autoneg which is part
> > > of ksetting. Firmware hindered MAC drivers also support ksetting
> > > set/get.  This patchset is also opening the door to more information
> > > which is passed via autoneg. It can also contain the ID the link peer
> > > PHY, etc. This is all part of 802.3, where as
> > > ETHTOOL_A_LINKSTATE_EXT_STATE tends to be whatever the firmware
> > > offers, not something covered by a standard.
> > 
> > I see, yeah, I think you're right.
> > 
> > But I'm missing the bigger picture. I'm unclear on who is supposed 
> > to be setting the fault user space or kernel / device?
> 
> It is also a bit unclear, but at the moment, i think user
> space. However, i can see the kernel making use of maybe RF TEST to
> ask the link peer to go quiet in order to perform a cable test.
> 
> Oleksij, what are your use cases?

Currently I was thinking only about diagnostic:
- request transmit pause for cable testing
- request remote loopback for selftest. In this case I will need to use
  vendor specific NextPage to request something like this.

> Maybe add something to patch 0/X indicating how you plan to make use of this?

I can move it from first patch if needed.

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |