Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1296402iog; Thu, 16 Jun 2022 03:26:03 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tqakQsB7onUJuXEcLNRV3gu5bhN7LzFYb+Pmfm3Gz5COyvIu8aA5Dvc9OZRN1pqAR0x+0v X-Received: by 2002:a17:903:2cf:b0:151:a932:f1f0 with SMTP id s15-20020a17090302cf00b00151a932f1f0mr4058522plk.130.1655375163475; Thu, 16 Jun 2022 03:26:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655375163; cv=none; d=google.com; s=arc-20160816; b=Gah5gzjs2pn7u6YEQ6QG1ubLwqpB1uSLer6N77otgHnmSs01Ma7vE7DSXyComn57yj EDCRLSqcuyYEVK+RN6MFS+WmJsFAGYIz6Uoj79hrLai03eHS29RyVUxGO93bzR8mI7N7 UZyhP676Sj2rur5PTdYsYvTbjvBqbfEIegkqSTM+HIZn0F3UmBW+hKnxKMN/ObOkCDda b4UhXDJ8AFbbfQQbZOA5zqKXYU+ydSfk0hsA83iyXKUhLFYUDyabufwJrl3StlNSHo8G OS17V546JUljGoQ20bFSpjmO6slUyPhV50t9NBbe7Xg6URmSLbS4n5Ived6JFWffnQo4 EC4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=tbx8M5QHD61QOIDnLSo3ppA8Cyav/N1cvEztbRdYGgk=; b=wX1aHiSpi7I8eprbeKnn/JkJDlZM1VZkn0Yz/J5NmQcu6pbkOrHhCq7RiO6i/R4Tke QYAXTmvBJST3Tsy2nbmJQf/XsjUIEVmGAy1kWeI1pB61StbGPPTD9o13niKh6YWivY5H n+HhypLUtDvGcnJKHlKKZ1rcoyPgcBWfeRjeRxpoiHSUyjCELMDYwuQGEVVXD+QZXw/h Bka3fKPNWmDCnquvdXazyiNLzOrsBbyrmMCKEFbEi9nar/gaGbELtsLaAE9bds0Hi8vK 8IfDkHkvO3obVP4mKVOd3kSrXqC6a9+9sMpaI0E/jl79ZjedcQlFWZVhXY5FqJPBxEs6 whQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OWHHpY0w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v7-20020aa799c7000000b0051bbc660065si1886727pfi.328.2022.06.16.03.25.51; Thu, 16 Jun 2022 03:26:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OWHHpY0w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376305AbiFPKJI (ORCPT + 99 others); Thu, 16 Jun 2022 06:09:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358706AbiFPKJD (ORCPT ); Thu, 16 Jun 2022 06:09:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B49A25C86E; Thu, 16 Jun 2022 03:08:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 504B86158A; Thu, 16 Jun 2022 10:08:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22189C3411C; Thu, 16 Jun 2022 10:08:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1655374138; bh=WjhFuQTsGkEU13jyp5Zn8zUadcjOo0hy77oeeLB3pVk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OWHHpY0wHTx4xPaCBbGLPIgqVPi5VJdPF8I/heqgzifPvhe5gwjGy3GTpWDQZfW2C AVsoCPlKIIY9/7NhM1yW3tjJWRkbSQhv7TERBwmRGNEF/VdbWMna8xaE9R2yEqHrDN SqgOzPCA1HNw1z2ipA6GXN8dm0QhIireNoYmiYkI= Date: Thu, 16 Jun 2022 12:08:55 +0200 From: Greg Kroah-Hartman To: Sebastian Ene Cc: Rob Herring , Arnd Bergmann , Dragan Cvetic , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, maz@kernel.org, will@kernel.org, vdonnefort@google.com, Guenter Roeck , kernel test robot Subject: Re: [PATCH v6 2/2] misc: Add a mechanism to detect stalls on guest vCPUs Message-ID: References: <20220616092737.1713667-1-sebastianene@google.com> <20220616092737.1713667-3-sebastianene@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220616092737.1713667-3-sebastianene@google.com> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 16, 2022 at 09:27:39AM +0000, Sebastian Ene wrote: > This driver creates per-cpu hrtimers which are required to do the > periodic 'pet' operation. On a conventional watchdog-core driver, the > userspace is responsible for delivering the 'pet' events by writing to > the particular /dev/watchdogN node. In this case we require a strong > thread affinity to be able to account for lost time on a per vCPU. > > This part of the driver is the 'frontend' which is reponsible for > delivering the periodic 'pet' events, configuring the virtual peripheral > and listening for cpu hotplug events. The other part of the driver > handles the peripheral emulation and this part accounts for lost time by > looking at the /proc/{}/task/{}/stat entries and is located here: > https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3548817 > > Reported-by: kernel test robot The robot reported stalls on vcpus? I think you need to fix this up... greg k-h