Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
CC:     "balbi@kernel.org" <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "joel@jms.id.au" <joel@jms.id.au>,
        "andrew@aj.id.au" <andrew@aj.id.au>,
        "sumit.semwal@linaro.org" <sumit.semwal@linaro.org>,
        "christian.koenig@amd.com" <christian.koenig@amd.com>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linaro-mm-sig@lists.linaro.org" <linaro-mm-sig@lists.linaro.org>
Subject: RE: [PATCH] usb: gadget: Remove unnecessary print function dev_err()
Thread-Topic: [PATCH] usb: gadget: Remove unnecessary print function dev_err()
Thread-Index: AQHYgWATtppy2IZglE2yH02xMWGTe61R0ViQ
Date:   Thu, 16 Jun 2022 10:16:05 +0000
Message-ID: <HK0PR06MB320275CCAE8E424810C8907F80AC9@HK0PR06MB3202.apcprd06.prod.outlook.com>
References: <20220616090410.128483-1-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <20220616090410.128483-1-jiapeng.chong@linux.alibaba.com>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hRoow4H3k7kMuIKUf3yIpFUSQVN51K+JKiUDbXoaQsa8zOREUeeKF/nSPVIf?=
 =?us-ascii?Q?25jJtUNUJMYPzkGAEdTAZfNz4URv/s6APABcxClopOA91se7rS4j3G+ESU8Y?=
 =?us-ascii?Q?+rCdg+kGyXQ4nq8WIJcJTIMXQoZQY+Hi+VeUIibc1rmFWrcbGSc+mGzMcAxi?=
 =?us-ascii?Q?EkQV0ygt2JnyOlullhaGNwHJL+1z7+QBOW2ZpAwp4pd/6zjajt9gjK5vo9FM?=
 =?us-ascii?Q?UB4feRsBdxRMpSrpbrEf2yuAJ91SNIQEGUmSVRn5fqq82kTn38/xe1KlwF9i?=
 =?us-ascii?Q?E+7XUq9LQuK8PD4yg+kLEAFO7uFCcJ2gpADZ3ZbngBL+88VJpR1cUbrHxZ9S?=
 =?us-ascii?Q?AJl0h1zkceirv5QNP8DG5qZy7HORXfXQbJTJxDFlHYmK/SdGyqjN+t+FV3uM?=
 =?us-ascii?Q?+6CC5y8ZhJa5I2m+I5FVqm78lTj42nTMDydStoonvBXcsuuz2IcRiJawSyaF?=
 =?us-ascii?Q?ZIsMaP9NBvOnK2gwphpNc6JkS/tPdG4+DbCzbNUKE0KDehnxMXicWxQyO4Tp?=
 =?us-ascii?Q?3S2SzBrbZj5U0/SMV0kQrwco/PUc9jOMPSAgUznerGYXE1xJSvKT4ZOTJn6y?=
 =?us-ascii?Q?8spTn0MSimg0i/E68J4mUZ3reWcpx4bV5LqbWfr4prQV9FilSwNfcKBJF4An?=
 =?us-ascii?Q?d/0IXdkPByG1/j51DakICYHqXf+1SniK9kifK9s8B2EnIVBckVNVusZdbfm/?=
 =?us-ascii?Q?fykTMxA/rPWaoxT7quXlIXZVHe7L2wHEhOHJNJpgnY86vKJ8vkjh9AHi3wvs?=
 =?us-ascii?Q?pnOmKzVuw/IaV+9B3aamtVdoXFd7/5QY7SneT0oLD/6qSHuV5pbSQff8N4Co?=
 =?us-ascii?Q?Mrcm3KfU5baOIaTUANeGE6yF47Jg21cZ6iDBaVXAdXBPXbKTHVmffvlcyxTL?=
 =?us-ascii?Q?M3FFjPzwR8aoBakgpur5PaPHG28UVbWvsSJPYQRDxNtr5PBDMg1Agk4DTqGB?=
 =?us-ascii?Q?7l4w3K5kzR6djGqmkEO2obCUWEkFJqTCq8Kv2qr3JA6cErSAchktPzt7pN//?=
 =?us-ascii?Q?24+AtmQg+T2fnOUclClJfsXdNU3Zj6InDDzKH2wZ7BPkX2gU/3fofTIHpiGi?=
 =?us-ascii?Q?7L7cXRJnZxkB1J/mlez6TQiaURIXVxELySFxIvPRjNEs98lTFuFifO/Oshz/?=
 =?us-ascii?Q?6q58t/7C8Q/yzVb216zDD7j85Nf1zcGy+uWzSFnqTCYD4bYMFpyBfCJIspqk?=
 =?us-ascii?Q?JAIljlmmmOrO4ro1hM/V+1hx2bAOOXr3QLNylsApQEzSfPRr90hjhKJxBiF1?=
 =?us-ascii?Q?oBXb72XP+yEK3RvUMeXiY2V+qG4d0WyZgwIDtcMyP86Sw3Pjh0eXdnve76FF?=
 =?us-ascii?Q?DatZmlydGGPDiGzNYJWw2h7rCJkgLxEmJULnlNA5Gc7Z7WU4rpI6hZJdGjXN?=
 =?us-ascii?Q?fkTXEx3NxRh10A8BZgI5Fjc/OdE42me1Sba0p3CJzVcvaxXjtxjG2Ov2qUcb?=
 =?us-ascii?Q?0f+3HnMnz4SIVEBlwuMZsl3OCntGXAM8XYKGS+p35L83EwJ1LY5M5y8rh7Bg?=
 =?us-ascii?Q?uEgeumLO55Xetk84cB3g3UPsRqJi3g84rFLuAhYmrjonYYj9CfRZo3GRoRO2?=
 =?us-ascii?Q?XXOB5fEXoA5XXkHsDjd+SSOBejQNrf3jMHMKgJGwSG3ejPuHKkP9VicQgjFb?=
 =?us-ascii?Q?64XOVqULPSVndHzs2JTE94waornqaKrsHJEbBBDg5YoM9N/YsRziYJFRonco?=
 =?us-ascii?Q?qjDbChoocL4Gom7Qs+TUB/URTw6gbjYf/vEkZ3/l1bkMUrl19J7UOzr93inm?=
 =?us-ascii?Q?j3Sz6z+clw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3202.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e2e87e38-09bf-4375-9397-08da4f81397c
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2022 10:16:06.0031
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: udPFDQJgl1IULP9pVKz2uQDHjlp7uFavP9NUZ8dHHwhQTtPs3zm2ZFM2BBe31pCObHltjYu1SHzmT61PLKwnjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB2764
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        T_SCC_BODY_TEXT_LINE,T_SPF_TEMPERROR autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> The print function dev_err() is redundant because platform_get_irq() alre=
ady
> prints an error.
>=20
> This was found by coccicheck:
>=20
> ./drivers/usb/gadget/udc/aspeed_udc.c:1546:2-9: line 1546 is redundant
> because platform_get_irq() already prints an error.
>=20
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Acked-by: Neal Liu <neal_liu@aspeedtech.com>

> ---
>  drivers/usb/gadget/udc/aspeed_udc.c | 1 -
>  1 file changed, 1 deletion(-)
>=20
> diff --git a/drivers/usb/gadget/udc/aspeed_udc.c
> b/drivers/usb/gadget/udc/aspeed_udc.c
> index 1fc15228ff15..2c3dc80d6b8c 100644
> --- a/drivers/usb/gadget/udc/aspeed_udc.c
> +++ b/drivers/usb/gadget/udc/aspeed_udc.c
> @@ -1543,7 +1543,6 @@ static int ast_udc_probe(struct platform_device
> *pdev)
>  	/* Find interrupt and install handler */
>  	udc->irq =3D platform_get_irq(pdev, 0);
>  	if (udc->irq < 0) {
> -		dev_err(&pdev->dev, "Failed to get interrupt\n");
>  		rc =3D udc->irq;
>  		goto err;
>  	}
> --
> 2.20.1.7.g153144c