Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <81bda7cc-fd95-8f54-4ad7-3fad9a81b831@nvidia.com>
Date:   Thu, 16 Jun 2022 14:17:11 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH 5.10 00/11] 5.10.123-rc1 review
Content-Language: en-US
To:     "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        torvalds@linux-foundation.org, akpm@linux-foundation.org,
        linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org,
        lkft-triage@lists.linaro.org, pavel@denx.de, f.fainelli@gmail.com,
        sudipm.mukherjee@gmail.com, slade@sladewatkins.com
References: <20220614183719.878453780@linuxfoundation.org>
 <9e43b35e-31da-7e51-006c-1aa69acb10d4@nvidia.com>
 <YqssBl7QRyp0nytW@zx2c4.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <YqssBl7QRyp0nytW@zx2c4.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0x5MHNGTHp2QmM5em9GWjdpVEJwYlhqY2xCNVdJcStVUFd6NXhKMVdxei9j?=
 =?utf-8?B?THJoTXY1YlNDSXMxQU9TbUFZdlFqci8xcnRic0JzRm00dWs5VFRKbUhkdnpS?=
 =?utf-8?B?Z2s4dUxFVEhtNEJzbmtkbEthanN5dEh2aUNtZnBEWkhsYno0RWFHRU91ZUtr?=
 =?utf-8?B?aVZMclFzZFA5R0ExQWNEc0liU3F4a3orN1A1cWx2dW1JRXczT2R5TS9KNkZL?=
 =?utf-8?B?MzRCaXhKOHljMGNEM0FSL2NJU2tya0pYdDBBck5GN0ZEUEpwMWxaVGpXUng3?=
 =?utf-8?B?cCszNEdVUnBERGN4dFZFaW9FUUQ4eWFWU3BSSFNYdXpXWkhTelU4NWR6S0tp?=
 =?utf-8?B?TUd5RW9UcTlkK09KM1pZdFpXR2RPSjE5RVFzeVpEWjhVZ0NOZWJFK0ZUd01K?=
 =?utf-8?B?SmoyV2d1L285QjhpaWRhNHEycmYyVSt3ZlR4ZUVJaVpDcW1LVmR0ZmhXeHYy?=
 =?utf-8?B?TmtXQWNxdE53aUhhSVYrV3NhaXlhUHlwWDV3MUFrc2JkaER5b09tSUJzT0hY?=
 =?utf-8?B?bms2bkxDalA0dzVrN3FObDdZbWN5QTUxWldvTWFOVThtQ0JjVEdSU3BMenE0?=
 =?utf-8?B?UXdDTnppVGpJZFZJakloVk5WQ25CQU1TMExBbHZiMFJoUGxEYm5ydFUxN1Vr?=
 =?utf-8?B?S3RVb1U3MFM3dThrRnhUWlVzdlNFRHNoeTJjV1BFcWJOaU1uekUzVkcwaFBX?=
 =?utf-8?B?MFQ3SzVyci84R2RqelJDVStMNU85MFZ2Tjd4VVA3dk03dkpCczlTVXpYejY0?=
 =?utf-8?B?U2gzMzZCQVYwS2dKS1FZVUo1Y2xXYjZxd2FjYWt1cE04OE9MUkZHM2hHYUsw?=
 =?utf-8?B?a3ZxdkIrMXhjU3huQ0FMNzg1LzZEUmZ6MWFkSE5Kb0d4OHhIRXBqdWlGNTJk?=
 =?utf-8?B?ZWQ4VjBDcGhub2orSlA0U1l1TzQyWUhwc3ZWY1lMaG5MSVlsWlBQVG9Xc2FB?=
 =?utf-8?B?R2JlZXFEUWdKM1VPTFBrSHZ5TlJZM0xsblVoZ05oMlZEaVkxQjY5WDlHSU5h?=
 =?utf-8?B?NXRDb3lGZ3JqdHQ0c1ducHIzZkRlYTJqODJOQTZMR0tCclJWakxLZWpGckVv?=
 =?utf-8?B?V1JFMTZNMnU4a1JsU3NkckFpZHlKYmlUSDhLUFJwTSs3UWo2SEllTFlpREJ6?=
 =?utf-8?B?MFFhRE1NcS9uQkxuUTdpKy9jcWI3a0NyblpoVnhrSWFLcmdZK2pWR0RKQzk3?=
 =?utf-8?B?cTN4ajdENjJqL1hoMjh4ejRXbmVJWXoxaGh2M2FJR0NXNkdZQlNYaUs5R2VB?=
 =?utf-8?B?ckFyc0x6ampFNk00SlIrNVFQTlBOdkZTcG5IVGFjaEc0bjdOVTRUcE1sdis5?=
 =?utf-8?B?WXgyMGlMajhCNWVicTBvaTU4bHdYTmVWZEsyM0hnVTA0VXFONEpST20vdW12?=
 =?utf-8?B?Y2c4TlJadzFYRGNrSEJOZ1hlQ3RMZ2JWZkVZN2lKVFc4L3JMUFZDbytvR2Yx?=
 =?utf-8?B?U3RUQ2tKWnhFRlNOTzhkSjJaVXJtT2JORm5JUHRKVytRYTVEaURXUm5QREgy?=
 =?utf-8?B?d1NRc0g1WkpqMjhZUzRxV3duMUs4NStuZWF6S2lSWnMzT3JqNVp3eWFwb1ZT?=
 =?utf-8?B?Zk9UUy9zZXlmWVpxd1BxbVpXVlkvOG5XTXhlbXNWQ1c1VGl6NHhQWjBaaGw3?=
 =?utf-8?B?eXI3TmoyMVpUclVFd2s1UkNzTCtNd0Exd1lPckdTQ2RsVnl5Q3JZMjUxVlFW?=
 =?utf-8?B?akQ2cGZLWkJ4Y3d3RzF0TjdudGVNSE1mbVAzVlNBU2hsb2wya095OUwzWHYv?=
 =?utf-8?B?LzUzZ1BrMU5CQ1BuRmhRaWU3ZGFEN3pYbVl5VC9YOExhNS9tQnNncTJhdC9q?=
 =?utf-8?B?bVkydXRQZFI3bDR2c0pFNjY2aG0xVlphcHpjaTdwSWNuRXl0WHpOT0FpcjBY?=
 =?utf-8?B?RnlUSUdCaGIvUGFyWXZkdm9VK2poU0JaTGVMU0dQWi9zSy9UcUpvSmw3OFVq?=
 =?utf-8?B?TWtjaWxYMDhCU2tNWFNDb2RIQS9ZV0Nnc3ZuNHNUQlVKUGZlNm1RY2RzQnI0?=
 =?utf-8?B?RE10cjBWKzZFZHozbzJCSVdBR0xrWU1ibzVWMTN3NWRCb1pUOWdaREJxN00r?=
 =?utf-8?B?dnRXZHc1TmVhaExNOTRVYWFEZFh2eU90RURnREZRZUdyWWo4VDF4a25XK0VB?=
 =?utf-8?B?RlliaWFzTnNiaHhsM2dDa1ZXcG5ZdWJVcW1zUjdGandUcmtVZ2ZYYWttbloz?=
 =?utf-8?B?THRlcXczRjYrWS9MN2pTcTRqYW50YlBaa0lTUzdFcm9ZY2ZBc1cyTVdGYnE4?=
 =?utf-8?B?NGY0U214RmY1cXJqd0t1bVlCZGpLM1NSekY0a20xTHV1d3R0c2dVRkFhMG11?=
 =?utf-8?B?Y1ZUWE13VGZabEdvLzlFUGZEVGpUaDBkU2tNaE9DUU5QT0JKVit3UXhVYzR3?=
 =?utf-8?Q?8e8wJDcXEul8zSQs=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d9b6f8f9-d737-4c5c-016b-08da4f9a8a59
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2022 13:17:19.3179
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OylIZ+v5h8GAriAnhSzsOVuej1YcQ6J4861p1UtNB6516GSq0opsJ3ACfRJS1ppk1VJrKwPQ0G7G4VE04VHqeQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB2550
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jason,

On 16/06/2022 14:11, Jason A. Donenfeld wrote:
> Hi Jon,
> 
> On Thu, Jun 16, 2022 at 09:48:37AM +0100, Jon Hunter wrote:
>> No new regressions for Tegra. I am seeing the following kernel warning
>> that is causing a boot test to fail, but this has been happening for a
>> few releases now (I would have reported it earlier but we have been
>> having some infrastructure issues) ...
>>
>>    WARNING KERN urandom_read_iter: 82 callbacks suppressed
>>
>> This appears to be introduced by commit "random: convert to using
>> fops->read_iter()" [0]. Interestingly, I am not seeing this in the
>> mainline as far as I can tell and so I am not sure if there is something
>> else that is missing?
>>
>>
>> Test results for stable-v5.10:
>>       10 builds:	10 pass, 0 fail
>>       28 boots:	28 pass, 0 fail
>>       75 tests:	74 pass, 1 fail
>>
>> Linux version:	5.10.123-rc1-gf67ea0f67087
>> Boards tested:	tegra124-jetson-tk1, tegra186-p2771-0000,
>>                   tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
>>                   tegra20-ventana, tegra210-p2371-2180,
>>                   tegra210-p3450-0000, tegra30-cardhu-a04
>>
>> Test failures:	tegra194-p2972-0000: boot.py
>>
>> Tested-by: Jon Hunter <jonathanh@nvidia.com>
>>
>> Jon
>>
>> [0]
>> https://lore.kernel.org/lkml/20220527084907.568432116@linuxfoundation.org/
> 
> Please CC me on RNG issues.

Yes no problem.

> I'm surprised that this message results in a failure. It's not a
> WARN_ON() or a BUG() that's being triggered here. This is just the
> simple `pr_warn("%s: %d callbacks suppressed\n")` in lib/ratelimit.c,
> which really shouldn't be causing your CI to fail. Sounds like your
> harness could use some adjusting.

It is not a hard failure, but any new warning will be flagged and cause 
this particular test to fail. So all I could see is that a new warning 
was occurring and wanted to understand what was going on. We can ignore 
the warning if necessary.

> Nonetheless, you have found a 4 year old bug in the urandom warning
> accounting that was recently made more easily triggerable by a newer
> commit, though not the one you mentioned. I'll fix this up and keep you
> CC'd on the patch, which should make it into stable as well.

OK, great! Happy to test anything on my end.

Cheers
Jon

-- 
nvpublic