Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 16 Jun 2022 14:27:24 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     William Breathitt Gray <william.gray@linaro.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] iio: adc: stx104: Implement and utilize register
 structures
Message-ID: <YqsvvDnFuk0KEjpf@sirena.org.uk>
References: <cover.1654118389.git.william.gray@linaro.org>
 <a2dca9435f7f1f727c696a1faa0ab9e27927f9f3.1654118389.git.william.gray@linaro.org>
 <CAHp75VepZ8P_cqnN8qJ_Wb=xM0LW3y-a22tv1otDReFSqRDFYA@mail.gmail.com>
 <YqnIygHDSUbV5yws@fedora>
 <CAHp75Vcojz1d8uGcR5CMeSFcBDCxqzDbncU2Mp-LT4iDqw_+Pw@mail.gmail.com>
 <YqnOUlE1nEnCC44B@fedora>
 <CAHp75Vd91GMGUJurGKi2Ve_GM13uLpQFaeYG8Q48yFA6Aq2_ow@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="80ui2G9wDKtNFotX"
Content-Disposition: inline
In-Reply-To: <CAHp75Vd91GMGUJurGKi2Ve_GM13uLpQFaeYG8Q48yFA6Aq2_ow@mail.gmail.com>
Precedence: bulk


--80ui2G9wDKtNFotX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jun 15, 2022 at 02:43:27PM +0200, Andy Shevchenko wrote:
> On Wed, Jun 15, 2022 at 2:19 PM William Breathitt Gray
> > On Wed, Jun 15, 2022 at 02:00:26PM +0200, Andy Shevchenko wrote:

> > > I just realized that this driver is for the old PC104 (like?) hardware
> > > that most likely uses IO ports, I don't remember if we have support
> > > for IO ports in regmap (MMIO -- yes for sure).

> > Hmm, I don't see IO ports mentioned in include/linux/regmap.h, so I
> > don't think the regmap API directly supports it (maybe someone familiar
> > with regmap knows). Although we do get a virtual mapping cookie via
> > ioport_map() in this driver, I don't know if we can pass that to the
> > regmap functions and have it actually work.

> The problem is with accessors which are inconsistent in regmap MMIO
> implementation. I think it should be converted to use
> ioreadXX()/iowriteXX() in all cases (currently only BE cases use
> them). Another variant is to provide read*_be() / write*_be() for all
> architectures, replace corresponding ops in regmap MMIO and introduce
> regmap IO with inX()/outX. The former seems to me the best option,
> while the latter is cleaner.

I don't know what driver this is, but yes someone would have to add
ioport support to use them with regmap.

--80ui2G9wDKtNFotX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKrL7wACgkQJNaLcl1U
h9CDMgf8D77XkxBr9XTpl8qt4wypS4p9F2jlJkZr83OC6+eHrQL1zY/cs7b3txF8
KBF1fO+KIvNEwqTO2m7vCG5ubYIdAx/54UWswMnN4bfxHu8wyC7QHnj3CkYzECrV
N1APoKVJ2HehY6ZufGcddB4YIyZmafkMThtiotn65A7EmvQuqR0ejBkpVVYhkA0Z
CWnOnSthGI0J6khqb2OmcS2YpJZReMDCi9vhDJ8Bw7VHbZMLCl/sa9OEu5FGyOFD
3VUkKBQdUh0nDRP02qBoRlnrBmlGAS+uDuuo7zDMcmkAAW9JHxFtKPOjLbZ4y52R
kpM1RcjkyWFAAj2kw6MC0pi7NFx6ZQ==
=Osmx
-----END PGP SIGNATURE-----

--80ui2G9wDKtNFotX--