Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1475469iog; Thu, 16 Jun 2022 07:09:36 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uRy27j7kzOwBoYL7yss2L/sZL27RkEGOsYbrL3M8b5vV/DPWVPW9PHTZqIEwznVW8W5JbT X-Received: by 2002:a17:906:aad9:b0:711:d024:4b9b with SMTP id kt25-20020a170906aad900b00711d0244b9bmr4799203ejb.490.1655388576342; Thu, 16 Jun 2022 07:09:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655388576; cv=none; d=google.com; s=arc-20160816; b=0j4w42h8O7NK/jv9UTsUPP1NmGckc16oo+7BaOF6//TppXcctyXj6kyuo2GmZfUJVT x/O84XB/wpxQzZX3SiXXn+hRZtnhtrQ3A4PGzsJSnrMh5DPVNsuBT02uHa8/yp99ToNG k7wYXYr91ARPa/E+zN2l272d8OnswkcAm/MoT5Raxnc96zmgBlJcnnqSUCi4Tb65VRX3 SKjgVpdbUkIjHVtKPAak6o6v56B0yinO5lPeA5ilKOTjnByyiVlqoWe+BJsqj+65qOW+ oLpZl3CWrxU+ZBkJ30uqTk6Xyrj3hoOL9Rc/jDSSWQpeLmMOp9g8cWf9wiZErvS0+3ah z3wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=uQ4d+/hCDpXIIuZA6ifN1eXUKkJ4wcl+niFQzW1KPWg=; b=y1EqA4cGwRyOb24qjpVtBtetRI3BMIjmVlHJ6SBL2Gw/hipf1eJg3O1WSOOq8oarsq LO+31iamHJizUHlJvSkKrlJjNYEc8xGHi+On9litWm4Sqnsu0z2kye2e2hPMvZBk4o6X xXGN408RdH0i/QeKNPXjITGA6TniBF9NrjdsyTfqOWOqbxTJYsdRDQmaYaC1j360/wZC hkSzk8bHVOMbWtyGJDQqnay5TP+yZ++xer65eCScSBhtRFlg6ZLHh20v73y6vpvlEv7j S5oWa7T/cUb/wDUMws6nnA7eNSJ6Y2rEmtvkurrfEhjj4vhB4/iUlHjAH7I6MneGnO3p CrNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=1DqtUF+r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ho30-20020a1709070e9e00b00718bebeb259si2292244ejc.696.2022.06.16.07.09.09; Thu, 16 Jun 2022 07:09:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=1DqtUF+r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376708AbiFPNeg (ORCPT + 99 others); Thu, 16 Jun 2022 09:34:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232908AbiFPNef (ORCPT ); Thu, 16 Jun 2022 09:34:35 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1C221FCDB; Thu, 16 Jun 2022 06:34:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=uQ4d+/hCDpXIIuZA6ifN1eXUKkJ4wcl+niFQzW1KPWg=; b=1DqtUF+rjV/XZiC/scS+elV2ov JhbCgVmhK8D7fZlYN0fobs4BcsSYsHPad6IxRsc/+LoQfWpZs8o18AK8CZgdQBqRgmQN18NXa6lkD nRProzG3HaUzlPlGAZgT9pjJHJKO5UV3jBY8V/GEy23EUNNiKfxjDGNsCwR/gbQIs8Qc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1o1pda-007Bvi-6c; Thu, 16 Jun 2022 15:34:18 +0200 Date: Thu, 16 Jun 2022 15:34:18 +0200 From: Andrew Lunn To: Oleksij Rempel Cc: Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v1 1/1] net: dsa: ar9331: fix potential dead lock on mdio access Message-ID: References: <20220616112550.877118-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220616112550.877118-1-o.rempel@pengutronix.de> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > static int ar9331_mdio_read(void *ctx, const void *reg_buf, size_t reg_len, > @@ -849,6 +849,8 @@ static int ar9331_mdio_read(void *ctx, const void *reg_buf, size_t reg_len, > return 0; > } > > + mutex_lock_nested(&sbus->mdio_lock, MDIO_MUTEX_NESTED); > + Do you know about mdiobus_read_nested() and mdiobus_write_nested(). The mv88e6xxx driver uses these. Andrew