Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1490994iog; Thu, 16 Jun 2022 07:26:52 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t+jlu2RQA4Sbmt1snkVjyOXAa+5W3t1DK4RigUppg0t9dF5rHyyo1qnpWvaiJgqiD6hUuo X-Received: by 2002:a50:9f6a:0:b0:435:5804:e07 with SMTP id b97-20020a509f6a000000b0043558040e07mr1909989edf.178.1655389611933; Thu, 16 Jun 2022 07:26:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655389611; cv=none; d=google.com; s=arc-20160816; b=xzxSbEA28vQONOga0QNLx3FntvumMrJyPZoA/QQzYlFQdRAEjWLeTSdr1ZzuW2BaBK XHJK4s2MeCrXT15sylr2TFpvsBk7rCPxKpx432Rb7HNbzepguizVDgV12jqin0W8sKzh fmuBv7LpMSX4p8rCZU4vr9dx6cjX6b4n9bSr6Ny6nI5R3I05Wd4Igg7HLYZh98fI3aZ5 fuTao9WMpUmzaOEn+4PNyPhoLjRoQAuR+lfBbKqnDguhM+Fn+IklJLjhYpJdvtnBf2LP CzfLxcN+3ZnMjEaDvakTsN+/bskqsx8XZequjv0gKMCQswyVnwTtezLmy7j2Qa6iJP9f b1Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=lt4cZXCiaVcjGvhuT4ufqgA61fK3nl/LsSYLL/GBPXI=; b=jkuF+hvD/5T67bXoqQW2GNznbL0I/E8+jHmWVQnm20ja/mAsSFA3wxSU8jjQBAlXl3 4CN/UYUXpi5TddgTaYipcQUiwzjVHQrzgA7iHJUmRokRBF0G2CIr9kPm+xII7zd0MH60 mbBtSncOujRgF1yJJrZmB8AovvSV0+btgX+JT7nTKdjKzGbt35a267sDK+Bl2yWkLn7H tJjp+LxfcVZ6N59ib4Z9s+kzlJEnYorRi853lN3zaJlQuS4sntl9SmQlABKQLjSknpfl UV7QJm6llehuUDKdCVD61+nIdrPH/S2XWktZXul2tJOxIsFoFJ1lA178XlDTuT3lPxU7 Iu4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@126.com header.s=s110527 header.b=XDNa0blq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=126.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w14-20020a056402128e00b0042dbc55dfadsi2372303edv.199.2022.06.16.07.26.25; Thu, 16 Jun 2022 07:26:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@126.com header.s=s110527 header.b=XDNa0blq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=126.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233616AbiFPNao (ORCPT + 99 others); Thu, 16 Jun 2022 09:30:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233379AbiFPNal (ORCPT ); Thu, 16 Jun 2022 09:30:41 -0400 Received: from mail-m965.mail.126.com (mail-m965.mail.126.com [123.126.96.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 03D6D286D1 for ; Thu, 16 Jun 2022 06:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=lt4cZ XCiaVcjGvhuT4ufqgA61fK3nl/LsSYLL/GBPXI=; b=XDNa0blq5lRe7Gk3wyjyI Sefm5EB7e9LHXt3544UvMIyDR3cALbRtuhodZtrvlBk7DQQ/r+NRa3COXXrSr0zy WH3oYsio2xoCpPhOC9b9w2eU6exS3e78wtpCPETyk4wH7TNo7Q06opgzxRVaUNHP mgRwif0MnZ4KoyAMYw8O/g= Received: from localhost.localdomain (unknown [124.16.139.61]) by smtp10 (Coremail) with SMTP id NuRpCgCH51szMKtitIMkEw--.42762S2; Thu, 16 Jun 2022 21:29:25 +0800 (CST) From: Liang He To: oss@buserror.net, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, christophe.leroy@csgroup.eu Cc: windhl@126.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] arch: powerpc: platforms: 85xx: Fix refcount leak bug in ksi8560.c Date: Thu, 16 Jun 2022 21:29:22 +0800 Message-Id: <20220616132922.3987053-1-windhl@126.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: NuRpCgCH51szMKtitIMkEw--.42762S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrtF4UXry8JryrKryfGFWDXFb_yoW3CrgEkw n3Aa1UCrs5Cr4ktF4qyr1rKr1jq3yrWFWUGr1Ig3W7JFy5ZanxGwsrXF4xu3W5Xr4IkrWa qFZrG3s8CasakjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRMa9-UUUUUU== X-Originating-IP: [124.16.139.61] X-CM-SenderInfo: hzlqvxbo6rjloofrz/xtbBGg0iF1-HZT6SiQAAs6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In ksi8560_setup_arch(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Signed-off-by: Liang He --- arch/powerpc/platforms/85xx/ksi8560.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/platforms/85xx/ksi8560.c b/arch/powerpc/platforms/85xx/ksi8560.c index bdf9d42f8521..a22f02b0fc77 100644 --- a/arch/powerpc/platforms/85xx/ksi8560.c +++ b/arch/powerpc/platforms/85xx/ksi8560.c @@ -133,6 +133,8 @@ static void __init ksi8560_setup_arch(void) else printk(KERN_ERR "Can't find CPLD in device tree\n"); + of_node_put(cpld); + if (ppc_md.progress) ppc_md.progress("ksi8560_setup_arch()", 0); -- 2.25.1