Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1512933iog; Thu, 16 Jun 2022 07:56:03 -0700 (PDT) X-Google-Smtp-Source: AGRyM1usoXDC2wHHmaru+2MTSaJKmtY8vFiltLayQMs3oQHaPgiu4N1XhTJOtpz39gk8xPa+59Zw X-Received: by 2002:a17:902:8b87:b0:169:5e5:43de with SMTP id ay7-20020a1709028b8700b0016905e543demr3339556plb.8.1655391363248; Thu, 16 Jun 2022 07:56:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655391363; cv=none; d=google.com; s=arc-20160816; b=txLqJvwDcBhod7q2LZGHqZnHNHFeNZ0iMzkDhuyvyRspUwYuys+pqmnx/2Rd243xGW E0S4iZ9FF2SRtqdZgEDTjkTf+2GoOozplNv+6eMRhSsp798E6P7g9fw/Dvsq6Jtv5uwo JbnA8avj+hEkQd6KXYUaGnOVcelHTIsMqxMx9mft7mUEB2/TeRdxBB/TAT3AyCW84zXT udneK+jvPJPKZ4y1xYwOF6W2d5u0c4xNvMmp4dojVO24203iXA2KgWOxnJqjTqNBoPwD PiM4JcCigJrbAIMwdaTjfdwS21HFDUxsnsxVj1fvb3KGXA3FKwd7pBzfql7ZasjVxZ2s vUUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ARBcGNcD3T88nKaXT4MWM/zoSyK1nZmN5buYZLmG/Ok=; b=p4tHiraEaD1sSMaKPrVun70JP3ZxpBo5fiHb1Ut8x4BQX8vsoifw/VeqvlPbRKRzkt GKCvN0yMHA+foR3r9I57Nqe2pfpqAZPMEGBcCwv4kiXAgq0TdMynoqRX6FIK5CTmDTgI SGI0RdDc3zVeeFyXbvWuchOmNZH46WWyDVvArkzaGo2MFIuGRjfRJdzfBkTUrm8Z1WBZ A+qKHepOl23vtKJPz/vSYHfxVmtOvwXT6psnyc9j5uxTWJ8pw0hSK8lqSAyiYWXaCXB5 0mvlBBxre4Q/uhAECtt/jNuB6xCOVmIE6nTASChrmXI1gU8IPGYz6CgiKDoxVqg8vnfP 8+yA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@126.com header.s=s110527 header.b="ZsvkMzs/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=126.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s13-20020a63f04d000000b003fccd1c49easi2499935pgj.158.2022.06.16.07.55.49; Thu, 16 Jun 2022 07:56:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@126.com header.s=s110527 header.b="ZsvkMzs/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=126.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377286AbiFPOu0 (ORCPT + 99 others); Thu, 16 Jun 2022 10:50:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233481AbiFPOuX (ORCPT ); Thu, 16 Jun 2022 10:50:23 -0400 Received: from m15113.mail.126.com (m15113.mail.126.com [220.181.15.113]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AE6A543EF1 for ; Thu, 16 Jun 2022 07:50:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=ARBcG NcD3T88nKaXT4MWM/zoSyK1nZmN5buYZLmG/Ok=; b=ZsvkMzs/NznMFaHRatqKk O7Js+dZEmVL5eYjbA71d+mH7Q5qiWtRQDKX/1Cd1CCKuI1wHdSY146DAhF/okeTM uQoKKpZs43siheQnNcy0NUp9BdmddvVePiJEgy3SbaWiJ7EdSAswy1fII2+xxGr7 FClXStbkw3rgdJmwbfTHdI= Received: from localhost.localdomain (unknown [124.16.139.61]) by smtp3 (Coremail) with SMTP id DcmowACXp5_rQqtigmn6DQ--.14906S2; Thu, 16 Jun 2022 22:49:15 +0800 (CST) From: Liang He To: narmstrong@baylibre.com, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com Cc: windhl@126.com, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] soc: amlogic: Fix refcount leak in meson-secure-pwrc.c Date: Thu, 16 Jun 2022 22:49:15 +0800 Message-Id: <20220616144915.3988071-1-windhl@126.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: DcmowACXp5_rQqtigmn6DQ--.14906S2 X-Coremail-Antispam: 1Uf129KBjvdXoWruF18Jw17Jr1UCr1rGw43GFg_yoW3AwcEka ykJrnrXFy8ArWxtrWFkryS9rW09F1j93yv93W5tFy3Aw4UAr18XF9rurn3W3y7X3yvyF4U XFykJFZrtrZ2yjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjnYwUUUUUU== X-Originating-IP: [124.16.139.61] X-CM-SenderInfo: hzlqvxbo6rjloofrz/1tbi7QwiF1pEANi9CQAAsm X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In meson_secure_pwrc_probe(), there is a refcount leak in one fail path. Signed-off-by: Liang He --- drivers/soc/amlogic/meson-secure-pwrc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/soc/amlogic/meson-secure-pwrc.c b/drivers/soc/amlogic/meson-secure-pwrc.c index a10a417a87db..e93518763526 100644 --- a/drivers/soc/amlogic/meson-secure-pwrc.c +++ b/drivers/soc/amlogic/meson-secure-pwrc.c @@ -152,8 +152,10 @@ static int meson_secure_pwrc_probe(struct platform_device *pdev) } pwrc = devm_kzalloc(&pdev->dev, sizeof(*pwrc), GFP_KERNEL); - if (!pwrc) + if (!pwrc) { + of_node_put(sm_np); return -ENOMEM; + } pwrc->fw = meson_sm_get(sm_np); of_node_put(sm_np); -- 2.25.1