Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 16 Jun 2022 08:57:32 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     Andrew Lunn <andrew@lunn.ch>, Michal Kubecek <mkubecek@suse.cz>,
        Jonathan Corbet <corbet@lwn.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
        kernel@pengutronix.de, Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next v1 1/1] net: phy: add remote fault support
Message-ID: <20220616085732.7bc7ef30@kernel.org>
In-Reply-To: <20220616093451.GA28995@pengutronix.de>
References: <20220608093403.3999446-1-o.rempel@pengutronix.de>
        <YqS+zYHf6eHMWJlD@lunn.ch>
        <20220613125552.GA4536@pengutronix.de>
        <YqdQJepq3Klvr5n5@lunn.ch>
        <20220614185221.79983e9b@kernel.org>
        <YqlUCtJhR1Iw3o3F@lunn.ch>
        <20220614220948.5f0b4827@kernel.org>
        <Yqo8BuxL+XKw8U+a@lunn.ch>
        <20220616093451.GA28995@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 16 Jun 2022 11:34:51 +0200 Oleksij Rempel wrote:
> > It is also a bit unclear, but at the moment, i think user
> > space. However, i can see the kernel making use of maybe RF TEST to
> > ask the link peer to go quiet in order to perform a cable test.
> > 
> > Oleksij, what are your use cases?  
> 
> Currently I was thinking only about diagnostic:
> - request transmit pause for cable testing
> - request remote loopback for selftest. In this case I will need to use
>   vendor specific NextPage to request something like this.

Both of those are performed by the kernel, so perhaps we should focus
the interface on opting into the remote fault support but have the
kernel trigger setting and clearing the bits?