Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 16 Jun 2022 10:35:22 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Baoquan He <bhe@redhat.com>
Cc:     Baolin Wang <baolin.wang@linux.alibaba.com>,
        songmuchun@bytedance.com, akpm@linux-foundation.org,
        catalin.marinas@arm.com, will@kernel.org,
        anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] arm64/hugetlb: Implement arm64 specific
 hugetlb_mask_last_hp
Message-ID: <Yqtp2hA+5pRiFskC@monkey>
References: <7256dbe078d7231f45b0f47c2c52a3bd3aa10da7.1655350193.git.baolin.wang@linux.alibaba.com>
 <Yqscbw0l9dL9Eldd@MiWiFi-R3L-srv>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yqscbw0l9dL9Eldd@MiWiFi-R3L-srv>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mCffQUG+Jb/WoPNRyIGmK4qZeXxDBg0wRGU220m2jp6hOiKGfoWz7mZtU8hY?=
 =?us-ascii?Q?dPU60J7RlnCvNY2d+8EJva2oS/RtLUMDVICnhR+VKeHoU8xgUGCwWMmUDjlG?=
 =?us-ascii?Q?35qxd+6UFHmUxylnqQXRQUQ5E/JxRQkfWSLQibKcgfd+3egIjNlw+Zh6Hooa?=
 =?us-ascii?Q?rO0sAoxrFVSts+XzPQs8feAGKQeMheJZMD68VMTLA1QbWpYw1zFJqLx5Dch7?=
 =?us-ascii?Q?nRU5Hgpl3415F1tNWPpaj+hK99DQyNzPA8Zezn2iLmxUFsiHPi/mr0mz4Sfy?=
 =?us-ascii?Q?BgNXuEzpMacUtYHZW2T1SzJ3zmJ6GKs4g52c4CdIckqVH6SR9xoCG4eInwe/?=
 =?us-ascii?Q?EeYoAvGjAJzMuf1kWOxzF1FYcvFES1sAeUJHjentwIdIx0m/gvJJZm92CHyc?=
 =?us-ascii?Q?is1smC8k5ZpRmlHuhmExP2r0ZrT/h99npEzGGHv8xNLVcwJhctLq6idjmRKj?=
 =?us-ascii?Q?DLMj0dXDAm0GGlxd/XgLJdVvN67gr8/pj1Ziszcdn2rrjnLD48eykHq5iNAk?=
 =?us-ascii?Q?RTKNLj9uzWM5ZHX9HE1MXxsvw/SxAyjYc9V40wgRi4uysCtuOb7zYBSus8lV?=
 =?us-ascii?Q?BZooSqHFZW/o4jHNUhrtT/xKuZ0gFWuAo7FwjCUI5D+iFioU2WfuPlAFSDF2?=
 =?us-ascii?Q?vkEghNHaUWGO8Qx4yZABjHam370mfgnG9fZ0UPkbdP2flohGL2SyskYnac7J?=
 =?us-ascii?Q?pMOj6Cw9MVwAmUqrqQDMG6jToJq1TVYZw+5QW7V0BPKSvJL4HGRn4bODKiSq?=
 =?us-ascii?Q?niv3qrZq2twH63ptBN6qCBASErkuT2kwMDaOjSSyMNLT/vqomFwkBAS3c7pJ?=
 =?us-ascii?Q?iSw40Ub5uaF4zcJlrtQ/epxuZqw6EjHcWLzKhOREdFL8CH961yWTNPQY5nIr?=
 =?us-ascii?Q?kHSDo3Y/xUvSyTY3IZS0CWtaq1oDoeouIdVNvfVxuhd0+M8LOz0s+X25lVok?=
 =?us-ascii?Q?J5uiXf9FWI4PnC9Jya4ECQpU0ZsAp8zBIuN6m8bkFj9X3F0aGzkzdLw/jCSz?=
 =?us-ascii?Q?tyrd8jswgpk4WF4KY6fjMnSQPR9owt63dj0KppG2XKckpsv6qh2Xs/ufQ39K?=
 =?us-ascii?Q?iTDkyxHS0nJhSVbeSP3DWJbzbstFxZFsgzpAAX7mdBQTug7RFC3XFzwAzpDb?=
 =?us-ascii?Q?rOlUVnmVsPivf4fXak3TivlSjdRitzkhMOmOImrb2EiMP8OzxLb6xALgSpNo?=
 =?us-ascii?Q?B0wwbam+giKiyo7CiqPfJ6saat7HvfxvWwbSprs1CDR2orFJBES4KLePEzVn?=
 =?us-ascii?Q?a9Er9hHS0naqZIYPrFdrA8q9lmuuGseVLxIJaCVKnpZbv1Vg/I/ziehesDlt?=
 =?us-ascii?Q?1EubDhsYO9EBzNVgaHL3/UQBHWjLLncW1tYL7wrN0bbt9P8HgLwTNPxLiB/Z?=
 =?us-ascii?Q?N8uo1mNlu3Zb0mbsfYriO/dKsrhTOd2Oy6si2WSkHmDVyvMQKa1mf0HmFLM4?=
 =?us-ascii?Q?a1gN2wPpm9qNZjAOQ76UOq/2MxeLJtXJHas3KxXCXANqkI7moIrPKc6mZtar?=
 =?us-ascii?Q?z1jaJvOyr5kJfjcOloo/IpThJ8ruHGI/xa8ehPiTRfbK3jItKYWkh8juRsOO?=
 =?us-ascii?Q?nB6yF6uZGyUsjQfcT0ivMBCcnkZrPtmgl9RgrPq4+TuBrzirVm18FNgMbHPI?=
 =?us-ascii?Q?TxeBzT/1edzX+bdA3u8fjQWpXEz+MRikHyXBV4paXtg0iwC1CSuhgA+O26XK?=
 =?us-ascii?Q?G6eqdJW2zC6C90UglHHSQMe4NyjKYDbg1IpL/p8ZlTUMTWqDPrkK9wZLpZ7b?=
 =?us-ascii?Q?JN4h59/QUpyIXqqope887V3h0PUGKHQ=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e7e138e-8d69-4d1a-40ea-08da4fbe98be
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2022 17:35:25.8976
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uH56k9J37nIRLGGyOlva8PEz/jKufM4xWsUuoRcQdig8FWUhEYNfT0hbW5q324i2lqpjw5LXqQYF6jrGxcsrDw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5260
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-16_13:2022-06-16,2022-06-16 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 adultscore=0
 mlxlogscore=999 phishscore=0 mlxscore=0 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206160072
X-Proofpoint-ORIG-GUID: o_k82QBJhUwUWBclHMLThWF7B66HWJ3q
X-Proofpoint-GUID: o_k82QBJhUwUWBclHMLThWF7B66HWJ3q
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/16/22 20:05, Baoquan He wrote:
> On 06/16/22 at 11:34am, Baolin Wang wrote:
> > The HugeTLB address ranges are linearly scanned during fork, unmap and
> > remap operations, and the linear scan can skip to the end of range mapped
> > by the page table page if hitting a non-present entry, which can help
> > to speed linear scanning of the HugeTLB address ranges.
> > 
> > So hugetlb_mask_last_hp() is introduced to help to update the address in
> > the loop of HugeTLB linear scanning with getting the last huge page mapped
> > by the associated page table page[1], when a non-present entry is encountered.
> > 
> > Considering ARM64 specific cont-pte/pmd size HugeTLB, this patch implemented
> > an ARM64 specific hugetlb_mask_last_hp() to help this case.
> > 
> > [1] https://lore.kernel.org/linux-mm/20220527225849.284839-1-mike.kravetz@oracle.com/
> > 
> > Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> > ---
> > Note: this patch is based on the series: "hugetlb: speed up linear
> > address scanning" from Mike. Mike, please fold it into your series.
> > Thanks.
> > ---
> >  arch/arm64/mm/hugetlbpage.c | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> > 
> > diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c
> > index e2a5ec9..958935c 100644
> > --- a/arch/arm64/mm/hugetlbpage.c
> > +++ b/arch/arm64/mm/hugetlbpage.c
> > @@ -368,6 +368,26 @@ pte_t *huge_pte_offset(struct mm_struct *mm,
> >  	return NULL;
> >  }
> >  
> > +unsigned long hugetlb_mask_last_hp(struct hstate *h)
> > +{
> > +	unsigned long hp_size = huge_page_size(h);
> 
> hp_size may not be a good name, it reminds me of hotplug. I would name
> it hpage_size even though a little more characters are added.
> 

How about just hugetlb_mask_last_page?  Since the routine is prefixed
with 'hugetlb' and we are passing in a pointer to a hstate, I think there
is enough context to know we are talking about a huge page mask as
opposed to a base page mask.

If OK, I will change the name in my patches and here.
-- 
Mike Kravetz