Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1699491iog; Thu, 16 Jun 2022 11:49:42 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uN7unGGJ7uQn9pR3+vHDDC9t/SB0kh9RyZV5R61jHzJAsq7+IBFImZBgf0WifJc+G2pf/H X-Received: by 2002:aa7:c9d2:0:b0:42e:1776:63e0 with SMTP id i18-20020aa7c9d2000000b0042e177663e0mr7981640edt.185.1655405382575; Thu, 16 Jun 2022 11:49:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655405382; cv=none; d=google.com; s=arc-20160816; b=K60VFIL8KkVfLIGP6wjAmb9UryLWRGqBBubGxydWYwt5wjUFg7D9BgqGEHKX8LQ5PP y7csZG2hnJauekUiUz05K1sqO9jDCQ7al9eVpi6vI3Z4QgcvQAcXTrwsGfjKTFPq3T6L udHVlXdcmY65FdqG1EZsPbuYGMPR7maEs1tJ43e4173bfO7ntEacQUgazf5K6RmW4Z73 DsSoGUgpHQerBNFCfkly89j2J9ISTe//GhBTNE3oMbwnHrvsefbTD4hj/t7XAy7AOczw 7SysxteZkKJHNlObMhTgYXDohUea1tGcK1vqxpIwKTs5bAweFcGW70QNeoZWEiUA2wUj mmJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:user-agent:from :references:in-reply-to:mime-version:dkim-signature; bh=Gyeh6+oF0wR2A8D9gteJMzDupQH8pClsR5n0gdKcTuw=; b=gqbFgTc+IOaYBKzpb+SVJljsCGW5n42NQs8aF0P0ZtYGX/3lDfIr65ii2AzutIytnU tpcmD7N9mB2CNfZwe4o72E9fw33g0ZoB3wkGiAJcHw4qabbaviSe428iXSzHZbZ9vEt7 USlbNkBSaXuwByW+UjJbQNJ7IfnBP+IyWsY9YPOiD9QsQLmrQb1KNa+IOC29Mm9bXhlZ o/Aihymux/o1GAe0A02A1Cw1U5LC4VUgngxtCj0bSgTvHZ75wEyufQgJU2PG41WNTM6a 7TgJuRSru8MNZFoWkzT8M5bKCzQw3ZuhUUqrR+MlKUHMxwmfWsCKpEuggJhnUJSfdKqW sbnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=bmqTBNe7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hr10-20020a1709073f8a00b0071210178d15si2648887ejc.852.2022.06.16.11.49.13; Thu, 16 Jun 2022 11:49:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=bmqTBNe7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377755AbiFPSho (ORCPT + 99 others); Thu, 16 Jun 2022 14:37:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377788AbiFPShm (ORCPT ); Thu, 16 Jun 2022 14:37:42 -0400 Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C83E1182B for ; Thu, 16 Jun 2022 11:37:40 -0700 (PDT) Received: by mail-ot1-x32e.google.com with SMTP id s20-20020a056830439400b0060c3e43b548so1570134otv.7 for ; Thu, 16 Jun 2022 11:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=Gyeh6+oF0wR2A8D9gteJMzDupQH8pClsR5n0gdKcTuw=; b=bmqTBNe7SOkMiKyUy7Hq86s5vhvrso+wDRUZ36RwT8cAxve2005wFK/t2/StVNKk9k FOwSnKAdvN8QRtxNFGYs9MbocxLvXNCQee5uUVbkq6mz7FR9LZXkGr/+w7BzdzM6dKQC uDO8dctrJ2DHRvQeNJahClCpIP2fuaQD8+amA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=Gyeh6+oF0wR2A8D9gteJMzDupQH8pClsR5n0gdKcTuw=; b=HR9/seIDRmOFijiDQcCckSeU6Jrdne+ZttBdUnCPOE3eXBs3FcdaWqFME4c4Jj+gaY fsGfPcX/v9rcCAQTc1DQbpJXGCx1BQWMB2+5IxXtqvkl0Fpc6VFWAwaG1znvxz8kPRBr HjcZkAUecdWkEFz0VsfVM9AD4hAT8leu/uYOMu0WhMHbPENHX2NKAwPGvMee6FKhmlgn pJDgFGaRTsQqifuK6rrtbQic17qd1QzC4ZKj3BdpFuj7woSTGKAG5/uN/6Guo25u3fNF xv4Tkqy4BSONrUKY//jM3HLlQQmrNikyBXMBn8dlHNPF2Cx13qrNNu6E8CesuwRZZoBg BbYw== X-Gm-Message-State: AJIora8M1H7YD//7xuMDGSyUR5QiGqH9mWSFRGA9EzswpzWGSih3ZddH HwjJ1DSD7mDTVjjZ+Kq7+Qa/IbhpIcY7IaMeoHq/mQ== X-Received: by 2002:a9d:6484:0:b0:60b:eb0b:4054 with SMTP id g4-20020a9d6484000000b0060beb0b4054mr2536734otl.159.1655404659632; Thu, 16 Jun 2022 11:37:39 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 16 Jun 2022 11:37:39 -0700 MIME-Version: 1.0 In-Reply-To: <1655377322-14195-1-git-send-email-quic_dikshita@quicinc.com> References: <1655377322-14195-1-git-send-email-quic_dikshita@quicinc.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Thu, 16 Jun 2022 11:37:39 -0700 Message-ID: Subject: Re: [PATCH v3] venus: Add support for SSR trigger using fault injection To: Dikshita Agarwal , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, stanimir.varbanov@linaro.org, quic_vgarodia@quicinc.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Dikshita Agarwal (2022-06-16 04:02:02) > Here we introduce a new fault injection for SSR trigger. > > To trigger the SSR: > echo 100 > /sys/kernel/debug/venus/fail_ssr/probability > echo 1 > /sys/kernel/debug/venus/fail_ssr/times > > Co-developed-by: Stanimir Varbanov > signed-off-by: Dikshita Agarwal This line should come last and the 's' should be capitalized. > Signed-off-by: Stanimir Varbanov > --- Code looks good Reviewed-by: Stephen Boyd