Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] drivers/char/agp: Remove unnecessary variable assignment
 in agp_generic_create_gatt_table()
To:     Gautam Menghani <gautammenghani201@gmail.com>, airlied@linux.ie
Cc:     linux-kernel@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20220616181939.225041-1-gautammenghani201@gmail.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <81aaa86d-f963-0265-6a4e-6a6110758b99@linuxfoundation.org>
Date:   Thu, 16 Jun 2022 13:51:24 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20220616181939.225041-1-gautammenghani201@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/16/22 12:19 PM, Gautam Menghani wrote:
> Remove unnecessary variable assignment in the function
> agp_generic_create_gatt_table(). This fixes the clang scan warnings:
> 
> warning: Value stored to 'page_order' is never read [deadcode.DeadStores]
>          page_order = num_entries = 0;
> 
> warning: Although the value stored to 'num_entries' is used in the
> enclosing expression, the value is never actually read from 'num_entries'
> [deadcode.DeadStores]
> 
> Signed-off-by: Gautam Menghani <gautammenghani201@gmail.com>
> ---
>   drivers/char/agp/generic.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/char/agp/generic.c b/drivers/char/agp/generic.c
> index 3ffbb1c80c5c..046ef61132f6 100644
> --- a/drivers/char/agp/generic.c
> +++ b/drivers/char/agp/generic.c
> @@ -864,7 +864,6 @@ int agp_generic_create_gatt_table(struct agp_bridge_data *bridge)
>   	table = NULL;
>   	i = bridge->aperture_size_idx;
>   	temp = bridge->current_size;
> -	page_order = num_entries = 0;

It would be safe to initialize page_order and num_entries when
they are declared a few lines above.

>   
>   	if (bridge->driver->size_type != FIXED_APER_SIZE) {
>   		do {
> 

thanks,
-- Shuah