Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 17 Jun 2022 02:01:49 +0530
From:   Manivannan Sadhasivam <mani@kernel.org>
To:     Stanislav Jakubek <stano.jakubek@gmail.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-unisoc@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: interrupt-controller: Convert
 rda,8810pl-intc to YAML
Message-ID: <20220616203149.GF2889@thinkpad>
References: <20220611180703.GA24988@standask-GA-A55M-S2HP>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220611180703.GA24988@standask-GA-A55M-S2HP>
Precedence: bulk

On Sat, Jun 11, 2022 at 08:07:03PM +0200, Stanislav Jakubek wrote:
> Convert RDA Micro interrupt controller bindings to DT schema format.
> 
> Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>

Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

Thanks,
Mani

> ---
> 
> Changes in v2:
>   - drop the interrupt sources header file
> 
>  .../interrupt-controller/rda,8810pl-intc.txt  | 61 -------------------
>  .../interrupt-controller/rda,8810pl-intc.yaml | 43 +++++++++++++
>  MAINTAINERS                                   |  2 +-
>  3 files changed, 44 insertions(+), 62 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.txt
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.txt
> deleted file mode 100644
> index e0062aebf025..000000000000
> --- a/Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.txt
> +++ /dev/null
> @@ -1,61 +0,0 @@
> -RDA Micro RDA8810PL Interrupt Controller
> -
> -The interrupt controller in RDA8810PL SoC is a custom interrupt controller
> -which supports up to 32 interrupts.
> -
> -Required properties:
> -
> -- compatible: Should be "rda,8810pl-intc".
> -- reg: Specifies base physical address of the registers set.
> -- interrupt-controller: Identifies the node as an interrupt controller.
> -- #interrupt-cells: Specifies the number of cells needed to encode an
> -  interrupt source. The value shall be 2.
> -
> -The interrupt sources are as follows:
> -
> -ID	Name
> -------------
> -0:	PULSE_DUMMY
> -1:	I2C
> -2:	NAND_NFSC
> -3:	SDMMC1
> -4:	SDMMC2
> -5:	SDMMC3
> -6:	SPI1
> -7:	SPI2
> -8:	SPI3
> -9:	UART1
> -10:	UART2
> -11:	UART3
> -12:	GPIO1
> -13:	GPIO2
> -14:	GPIO3
> -15:	KEYPAD
> -16:	TIMER
> -17:	TIMEROS
> -18:	COMREG0
> -19:	COMREG1
> -20:	USB
> -21:	DMC
> -22:	DMA
> -23:	CAMERA
> -24:	GOUDA
> -25:	GPU
> -26:	VPU_JPG
> -27:	VPU_HOST
> -28:	VOC
> -29:	AUIFC0
> -30:	AUIFC1
> -31:	L2CC
> -
> -Example:
> -		apb@20800000 {
> -			compatible = "simple-bus";
> -			...
> -			intc: interrupt-controller@0 {
> -				compatible = "rda,8810pl-intc";
> -				reg = <0x0 0x1000>;
> -				interrupt-controller;
> -				#interrupt-cells = <2>;
> -			};
> -		};
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.yaml
> new file mode 100644
> index 000000000000..96d6285d0087
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/rda,8810pl-intc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: RDA Micro RDA8810PL interrupt controller
> +
> +maintainers:
> +  - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> +
> +allOf:
> +  - $ref: /schemas/interrupt-controller.yaml#
> +
> +properties:
> +  compatible:
> +    const: rda,8810pl-intc
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupt-controller: true
> +
> +  '#interrupt-cells':
> +    const: 2
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupt-controller
> +  - '#interrupt-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    intc: interrupt-controller@0 {
> +      compatible = "rda,8810pl-intc";
> +      reg = <0x0 0x1000>;
> +      interrupt-controller;
> +      #interrupt-cells = <2>;
> +    };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f0a90b256b26..58a35519b7c4 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2590,7 +2590,7 @@ L:	linux-unisoc@lists.infradead.org (moderated for non-subscribers)
>  S:	Maintained
>  F:	Documentation/devicetree/bindings/arm/rda.yaml
>  F:	Documentation/devicetree/bindings/gpio/gpio-rda.yaml
> -F:	Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.txt
> +F:	Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.yaml
>  F:	Documentation/devicetree/bindings/serial/rda,8810pl-uart.yaml
>  F:	Documentation/devicetree/bindings/timer/rda,8810pl-timer.yaml
>  F:	arch/arm/boot/dts/rda8810pl-*
> -- 
> 2.25.1
> 

-- 
மணிவண்ணன் சதாசிவம்