Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1833370iog; Thu, 16 Jun 2022 15:06:14 -0700 (PDT) X-Google-Smtp-Source: AGRyM1srTExe0SwLvd3T6urYCqOlAFvdffDsjwYh9y0k3ep4hzbfr/AAOhBlHfrecQ9sm7iju1VN X-Received: by 2002:a62:c5c3:0:b0:51b:a11c:201f with SMTP id j186-20020a62c5c3000000b0051ba11c201fmr6890332pfg.71.1655417174517; Thu, 16 Jun 2022 15:06:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655417174; cv=none; d=google.com; s=arc-20160816; b=zL+xcljSKmSC985to9+JU0DShPPdtLNEyrUB8RZWfuRZPB9nJYpd4k59SQGhYs2hp9 uXMn/Ft3KYxxwocNDKODw552H8vk8lRLMtjTWNJq4oi5h+Rfj7Ue7++vPPRmYf7BuDkI P/YeQxX3eetUqEAYaeilNuO2QMAogzFc6rd3RmhzuZVMnRgUyDQVwCe2WxRdaXXhluqW uBASF9QPXLTmYJcMAfuUjgVHSU0nUgby/L5XEkbxXzAx4i5h73JLTHqZj2JVPnlWPok3 PitGfS9WwGIfah0BXJrMKqP6ysxS+kDLtturDRHxk5g+OVmljng1O7ApqZGL90prmI3n dwew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=q9EVE0isp97lB977iSlG1JyLdNuMx4D6p9ci5YRzrzQ=; b=vE/3/a5YeoJ11b3zJpWatUXYc3SHU2ZLDMGCKttGvbtUjxknrA9e6/FxmCzSbhl2c0 3gGlHdcsTE0czFBLYpQTul0S1M9j3vI4DCV0wFhfoY6XS/QsA5xlFmxI4AxvQSNFMx1H NGgmQx5URAOtWRsTeRjfnWi14F96nX2EcJb1lawFAIaAk3Y//7450fGkCqXc5ByT9Wmt kLZ4keXnigdElDYHSuW0blg/ZGLNN8lhg69MZ9xaSLw1VeIi7ExHc04VaXwEC0Mq3O57 d4mo1+S++CSYnu+FALt3YVw5/6pvA+vfMfMH0TlPXzFYP/LouOW0U+rp09dMixf8Yjs+ Wy4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=nhkajPtd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c9-20020a170903234900b0016382c70069si3513825plh.150.2022.06.16.15.05.56; Thu, 16 Jun 2022 15:06:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=nhkajPtd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378775AbiFPWE4 (ORCPT + 99 others); Thu, 16 Jun 2022 18:04:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378486AbiFPWEq (ORCPT ); Thu, 16 Jun 2022 18:04:46 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 043B161295 for ; Thu, 16 Jun 2022 15:04:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655417084; x=1686953084; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HodmLaeije9RtxZHyILx5m7Ze8bov7hZMNKhqP0nbhw=; b=nhkajPtdxSZlAFTOe2v0R3o/eLXxnV4jTcpdHfryOPUWFChUptD5F5Qn dcJO+z0BReBKizqV7DE1dZveC3+4s3iJRdGfy1IKPivZ0/2mvyV4d9N1W OdQ/7TDC0s30PTAawluGVQ4NYPgup1YlIjL7gelo+VNQTjHaH3MG6c3ZY 61FyDnEG6GFK7+Tx4D4fFMa9Q91gBDcF+kEROzQ16FBoInyNtsl3eWgf/ 5NU/zVGnZlgWwcNSHeclLoUOah5AHzCbZ8Hw16q8RJF2M/Mzj75pSnE2c UYVoVyKx7y7YweqGLoymHIoDhQR04FqVPUMgCJjxV/vzDDbBvcAgmYLUn w==; X-IronPort-AV: E=McAfee;i="6400,9594,10380"; a="276936416" X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="276936416" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2022 15:04:44 -0700 X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="728084999" Received: from buckkenx-mobl.amr.corp.intel.com (HELO pbossart-mobl3.intel.com) ([10.212.52.70]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2022 15:04:43 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Cc: tiwai@suse.de, broonie@kernel.org, Cezary Rojewski , =?UTF-8?q?Amadeusz=20S=C5=82awi=C5=84ski?= , Pierre-Louis Bossart , Bard Liao , Kai Vehmanen , Ranjani Sridharan , Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 05/11] ASoC: wsa881x: use pm_runtime_resume_and_get() Date: Thu, 16 Jun 2022 17:04:21 -0500 Message-Id: <20220616220427.136036-6-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220616220427.136036-1-pierre-louis.bossart@linux.intel.com> References: <20220616220427.136036-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org simplify the flow. No functionality change, except that on -EACCESS the reference count will be decreased. Signed-off-by: Pierre-Louis Bossart Reviewed-by: Bard Liao Reviewed-by: Kai Vehmanen Reviewed-by: Ranjani Sridharan --- sound/soc/codecs/wsa881x.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/wsa881x.c b/sound/soc/codecs/wsa881x.c index f3a56f3ce4871..dc954b85a9881 100644 --- a/sound/soc/codecs/wsa881x.c +++ b/sound/soc/codecs/wsa881x.c @@ -749,11 +749,9 @@ static int wsa881x_put_pa_gain(struct snd_kcontrol *kc, unsigned int mask = (1 << fls(max)) - 1; int val, ret, min_gain, max_gain; - ret = pm_runtime_get_sync(comp->dev); - if (ret < 0 && ret != -EACCES) { - pm_runtime_put_noidle(comp->dev); + ret = pm_runtime_resume_and_get(comp->dev); + if (ret < 0 && ret != -EACCES) return ret; - } max_gain = (max - ucontrol->value.integer.value[0]) & mask; /* -- 2.34.1