Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1833372iog; Thu, 16 Jun 2022 15:06:14 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t+n/AU+r2Z+P7KSG5T8aqrWnHmWf5im9aBS2Q6oDhAWfLkmRU8gs626Dd+33JlC0YstCx0 X-Received: by 2002:a17:90b:1210:b0:1ea:ee10:c823 with SMTP id gl16-20020a17090b121000b001eaee10c823mr5570467pjb.109.1655417174636; Thu, 16 Jun 2022 15:06:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655417174; cv=none; d=google.com; s=arc-20160816; b=mdB/bYHpG1Gud6wprwyq+75rBL4jqgbRyNUwrD5F7OXb9ZL+xJj6mbUyfeQYX+jfi+ zV8q+FOVxnH5Y7zIUFZa4nOoCYAxWE/CExU7/aauW9moUtutpqK1SDT0uM4VjRec6Vpd hrUqtiXeAgCIO8/Vn9rpWfBkn3eNAl8XO3p5fpbtfY3IKruS+tPH83kfxUsRJAb/a6le igUOyFNFXqtGKeIVWqOAT93ED+aVaujofp72mkwfVLLUpLa+djX4sGCAWV2eGG7pw+7N gLMAnAINrQgGlUgutPlB70BlYEDC0nSysahBpE/PJbCvCXjWKbHVu4dCF0XAXQ9roHrn m7bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=YWxdZXsixZpF7sp8hV+XPJojuSoajA9v0YFk5wBxqMc=; b=KdFkhccCCTbkIs9cdo5wN1yfxk0fpm/qgYeOwF3vQEyeX8wpEaokkBvc5B1VlGgS0+ FxaVLg9KlsQHUd1mYyB6Ou4p7y7/aNs1xMjOhPs0+5oDxJklA87Trc9LnyqpDS48+7Nh ULPyeo1c8KoGQ+32RwrUl0kd+TpThDlgXjGoXSfZsnskFo5+6H+c2tGnsb3dWdcWePRj ccyru7hQonIkiWqGSRv4hFIPpdxqezijRFgFpZSXHjVE8epKv8s8t9Kb89jGdaMSK4lH 1ONag/1qcmdX2V0kJCmr2iuv11cSyqFJedTe7rejblEHgdEdYFfu+0y3HevX6mGWOrOD HDaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=MA+FjrAY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q17-20020a170902f79100b0015827ec0073si3832035pln.452.2022.06.16.15.05.54; Thu, 16 Jun 2022 15:06:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=MA+FjrAY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378315AbiFPWEn (ORCPT + 99 others); Thu, 16 Jun 2022 18:04:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232055AbiFPWEl (ORCPT ); Thu, 16 Jun 2022 18:04:41 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC1E75F257 for ; Thu, 16 Jun 2022 15:04:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655417080; x=1686953080; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8yDu8pljCT7lbter28rnZGmrSNHwi6FSg6lKKzg7Hfs=; b=MA+FjrAYMxkDv176CrJhQ+anztTLRxnBFMtKnr07rEO4qH1V94uED69E AGmP0YkfArH9ntKbURyhWiahxwykopgKK9U726XIULqnKXAuR3+pV89cf ehxkCE4l6Vix+Joj8HxKiONp2LfjqkSTwvvuZNEJpLkVI8K2l2J/zMEPv CezMeuVKa69fcnZK2x7mgzo7aq4kbiSkpOZ3tBGjUAy8eDQ5/TU5Aonza ggxcxWgOiglJlcTrnRh+Q8b/7z+NevtSr9FLzj56It9NihVzmAMF/GV9F /ogeJQfBSvDtQsToMBvwAnJceanXdKLkwpfpUicZEUXLdKJMLT3CnjTew Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10380"; a="276936398" X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="276936398" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2022 15:04:40 -0700 X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="728084970" Received: from buckkenx-mobl.amr.corp.intel.com (HELO pbossart-mobl3.intel.com) ([10.212.52.70]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2022 15:04:39 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Cc: tiwai@suse.de, broonie@kernel.org, Cezary Rojewski , =?UTF-8?q?Amadeusz=20S=C5=82awi=C5=84ski?= , Pierre-Louis Bossart , Bard Liao , Kai Vehmanen , Ranjani Sridharan , Liam Girdwood , Peter Ujfalusi , Jaroslav Kysela , Takashi Iwai , Gustaw Lewandowski , Thomas Gleixner , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 02/11] ASoC: Intel: skylake: skl-pcm: use pm_runtime_resume_and_get() Date: Thu, 16 Jun 2022 17:04:18 -0500 Message-Id: <20220616220427.136036-3-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220616220427.136036-1-pierre-louis.bossart@linux.intel.com> References: <20220616220427.136036-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The current code does not check for errors and does not release the reference on errors. Signed-off-by: Pierre-Louis Bossart Reviewed-by: Bard Liao Reviewed-by: Kai Vehmanen Reviewed-by: Ranjani Sridharan --- sound/soc/intel/skylake/skl-pcm.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c index 55f310e91b55c..9d72ebd812af9 100644 --- a/sound/soc/intel/skylake/skl-pcm.c +++ b/sound/soc/intel/skylake/skl-pcm.c @@ -1380,7 +1380,10 @@ static int skl_platform_soc_probe(struct snd_soc_component *component) const struct skl_dsp_ops *ops; int ret; - pm_runtime_get_sync(component->dev); + ret = pm_runtime_resume_and_get(component->dev); + if (ret < 0 && ret != -EACCES) + return ret; + if (bus->ppcap) { skl->component = component; -- 2.34.1