Message-ID: <46549825.6040500@gmail.com>
Date: Wed, 23 May 2007 21:38:13 +0200
From: Rene Herman <rene.herman@gmail.com>
User-Agent: Thunderbird 1.5.0.10 (X11/20070221)
MIME-Version: 1.0
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
CC: Thomas Gleixner <tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org>,
       Ingo Molnar <mingo@elte.hu>, Jeff Garzik <jeff@garzik.org>,
       Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH] CDROM: replace jiffies busyloop with msleep
References: <1179829525.12708.118.camel@chaos>	<46548ADB.60207@gmail.com> <20070523203436.01a005b0@the-village.bc.nu>
In-Reply-To: <20070523203436.01a005b0@the-village.bc.nu>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 811
Lines: 20

On 05/23/2007 09:34 PM, Alan Cox wrote:

>> driver was snappy in that regard. When I replaced our sleeping loop with a 
>> busy-wait same as the original the snappyness returned and moreover, reading 
>> the TOC from the CD went from something close to a minute to approximately a 
>> second. Thought that minute was just because I was dealing with an old junk 
>> 1-speed drive...
> 
> It happens. If you want to be fairer you can check need_resched in the
> loop so that you still share the CPU fairly with other users.

Thanks for the tip -- I'll do this.

Rene.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/