Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <aa1334b2-49db-2425-6895-c186566374e8@linaro.org>
Date:   Fri, 17 Jun 2022 01:24:14 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v3] venus: Add support for SSR trigger using fault
 injection
Content-Language: en-US
To:     Stephen Boyd <swboyd@chromium.org>,
        Dikshita Agarwal <quic_dikshita@quicinc.com>,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Cc:     linux-arm-msm@vger.kernel.org, quic_vgarodia@quicinc.com
References: <1655377322-14195-1-git-send-email-quic_dikshita@quicinc.com>
 <CAE-0n51HOy84c9osif0wXd90c5D_MQZ=9sa1g93iZHG3mWxREA@mail.gmail.com>
From:   Stanimir Varbanov <stanimir.varbanov@linaro.org>
In-Reply-To: <CAE-0n51HOy84c9osif0wXd90c5D_MQZ=9sa1g93iZHG3mWxREA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Thanks Dikshita.

On 6/16/22 21:37, Stephen Boyd wrote:
> Quoting Dikshita Agarwal (2022-06-16 04:02:02)
>> Here we introduce a new fault injection for SSR trigger.
>>
>> To trigger the SSR:
>>  echo 100 >  /sys/kernel/debug/venus/fail_ssr/probability
>>  echo 1 >  /sys/kernel/debug/venus/fail_ssr/times
>>
>> Co-developed-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
>> signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
> 
> This line should come last and the 's' should be capitalized.

Thanks Stephen, will fix that while applying.

> 
>> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
>> ---
> 
> Code looks good
> 
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>

-- 
regards,
Stan