Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: zuwTNTlh2aeeu6twZM7p9g18OkVThd6qnazrMSrfSyFYOfr5MTmZMnuor9XEh9wVa4ey6DO/bz
 0vgIQoFZzPUL+NdPYUeU7+PzD+FiiO/01f/Rz18JrWGS+9itdcSVqV+nbxA3nHwxeS7vVInvJJ
 oCIzmlN9GUvthhKRp8lzEX2b9E7safxOpRaV8t3q8S2JG9KlCv5z3hVrJ8EdRVKWnwHJ3coUpf
 anGE+N3+Axb+O4mjNn1amv+AO1EyAbVJm5tHseNazZa36nudM3BUjuL1EkxnzPjcqGI8pKkKlE
 IuajMrGtmb/kTCe+GRy9fCTF
IronPort-SDR: pYbm7xPQid0cXBmc/avQpm9PUWPpsLgaBNC63sC3iStAkCvXMtK/2sVSQWEpI+QODF963ohI8L
 uCwA2V7ELM6M1icle1y/jGBp5kyAMLOGi9tgCP9ZtQoBIx7kyea0tF201bFsNGWX1PS1psRcsC
 XBOYR7QwfUWy8ZSDHm04Hu4y6wBvNPT5lr4viFChvyl4L0goSck8DI5m3ih4td1uyaYI5ao7LR
 sre6+lsekk8kss1KkoLnO7RsPbnQBWFXwJg9kQ4NAiAQaHQRBnl8iOieDp0aHAcho3osxk8zcM
 1gE=
WDCIronportException: Internal
Message-ID: <065e9c29-0ceb-9b5d-ee99-ab501773c883@opensource.wdc.com>
Date:   Fri, 17 Jun 2022 08:29:27 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v7 10/13] dm-table: use bdev_is_zone_start helper in
 device_area_is_invalid()
Content-Language: en-US
To:     Pankaj Raghav <p.raghav@samsung.com>, hch@lst.de,
        snitzer@redhat.com, axboe@kernel.dk
Cc:     bvanassche@acm.org, linux-kernel@vger.kernel.org,
        jiangbo.365@bytedance.com, hare@suse.de, pankydev8@gmail.com,
        dm-devel@redhat.com, jonathan.derrick@linux.dev,
        gost.dev@samsung.com, dsterba@suse.com, jaegeuk@kernel.org,
        linux-nvme@lists.infradead.org, Johannes.Thumshirn@wdc.com,
        linux-block@vger.kernel.org, Luis Chamberlain <mcgrof@kernel.org>
References: <20220615101920.329421-1-p.raghav@samsung.com>
 <CGME20220615102000eucas1p27720aaa3c309327b2b9a33c5f840f498@eucas1p2.samsung.com>
 <20220615101920.329421-11-p.raghav@samsung.com>
 <064551fa-4575-87cb-d9da-90a34309f634@opensource.wdc.com>
 <50731e57-e0bb-179e-388c-32a18b0c610e@samsung.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <50731e57-e0bb-179e-388c-32a18b0c610e@samsung.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/16/22 18:55, Pankaj Raghav wrote:
> drivers/md/dm-table.c
>>> +++ b/drivers/md/dm-table.c
>>> @@ -251,7 +251,7 @@ static int device_area_is_invalid(struct dm_target *ti, struct dm_dev *dev,
>>>  	if (bdev_is_zoned(bdev)) {
>>>  		unsigned int zone_sectors = bdev_zone_sectors(bdev);
>>>  
>>> -		if (start & (zone_sectors - 1)) {
>>> +		if (blk_queue_is_zone_start(bdev_get_queue(bdev), start)) {
>>
>> This is wrong. And you are changing this to the correct test in the next
>> patch.
>>
> Yeah, I think I made a mistake while committing it. The next patch
> should only have the removing po2 condition check and these changes
> should have been only in this patch. I will fix it up!

This one and the next patch should be squashed together. They both deal
with non power of 2 zone size.


>>>  			DMWARN("%s: start=%llu not aligned to h/w zone size %u of %pg",
>>>  			       dm_device_name(ti->table->md),
>>>  			       (unsigned long long)start,
>>> @@ -268,7 +268,7 @@ static int device_area_is_invalid(struct dm_target *ti, struct dm_dev *dev,
>>>  		 * devices do not end up with a smaller zone in the middle of
>>>  		 * the sector range.
>>>  		 */
>>> -		if (len & (zone_sectors - 1)) {
>>> +		if (blk_queue_is_zone_start(bdev_get_queue(bdev), len)) {
>>>  			DMWARN("%s: len=%llu not aligned to h/w zone size %u of %pg",
>>>  			       dm_device_name(ti->table->md),
>>>  			       (unsigned long long)len,
>>
>>


-- 
Damien Le Moal
Western Digital Research