Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1899302iog; Thu, 16 Jun 2022 16:54:12 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uAdyGI9pCNMbFb6nSfvQMbLwx5GPiW/a/AlYwiYxtHTCsWldX1zVdq+upKPM+zThFJG5/K X-Received: by 2002:a50:ff0e:0:b0:433:5d15:eada with SMTP id a14-20020a50ff0e000000b004335d15eadamr9323371edu.102.1655423652410; Thu, 16 Jun 2022 16:54:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655423652; cv=none; d=google.com; s=arc-20160816; b=A/5jhAs2/EA7gX09ET6MNpXEYBwuPPTvXWCFuAfWoLl4WDnQ7fwx4tvYx2318OHN+d BCUFjnOjtpe6ivwx1IR1fC26nXhAgrHHwP+YuWQEtkUvDU+TnQdVOPscU7HRCoduHm9q QIp3TbxUTua+52jN0GDD/5GOdpKFX+MSxJJwtfxWcLwEFzINlG2qzr2E4vbmdZQ/Y+QV 6IJSKRsM8fTD8AYA9L9DYsE7+WlOuEEFbKhC527P2NEeS6gewNF0lG2iNdmTkFYaRW5d S4rBlvT3c8ZHfKgKEjwJOC2eYxQ/DziIITCcQAs9ADFeUeziCNJqalQSAvlozPpe3Bw3 5J5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=A/ErIrNj5gItrQCkLlcIujK6eoGjp3nC9yABjFCnK/8=; b=cl9Ip1uR6eNSBdGUzM0FCk7m1kJdBlP9MbRy/LD+HmGsnFkoAwuquoEY0T3Z02Sw2/ d2CnXteM79gVPyd+wvq1IEKKGTCa3N8ZvTkC8zPUbwFeUQowLjc+77sZY3T0QQtnwDMa GqihOjkyDTx1QcKA2+yzwqNRphp/9MWiOR1fuZ6Eu2sTaMTMgSM54GNrr13EoC9dAM/2 AjMYs0rS8SxZrlCtRdOfwQlirLSdvnh5d98eP63I/N+uWHKA1DrQSJh9gyePTFHyZkS6 YG+/Zmb9Jpl5sd/JG+XhbBq2XpjhyHdeZp40CFpOfebmUltddr4B3qHejXbRSMvVlVZM cIqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=dqGsgNAr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e6-20020a17090658c600b00718cd011ce2si3071559ejs.905.2022.06.16.16.53.47; Thu, 16 Jun 2022 16:54:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=dqGsgNAr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379217AbiFPXHr (ORCPT + 99 others); Thu, 16 Jun 2022 19:07:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378348AbiFPXHq (ORCPT ); Thu, 16 Jun 2022 19:07:46 -0400 Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 958F513D55 for ; Thu, 16 Jun 2022 16:07:45 -0700 (PDT) Received: by mail-il1-x135.google.com with SMTP id a15so1909481ilq.12 for ; Thu, 16 Jun 2022 16:07:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=A/ErIrNj5gItrQCkLlcIujK6eoGjp3nC9yABjFCnK/8=; b=dqGsgNArhDuF3C4hLhzp+lhKzSPCpnjS1CN0m8V2rVj3xLISsiNjMqpGoEp0xfWG/8 QadAGuhCBY7yWgoT3uNjJMIyx0CSG/wAyOPavmcGjx6Olz6I1vG3ePcCnNArbMg1OP9Z xIDkKeBumj5d6hBpuSqw78YfEdqxBNSDGcSNU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=A/ErIrNj5gItrQCkLlcIujK6eoGjp3nC9yABjFCnK/8=; b=ylKnd6OtLUFChdp6UZfFhQCBiszC3MjTiWu/pqABWx1pS61BPq4+/cka3LHk4lAyvg 9iugJclNmzNlwFPLbUZIirs9MaLuXrxRHglBq9lmp/RrDLtoTSp9QCznGiX4JLOiriJG Q4Olb4gK6ILUUiJkHC4IeLovuY1YKPAtg/BANmg17TLW7xwzYobygjyuUmIn94gqCUxp KJzEcXNOOnweNjLWjdgSq1XeU/hJiZIcdEoun9PZGwjYPbXuPaoJmwbzCKepbJl408hX +gXCoHFWjQzleIaAZD9iH0yv7UdNGq1VO3LkGuqyAfl2HzM1uaohotr/PdFMQPN/J/vZ c7vg== X-Gm-Message-State: AJIora+IAE7ABDyG+Ri0njMZ6Sz70W4oOB9alI9uCd2wApMZkqrUlN6I SToC2VbwzJXsOy1jptJWEI5QYw== X-Received: by 2002:a05:6e02:1a43:b0:2d3:cded:23dc with SMTP id u3-20020a056e021a4300b002d3cded23dcmr3942385ilv.43.1655420865020; Thu, 16 Jun 2022 16:07:45 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id z4-20020a029384000000b0032e91c1f73csm1439619jah.92.2022.06.16.16.07.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jun 2022 16:07:44 -0700 (PDT) Subject: Re: [PATCH] selftests: make use of GUP_TEST_FILE macro To: Nico Pache , Joel Savitz Cc: LKML , Andrew Morton , Shuah Khan , Linux MM , linux-kselftest@vger.kernel.org, Shuah Khan References: <20220609203217.3206247-1-jsavitz@redhat.com> From: Shuah Khan Message-ID: <30ac57f2-c95b-27f3-888e-d89c125770b0@linuxfoundation.org> Date: Thu, 16 Jun 2022 17:07:44 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/9/22 3:50 PM, Nico Pache wrote: > LGTM! Good catch :) > > Acked-by: Nico Pache > > On Thu, Jun 9, 2022 at 4:37 PM Joel Savitz wrote: >> >> Commit 17de1e559cf1 ("selftests: clarify common error when running >> gup_test") had most of its hunks dropped due to a conflict with another >> patch accepted into Linux around the same time that implemented the same >> behavior as a subset of other changes. >> >> However, the remaining hunk defines the GUP_TEST_FILE macro without >> making use of it. This patch makes use of the macro in the two relevant >> places. >> >> Furthermore, the above mentioned commit's log message erroneously describes >> the changes that were dropped from the patch. >> >> This patch corrects the record. >> >> Fixes: 17de1e559cf1 ("selftests: clarify common error when running gup_test") >> >> Signed-off-by: Joel Savitz >> --- Applied to linux-kselftest fixes for next rc thanks, -- Shuah