Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1924371iog; Thu, 16 Jun 2022 17:33:37 -0700 (PDT) X-Google-Smtp-Source: AGRyM1ugvFYStn4l7yO9+L7BFTBHJyYbRGbQgl7BqqKVSDpen5e9c6s07EyDLw1Nyot0ObFNdK5z X-Received: by 2002:a17:90b:1bc7:b0:1ea:d873:d1b1 with SMTP id oa7-20020a17090b1bc700b001ead873d1b1mr11241064pjb.1.1655426017433; Thu, 16 Jun 2022 17:33:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655426017; cv=none; d=google.com; s=arc-20160816; b=QZierTTwSROOXaaJGTbUg6gBXi7d2MS4V7/PBk0Ehk9aiz8Y2OjgKLUYtzgo/KzfQf i287cpddgZLJulEzlaUN59rJBPwkSDrFjS4ZUf+KxON2ha2Ox3YCG76bnPi2xdLKGFfG +dArR3e5qyEd3E4Xq0M0KMmas1ea1K8ecY4E6N0+l+Yp69Jn6j033TqWVe/ACrK5vkKE RuTUOTP+bvybfO0VOPpnpohHNgnwf3Vw710DQm5hMwRxSG90OcIfezMCUV7BkNWR06I8 wpcQqxi7cD/UwxFYmBp0AbWYTYrQlMQlNTsyIYZD73gVhzva/e2qOaN+vbMj/BjGMoP6 3XCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=LL3DUWQZjE4p+mxIqckBULPSLjSXfNwDLCcDvkn9bHs=; b=JQsQOXSmk4xxBHr8161NdWkq3TmIFj0GNVeptpCdfOYlQYZwq4CtGy7LsKV3sqT8hI QRBB34QDQKE2YTrIaunpKaYQj9ssozOtwDRlTuNgtY2DrTMsxQgR5GUunMxpSI3sos4c mUK+dBPYpqsRab3ijNBCrs78bSTtGr4/vOcIlXXMSZiHBkAkaTBlCh7eCMwUEjpZ/Tsg m3Q8xzVBa2xXv3J69euMGiPWz/xY9BFaEFmeAkPRytESyyd0ymY7etCwhhArAg9IKsHH pWUoPbH1SXMGRn548i6cGMa6WuN9NQINdKEw2s4a96cx26Y12mPCKnWmjI+e0Vf0ypE3 e2tA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZSo8wnvp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a126-20020a624d84000000b00524d0d3d51dsi2621943pfb.22.2022.06.16.17.33.24; Thu, 16 Jun 2022 17:33:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZSo8wnvp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232483AbiFQAJR (ORCPT + 99 others); Thu, 16 Jun 2022 20:09:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbiFQAJQ (ORCPT ); Thu, 16 Jun 2022 20:09:16 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C04D86212F; Thu, 16 Jun 2022 17:09:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7C7AEB82686; Fri, 17 Jun 2022 00:09:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24A4CC34114; Fri, 17 Jun 2022 00:09:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655424553; bh=30Al5rKQBM/7mOW3himhps8ySLSwkF/wPX3fgQop4wY=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=ZSo8wnvpiXlbFs2rASMFuJBYq96l4+nt3YHVn04zliVCx5u28iFJxoTS0iZBxHwH1 RsvUhyl9rwBDHVrQjGoklMyaQs9JAWS0Td3MhaL4wGsuyXz0I+imP241rOplqsZUzO wn5WAG+MafJp7XSJme+km/S/da7e4bjRz+mq8oQJ98dLY3C0e23pN1Z3jvRICQ5oeC hFZN0fDJfjkD8bopbIcocPUoFuJx9V5ugmGJsTn931YPeKOmWW79YA30vEiu+IA8M9 2FY1bevIzP5yYJleeR3SuF6Z5wu5GlDz3e9oNMSz6BfCyWQfNyobzjpkmEKP/jsdtY /HBVGEj7vIBMA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220616125409.3986745-1-windhl@126.com> References: <20220616125409.3986745-1-windhl@126.com> Subject: Re: [PATCH v3] drivers: clk: Add missing of_node_put() From: Stephen Boyd Cc: windhl@126.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Liang He , jonathanh@nvidia.com, pdeschrijver@nvidia.com, pgaikwad@nvidia.com, thierry.reding@gmail.com Date: Thu, 16 Jun 2022 17:09:11 -0700 User-Agent: alot/0.10 Message-Id: <20220617000913.24A4CC34114@smtp.kernel.org> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Liang He (2022-06-16 05:54:09) > In these clk-related drivers' xxx_init() funcitons, of_find_matching_node= () > will return a node pointer with refcount incremented. We should use > of_node_put() in fail path or when it is not used anymore. >=20 > Signed-off-by: Liang He > --- > changelog: >=20 > v3: merge clk 'missing of_node_put()' patches into one commit. > v2: use Liang He as real name for S-o-b. > v1: fix the missing of_node_put(). >=20 >=20 > drivers/clk/clk-nomadik.c | 5 ++++- > drivers/clk/tegra/clk-tegra124.c | 1 + > drivers/clk/tegra/clk-tegra30.c | 1 + Please split into a tegra patch and a nomadik patch.