Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1953988iog; Thu, 16 Jun 2022 18:24:12 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sckIVy5IFlpW9v0PgpO+7SEoCNcFA65GnXFQPiOWVofv9jHxf2/h4wgvwuM3imBF3Kwezn X-Received: by 2002:a17:906:3793:b0:702:eea9:843a with SMTP id n19-20020a170906379300b00702eea9843amr6923238ejc.465.1655429052509; Thu, 16 Jun 2022 18:24:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655429052; cv=none; d=google.com; s=arc-20160816; b=g87PavDPuWZDHQoYyxNVxzF0z8h4pxvc5q8xgFdjpJNq+2I6pLk6i4NvAx1M2wbzB8 q9kJMOOIGpcC9F4RvdcCH1fCdvE/yPNldwQegmjtPeoPrZb72EYchtAr4X52Iy9IXsWM fW88o4cyKvGcHXCwZDdJeQ0G8eN2ciSCtpqXQbrrlSwHcj4ypd+lXPCAeYu37a+nB/fn p241QLvRdRNSD4f4fuTh3TK4RLq+PxLQwEJ0qLuXJ3A0dwfB06SaL4MNfKow5/dyL/o8 qnRsnAhA53Y2c7LS6KdpElAURq66Mg+WEsQkfdZsJPpR2iHiQBb+glb+O3vZTnG9V7jQ IZKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=EnFsuev6N78aeW2rDgfVb+bfq7N8Zp9ofVFmNmiik8A=; b=C4/3gwkbGlNFbMBTugUcjQFRGPu/UaTc3+ZA2CDp3de2xaDrhLNwXkWKv4EEPlfRPB liiyycM8BMorECsKyUX8QnaHwHbZ66fFStol3vlVLCHIoDY0ay6zmvgiuS0gFFmFhKYp bc8PDId6HuXEwevZL/HcoIQdcX/Y3z6/9n/TEMiC9VdUc809tFy7Cb120ZIavL22yL02 wvqxWausDTFocgKdu39j5KrC4eKw22xJi/iAEpOe7NDNs5An33GQXJENwlrLBBfEj2+Z lcXhZXcIpNaErRZqi1ZnbOEPYpieNZdQc6d0tmC12In5hdL56OWeFNLe7KZNdRJOGdik nC3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e23-20020aa7d7d7000000b0042dce8b6634si26317eds.633.2022.06.16.18.23.47; Thu, 16 Jun 2022 18:24:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242922AbiFQBMt (ORCPT + 99 others); Thu, 16 Jun 2022 21:12:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229734AbiFQBMs (ORCPT ); Thu, 16 Jun 2022 21:12:48 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FB52A47E; Thu, 16 Jun 2022 18:12:46 -0700 (PDT) Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LPLb302kZzjXcJ; Fri, 17 Jun 2022 09:11:11 +0800 (CST) Received: from kwepemm600009.china.huawei.com (7.193.23.164) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 17 Jun 2022 09:12:44 +0800 Received: from [10.174.176.73] (10.174.176.73) by kwepemm600009.china.huawei.com (7.193.23.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 17 Jun 2022 09:12:43 +0800 Subject: Re: [PATCH -next v10 0/4] support concurrent sync io for bfq on a specail occasion To: , , , CC: , , , References: <20220610021701.2347602-1-yukuai3@huawei.com> From: Yu Kuai Message-ID: Date: Fri, 17 Jun 2022 09:12:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20220610021701.2347602-1-yukuai3@huawei.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.176.73] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600009.china.huawei.com (7.193.23.164) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Paolo Can you take a look at this patchset? Thanks, Kuai ?? 2022/06/10 10:16, Yu Kuai ะด??: > There are some problem in our mail server, resend v9 because Paolo seems > didn't receive them(hopefully v10 will be fine). > > Changes in v10: > - Add reviewed-tag for patch 2 > > Changes in v9: > - also update how many bfqqs have pending_reqs bfq_bfqq_move(). > - fix one language in patch 4 > - Add reviewed-tag for patch 1,3,4 > > Changes in v8: > - Instead of using whether bfqq is busy, using whether bfqq has pending > requests. As Paolo pointed out the former way is problematic. > > Changes in v7: > - fix mismatch bfq_inc/del_busy_queues() and bfqq_add/del_bfqq_busy(), > also retest this patchset on v5.18 to make sure functionality is > correct. > - move the updating of 'bfqd->busy_queues' into new apis > > Changes in v6: > - add reviewed-by tag for patch 1 > > Changes in v5: > - rename bfq_add_busy_queues() to bfq_inc_busy_queues() in patch 1 > - fix wrong definition in patch 1 > - fix spelling mistake in patch 2: leaset -> least > - update comments in patch 3 > - add reviewed-by tag in patch 2,3 > > Changes in v4: > - split bfq_update_busy_queues() to bfq_add/dec_busy_queues(), > suggested by Jan Kara. > - remove unused 'in_groups_with_pending_reqs', > > Changes in v3: > - remove the cleanup patch that is irrelevant now(I'll post it > separately). > - instead of hacking wr queues and using weights tree insertion/removal, > using bfq_add/del_bfqq_busy() to count the number of groups > (suggested by Jan Kara). > > Changes in v2: > - Use a different approch to count root group, which is much simple. > > Currently, bfq can't handle sync io concurrently as long as they > are not issued from root group. This is because > 'bfqd->num_groups_with_pending_reqs > 0' is always true in > bfq_asymmetric_scenario(). > > The way that bfqg is counted into 'num_groups_with_pending_reqs': > > Before this patchset: > 1) root group will never be counted. > 2) Count if bfqg or it's child bfqgs have pending requests. > 3) Don't count if bfqg and it's child bfqgs complete all the requests. > > After this patchset: > 1) root group is counted. > 2) Count if bfqg has pending requests. > 3) Don't count if bfqg complete all the requests. > > With the above changes, concurrent sync io can be supported if only > one group is activated. > > fio test script(startdelay is used to avoid queue merging): > [global] > filename=/dev/sda > allow_mounted_write=0 > ioengine=psync > direct=1 > ioscheduler=bfq > offset_increment=10g > group_reporting > rw=randwrite > bs=4k > > [test1] > numjobs=1 > > [test2] > startdelay=1 > numjobs=1 > > [test3] > startdelay=2 > numjobs=1 > > [test4] > startdelay=3 > numjobs=1 > > [test5] > startdelay=4 > numjobs=1 > > [test6] > startdelay=5 > numjobs=1 > > [test7] > startdelay=6 > numjobs=1 > > [test8] > startdelay=7 > numjobs=1 > > test result: > running fio on root cgroup > v5.18: 112 Mib/s > v5.18-patched: 112 Mib/s > > running fio on non-root cgroup > v5.18: 51.2 Mib/s > v5.18-patched: 112 Mib/s > > Note that I also test null_blk with "irqmode=2 > completion_nsec=100000000(100ms) hw_queue_depth=1", and tests show > that service guarantees are still preserved. > > Previous versions: > RFC: https://lore.kernel.org/all/20211127101132.486806-1-yukuai3@huawei.com/ > v1: https://lore.kernel.org/all/20220305091205.4188398-1-yukuai3@huawei.com/ > v2: https://lore.kernel.org/all/20220416093753.3054696-1-yukuai3@huawei.com/ > v3: https://lore.kernel.org/all/20220427124722.48465-1-yukuai3@huawei.com/ > v4: https://lore.kernel.org/all/20220428111907.3635820-1-yukuai3@huawei.com/ > v5: https://lore.kernel.org/all/20220428120837.3737765-1-yukuai3@huawei.com/ > v6: https://lore.kernel.org/all/20220523131818.2798712-1-yukuai3@huawei.com/ > v7: https://lore.kernel.org/all/20220528095020.186970-1-yukuai3@huawei.com/ > > > Yu Kuai (4): > block, bfq: support to track if bfqq has pending requests > block, bfq: record how many queues have pending requests > block, bfq: refactor the counting of 'num_groups_with_pending_reqs' > block, bfq: do not idle if only one group is activated > > block/bfq-cgroup.c | 10 ++++++++++ > block/bfq-iosched.c | 47 +++------------------------------------------ > block/bfq-iosched.h | 21 +++++++++++--------- > block/bfq-wf2q.c | 47 ++++++++++++++++++++++++++++++--------------- > 4 files changed, 57 insertions(+), 68 deletions(-) >