Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp34087iog; Thu, 16 Jun 2022 20:54:58 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tRIzxnzteC0JT7iucRqEln3xpSseAaAWpZ+FD4b6yEw7PWc0S81aEKfF1xk4bZpDJWb1jn X-Received: by 2002:a17:906:7297:b0:712:56de:3c43 with SMTP id b23-20020a170906729700b0071256de3c43mr7170255ejl.549.1655438097905; Thu, 16 Jun 2022 20:54:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655438097; cv=none; d=google.com; s=arc-20160816; b=HZG01eeiluxdses1Tw9nPNrssFMZxHbgeoj4pmpEgJl/KCsfkaxuf7Lii+LNASLG6M laTM33ejzNCO44Xo/ird7x/er8fvnjjZ2sNMEv+/UueJlaHFvGN1juehpTDk3/CIC15W mbz8sSsaU9lCCg7RsRLNNrZ2SbxuvKbbqzYWalY5PL0bYId+7YCmZAvvoFq4qvzhVfuP 5P0E8BGFSpu8Y8p19H3muLl3/qstFKtHZD5h20L/K5dqvKy0EsZweAdEO4fRqHZ9Rfbj qo9FtZgdFGxG8ks/4FE57UJZID4Z84cNZwg2z07d3MF8Xu4711N64JPYdNdlS5bx1oXX 9uYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=uRKrntUzQoHTv4JlS/S4G178HD4gOGzZh1kem20v+Dk=; b=XuDE82FIK7jW+uaYQBnN/Q7FlPPOGy+YGPjTZjpKCG/l5SMos8YI4icKQOT8j+UUFi cfNErMBmL2toOL8mCtXifGd79AsjnBWs+wDbfoXRAAzE4l0PYnDaijtC6Ul3/TrnqPJ9 HkOky24xOdzqD7SdQju4l0ku9G4zWHe70euNx5df136s63hCmpwAGb0ghI6u1uJrY+gf 5TiYKDcfacqSrml4wUQxFnXUnKHIqimZn9ah1+7KPzEZCt1OSYV8Ay5ppWCb9yLATVQU 57kctwjGOVCb29ZG6q4a2FfxiIteSkMXyOD+ufUZuZE68GIDewtxThf+c7hbDOEGg3nM wvcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@126.com header.s=s110527 header.b=N1mVINlG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=126.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gn28-20020a1709070d1c00b006dff4dd30f9si837620ejc.862.2022.06.16.20.54.32; Thu, 16 Jun 2022 20:54:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@126.com header.s=s110527 header.b=N1mVINlG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=126.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379678AbiFQDrF (ORCPT + 99 others); Thu, 16 Jun 2022 23:47:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379624AbiFQDrE (ORCPT ); Thu, 16 Jun 2022 23:47:04 -0400 Received: from mail-m965.mail.126.com (mail-m965.mail.126.com [123.126.96.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5AC57663E1 for ; Thu, 16 Jun 2022 20:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=uRKrn tUzQoHTv4JlS/S4G178HD4gOGzZh1kem20v+Dk=; b=N1mVINlG1NV8k0fX2LD4A lzQQsPbs56HpYcbaYA9ZDeg4QGXrh/AtWXkXbM3hV9EXsmwGJjAEG6O57W0ZPo8c 00OuJlBuper1zINfCQXHzQPnn3HNCz4A4HNxapdOR6rrTiGXA+33+Dd6evFUZU0v FtjyrcKCU8dv9bNWTBlyPk= Received: from localhost.localdomain (unknown [124.16.139.61]) by smtp10 (Coremail) with SMTP id NuRpCgBHqV0e+atiq7xeEw--.58613S2; Fri, 17 Jun 2022 11:46:44 +0800 (CST) From: Liang He To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: windhl@126.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: host: ohci-ppc-of: Fix refcount leak bug Date: Fri, 17 Jun 2022 11:46:37 +0800 Message-Id: <20220617034637.4003115-1-windhl@126.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: NuRpCgBHqV0e+atiq7xeEw--.58613S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7GFy8GFy3WrW5try5ZFW3Awb_yoW3Wwb_Aa 4rWr17W3ykWFn8KFWjkFWY9rZ2kr1kWF40vF1ktwnagw1qkFn8WrnFvFWDJay5WrWUJF90 kwn7XF1xuF4S9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUUyrW3UUUUU== X-Originating-IP: [124.16.139.61] X-CM-SenderInfo: hzlqvxbo6rjloofrz/xtbBGhUjF1-HZUMOZwAAss X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In ohci_hcd_ppc_of_probe(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Signed-off-by: Liang He --- drivers/usb/host/ohci-ppc-of.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ohci-ppc-of.c b/drivers/usb/host/ohci-ppc-of.c index 1960b8dfdba5..591f675cc930 100644 --- a/drivers/usb/host/ohci-ppc-of.c +++ b/drivers/usb/host/ohci-ppc-of.c @@ -166,6 +166,7 @@ static int ohci_hcd_ppc_of_probe(struct platform_device *op) release_mem_region(res.start, 0x4); } else pr_debug("%s: cannot get ehci offset from fdt\n", __FILE__); + of_node_put(np); } irq_dispose_mapping(irq); -- 2.25.1