Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: CYBs5PL+gfaEsKX9rGrmPXv1LPSPxsZTnWs4aBxmSOL5LIGBZzldxEOK7NcfUn+BFz4LGkeVQy
 6PkN5P1oxEmV+AsqZK2xFyxyuJ/qMrQgQL3POmzAz2oCJSt+UZIhrn2Yx5Yc29fNWHOPZLgIUD
 v3ugtPHM4W9x+OakTmSYftJKehQwZTs3VkyvJp/l3kekbOo1dEqKA3++TDmaDivEiKlrOv0/w9
 67IZXFaQdwI5hCwTDnMpOCZ5Jt3lYMmZG5NHRXgHRrKqCGXsUjl8Pa0ky3eNwlPAIMiIXfnQSF
 EElYJNUXzQ7q2xggdBCZ59kB
IronPort-SDR: dz3OUvdvSMsfoLqzt2BKYRGTztvBAt8BH41MaELUDsZQK2mAJgr5ZC59dtJmZT6qsxigtza2Sx
 YpmCmF7RI0BGwDdS9PYEpTiE8cFK3UmrunVxu/OqHbAj9td/p2yzqmCE8163UD5+uhdApyBSA6
 Dgxn55Oo7OyEBGNHnfKLFupsR8PzOtanacWOw75a1JqszO+e3HQAp64FnumqlVe2H2JGOyCAul
 GNHd6JhiDuI86hZroE8DfGRxMj/z4mbZYqS6W0GD8aYc80RpLTb7QaSwSP+Dk/Ui/KZaJUI9t5
 mbg=
WDCIronportException: Internal
Message-ID: <e8fe553b-53cb-1dee-36c7-f4f737c81e30@opensource.wdc.com>
Date:   Fri, 17 Jun 2022 12:26:51 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v3] ata: libata: add qc->flags in ata_qc_complete_template
 tracepoint
Content-Language: en-US
To:     Edward Wu <edwardwu@realtek.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>, Hannes Reinecke <hare@suse.de>,
        Tejun Heo <tj@kernel.org>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220616001615.11636-1-edwardwu@realtek.com>
 <20220617030007.21768-1-edwardwu@realtek.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220617030007.21768-1-edwardwu@realtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/17/22 12:00, Edward Wu wrote:
> Add flags value to check the result of ata completion
> 
> Fixes: 255c03d15a29 ("libata: Add tracepoints")
> Cc: stable@vger.kernel.org
> Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

Looks good. But please do not randomly add tags like the above ack. I
never sent that ! And since I will be applying this patch, I will add my
signed-of-by tag, not a acked-by tag.

> Signed-off-by: Edward Wu <edwardwu@realtek.com>
> ---
> Thanks for your kindly guiding.
> 
>  include/trace/events/libata.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/trace/events/libata.h b/include/trace/events/libata.h
> index d4e631aa976f..6025dd8ba4aa 100644
> --- a/include/trace/events/libata.h
> +++ b/include/trace/events/libata.h
> @@ -288,6 +288,7 @@ DECLARE_EVENT_CLASS(ata_qc_complete_template,
>  		__entry->hob_feature	= qc->result_tf.hob_feature;
>  		__entry->nsect		= qc->result_tf.nsect;
>  		__entry->hob_nsect	= qc->result_tf.hob_nsect;
> +		__entry->flags		= qc->flags;
>  	),
>  
>  	TP_printk("ata_port=%u ata_dev=%u tag=%d flags=%s status=%s " \


-- 
Damien Le Moal
Western Digital Research