Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Christophe Leroy <christophe.leroy@csgroup.eu>
To:     Liang He <windhl@126.com>, "oss@buserror.net" <oss@buserror.net>,
        "mpe@ellerman.id.au" <mpe@ellerman.id.au>,
        "benh@kernel.crashing.org" <benh@kernel.crashing.org>,
        "paulus@samba.org" <paulus@samba.org>
CC:     "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] powerpc:85xx: Add missing of_node_put() in sgy_cst1000
Thread-Topic: [PATCH v4] powerpc:85xx: Add missing of_node_put() in
 sgy_cst1000
Thread-Index: AQHYghDOP24Nvh9u1kCVcZ2VbzP84a1TIukA
Date:   Fri, 17 Jun 2022 06:28:56 +0000
Message-ID: <eb72976a-9ca3-b894-b2d5-8283a4cf486d@csgroup.eu>
References: <20220617060827.4004795-1-windhl@126.com>
In-Reply-To: <20220617060827.4004795-1-windhl@126.com>
Accept-Language: fr-FR, en-US
Content-Language: en-US
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UklGM1grODJ1VEtDeWE0MWJ0UDBKN1NqS0piUUtCamtKeHczT1ZEZ09qd3dK?=
 =?utf-8?B?NGpWQklWckRtOHFRMEJoMjJ6YjZzb0VabEFnbmVHM0V5MHp3V2ZFbTRmZERx?=
 =?utf-8?B?WlZmUDhwRFUwS0dSb1hUdjhYU2ljek5saFdCSktVZGlCd25hN28rdUhqRTNx?=
 =?utf-8?B?NkRsYWRFUWZQWTZvNkVNVC90dCtyUVF4eTNvOTNaSG5UbkxLUWZSSzA4dzRv?=
 =?utf-8?B?QkpLZVZjOFYvcUsxTGFoTjYzcUdjRTI5Y1FYcUYvR0RwcjNEcTRsNTU0dFJp?=
 =?utf-8?B?VFAySmYvRDg0bGZEbHpaUkwvNEp4N3FRZk1NSEJMK0M3ZWhwNm5mVFkrUzdz?=
 =?utf-8?B?dHd0TjlUd1lVM2poU2Q2SHR1ZVp1OUtiMTA3c1VtTm90VTMyNXF5VE55UTIv?=
 =?utf-8?B?dnNGWnVlOCtIazlDVmJHaDR4Z0FKVHlKMjI5NndiUlZGeFBUZG5PMlQ1c2lz?=
 =?utf-8?B?WkV3UkYxM2FTOHZNUDd0ejNkS3puTFkxT2l0NzBqb0kreWNaNi9wRVl4STIr?=
 =?utf-8?B?ZGlNenVYa0pKS3Zqa0RLYitEUXc1K21ZVWlLQ1NPL3VYZnNDYmdCdHZ1ZHV3?=
 =?utf-8?B?VEZvSEgrQmlITHB6aWxybzBjaVlLZTBLeUVLZEduNHlYWUN0NlRmblRGbEFG?=
 =?utf-8?B?aG0zSDUzbk55SGtHV3B6eXNaL252U0lqMFg1SGJRK3EwNTZBbjBMUUhiVURi?=
 =?utf-8?B?eHA3RTRSb210K09pQ2hkWm9DSjdYcnJQbVRuZEljb3FyeWtFRFN1OGFORmI0?=
 =?utf-8?B?SHVlUjl0RXd2NERnRjlVOTVQYTJlQW1jdHA3TjdTQThIR1ZYV3FRN1A0bDNT?=
 =?utf-8?B?ZUhCUFpJNmNiVU5rdk0xOGZUWmh6WEdmS2g5YkdZZ1ZKNWtuNFc1djVJcGNq?=
 =?utf-8?B?bWovVVprN2xpRFAzbVFEczcyRTlmZ0twVk5HaHRMbzE4VkswL0F1cnJvRUpi?=
 =?utf-8?B?YXI4NGV3bGdWeE5ES1Zhc0drTEpPdS9WNmluVVJSWllaZm9DeGJGdTVqQXha?=
 =?utf-8?B?cnRYODRkTU9RTStoRTVTeFBBdFd4eFBNd211ekN1VEl2dzN6cUxLWGlZVVUx?=
 =?utf-8?B?U2VkM3k3UGp3YllYdE54U1lPSnRjWm9PV0kvOWhIUXZSQmZObll1eDdSMWtP?=
 =?utf-8?B?NGpKcDQvWk14REIzeXhoTE5MbDBHbjMzLzY1WjJHejBJWWxLY295dWlrN3Fu?=
 =?utf-8?B?cDB5RjB1QWQ2SmlJK3BHK1hONEduVW5LWWpBU2k3TDJ4aDRhemRIOTNPK29X?=
 =?utf-8?B?K0lYb0JKd1dnUStsTnp5Vm9VaDc2cjdyWEFLTkJyeFNRL1pwaWEvY1d5bkVS?=
 =?utf-8?B?ZVhpNmwxSllBTWRJQUF1d0xheEZSQjRRTXNNMHlQM0xDZ2Vkck9qb01RaXJh?=
 =?utf-8?B?eEFvbnVPQWpBanZ5S0tJeXhjRGxIOGkrbUZDaUlKZHhxeE9mL0Y1T1grV3RT?=
 =?utf-8?B?a1J0VHgrM2ZCQU5ZeWdCYThHcHUvaWozUW81YkRRWENDQnlCelV4bzQ4ZlBF?=
 =?utf-8?B?VzM3NkhveFROcXQ4bVgzK1RxNWtaV2hKRE9EL0p2cm9HdXZROWJSRkZHT2Ra?=
 =?utf-8?B?SWphZG1oTEZmOUwyNmR0Y3duNldUSlRmQ3E3MWpnSDlBdTdoYStNRzAyRmlh?=
 =?utf-8?B?UFNMNnpuOUl1dEI0UXZ3bGFSQTJjWCsrSnBya1RaNGEzRVFvTmFIVGNGY0tr?=
 =?utf-8?B?dWRsUkw0dEl1L2hGZktsdDZOYVlqSkQranU3b0k1dVg2WWJmQ1hidTNoamNk?=
 =?utf-8?B?UzNuRUYzQ2lEVUlaa1U1Z296S3VvR1ljNCthVERVTWFtRUtUVDRHY01UdjJR?=
 =?utf-8?B?ZlR4QlVINEJ0UHVDSndyUmpPNzhiRHZhTVpFNXFkby9LMVRrTVhGb2lTSlRY?=
 =?utf-8?B?MnR3eFV3QUEyR1RmRW9JL2J1b2hZb3NrYy9DTDBGdFFYa3VQRXQxalloVGlw?=
 =?utf-8?B?RC9Lc1hEL0RpRExZdGlBQmxtblludm85VVVTTDlqN3RLQXBhckIyR1ZVNWQ2?=
 =?utf-8?B?My9PU0hOekFBa3R1Z2doK3R1Z1lmRHlVZnh2ZW5VR01zUFZKcURBT05wY3Ru?=
 =?utf-8?B?a3JLTzNUSXdLYlFJdE9OUGhOY0l1SmprSEVqejJhVkhEVUtDbjE4NGlRdXRl?=
 =?utf-8?B?TVBNd3RoVUpsUnhoZFgvTEt4akZ0ekQ1dERZcTlCRHE5bW9DS291Sjh4Mktx?=
 =?utf-8?B?bnI5WVJDVFdiMTFZSHRyZzhxSGRaU3JzNXZGRHZzNlIzcFJISHZzV0I3NS9T?=
 =?utf-8?B?SHNJcEh1L0pybGZVSW5JWUpBa1RZVTRiQXdQOTFMVzI5cm80Um1xWnpPRFd6?=
 =?utf-8?B?Rm9FNllZeGd6RTVkYXNxMUFTUytQMG80b2RkN3A5YjBIaWptZUhWM00xcnlN?=
 =?utf-8?Q?jzLcK3fWOMAijbRzCNVbS2lPDbljOIdP6P+Ad?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <07B6A58372BCEC4EAE7154F8B7C40E8A@FRAP264.PROD.OUTLOOK.COM>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: csgroup.eu
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MRZP264MB2988.FRAP264.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: a55e22d4-7eff-4a34-7746-08da502aa82c
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2022 06:28:56.6368
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 9914def7-b676-4fda-8815-5d49fb3b45c8
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QiDw/Md3GPoAPpojB/3l9aXgGQaYv7QrCsylfD1lAlwFZS42yTUj9m7HzAtwltFDBnxjSxFVpXVBSEvHkkSzciBWcNj9H0rDNKJFb4pJmY4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAZP264MB2541
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

DQoNCkxlIDE3LzA2LzIwMjIgw6AgMDg6MDgsIExpYW5nIEhlIGEgw6ljcml0wqA6DQo+IEluIGdw
aW9faGFsdF9wcm9iZSgpLCBvZl9maW5kX21hdGNoaW5nX25vZGUoKSB3aWxsIHJldHVybiBhIG5v
ZGUNCj4gcG9pbnRlciB3aXRoIHJlZmNvdW50IGluY3JlbWVudGVkLiBXZSBzaG91bGQgdXNlIG9m
X25vZGVfcHV0KCkgaW4NCj4gZmFpbCBwYXRoIG9yIHdoZW4gaXQgaXMgbm90IHVzZWQgYW55bW9y
ZS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IExpYW5nIEhlIDx3aW5kaGxAMTI2LmNvbT4NCj4gLS0t
DQo+ICAgY2hhbmdlbG9nOg0KPiAgIHY0OiByZXVzZSBleGlzdCAnZXJyJyBhbmQgdXNlIGEgc2lt
cGxlIGNvZGUgc3R5bGUsIGFkdmlzZWQgYnkgQ0oNCj4gICB2MzogdXNlIGxvY2FsICdjaGlsZF9u
b2RlJyBhZHZpc2VkIGJ5IE1pY2hhZWwuDQo+ICAgdjI6IHVzZSBnb3RvLWxhYmVsIHBhdGNoIHN0
eWxlIGFkdmlzZWQgYnkgQ2hyaXN0b3BoZSBMZXJveS4NCj4gICB2MTogYWRkIG9mX25vZGVfcHV0
KCkgYmVmb3JlIGVhY2ggZXhpdC4NCj4gDQo+ICAgYXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy84NXh4
L3NneV9jdHMxMDAwLmMgfCAzNSArKysrKysrKysrKysrKy0tLS0tLS0tLQ0KPiAgIDEgZmlsZSBj
aGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1n
aXQgYS9hcmNoL3Bvd2VycGMvcGxhdGZvcm1zLzg1eHgvc2d5X2N0czEwMDAuYyBiL2FyY2gvcG93
ZXJwYy9wbGF0Zm9ybXMvODV4eC9zZ3lfY3RzMTAwMC5jDQo+IGluZGV4IDk4YWU2NDA3NTE5My4u
ZTQ1ODg5NDNmZTdlIDEwMDY0NA0KPiAtLS0gYS9hcmNoL3Bvd2VycGMvcGxhdGZvcm1zLzg1eHgv
c2d5X2N0czEwMDAuYw0KPiArKysgYi9hcmNoL3Bvd2VycGMvcGxhdGZvcm1zLzg1eHgvc2d5X2N0
czEwMDAuYw0KPiBAQCAtNzEsNiArNzEsNyBAQCBzdGF0aWMgaW50IGdwaW9faGFsdF9wcm9iZShz
dHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQ0KPiAgIHsNCj4gICAJZW51bSBvZl9ncGlvX2Zs
YWdzIGZsYWdzOw0KPiAgIAlzdHJ1Y3QgZGV2aWNlX25vZGUgKm5vZGUgPSBwZGV2LT5kZXYub2Zf
bm9kZTsNCj4gKwlzdHJ1Y3QgZGV2aWNlX25vZGUgKmNoaWxkX25vZGU7DQo+ICAgCWludCBncGlv
LCBlcnIsIGlycTsNCj4gICAJaW50IHRyaWdnZXI7DQo+ICAgDQo+IEBAIC03OCwyNiArNzksMjkg
QEAgc3RhdGljIGludCBncGlvX2hhbHRfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRl
dikNCj4gICAJCXJldHVybiAtRU5PREVWOw0KPiAgIA0KPiAgIAkvKiBJZiB0aGVyZSdzIG5vIG1h
dGNoaW5nIGNoaWxkLCB0aGlzIGlzbid0IHJlYWxseSBhbiBlcnJvciAqLw0KPiAtCWhhbHRfbm9k
ZSA9IG9mX2ZpbmRfbWF0Y2hpbmdfbm9kZShub2RlLCBjaGlsZF9tYXRjaCk7DQo+IC0JaWYgKCFo
YWx0X25vZGUpDQo+ICsJY2hpbGRfbm9kZSA9IG9mX2ZpbmRfbWF0Y2hpbmdfbm9kZShub2RlLCBj
aGlsZF9tYXRjaCk7DQo+ICsJaWYgKCFjaGlsZF9ub2RlKQ0KPiAgIAkJcmV0dXJuIDA7DQo+ICAg
DQo+ICAgCS8qIFRlY2huaWNhbGx5IHdlIGNvdWxkIGp1c3QgcmVhZCB0aGUgZmlyc3Qgb25lLCBi
dXQgcHVuaXNoDQo+ICAgCSAqIERUIHdyaXRlcnMgZm9yIGludmFsaWQgZm9ybS4gKi8NCj4gLQlp
ZiAob2ZfZ3Bpb19jb3VudChoYWx0X25vZGUpICE9IDEpDQo+IC0JCXJldHVybiAtRUlOVkFMOw0K
PiArCWlmIChvZl9ncGlvX2NvdW50KGNoaWxkX25vZGUpICE9IDEpIHsNCj4gKwkJZXJyID0gLUVJ
TlZBTDsNCj4gKwkJZ290byBlcnJfcHV0Ow0KPiArCX0NCj4gICANCj4gICAJLyogR2V0IHRoZSBn
cGlvIG51bWJlciByZWxhdGl2ZSB0byB0aGUgZHluYW1pYyBiYXNlLiAqLw0KPiAtCWdwaW8gPSBv
Zl9nZXRfZ3Bpb19mbGFncyhoYWx0X25vZGUsIDAsICZmbGFncyk7DQo+IC0JaWYgKCFncGlvX2lz
X3ZhbGlkKGdwaW8pKQ0KPiAtCQlyZXR1cm4gLUVJTlZBTDsNCj4gKwlncGlvID0gb2ZfZ2V0X2dw
aW9fZmxhZ3MoY2hpbGRfbm9kZSwgMCwgJmZsYWdzKTsNCj4gKwlpZiAoIWdwaW9faXNfdmFsaWQo
Z3BpbykpIHsNCj4gKwkJZXJyID0gLUVJTlZBTDsNCj4gKwkJZ290b3QgZXJyX3B1dDsNCg0KRGlk
IHlvdSB0ZXN0IHRoZSBidWlsZCA/DQoNCj4gKwl9DQo+ICAgDQo+ICAgCWVyciA9IGdwaW9fcmVx
dWVzdChncGlvLCAiZ3Bpby1oYWx0Iik7DQo+ICAgCWlmIChlcnIpIHsNCj4gICAJCXByaW50ayhL
RVJOX0VSUiAiZ3Bpby1oYWx0OiBlcnJvciByZXF1ZXN0aW5nIEdQSU8gJWQuXG4iLA0KPiAgIAkJ
ICAgICAgIGdwaW8pOw0KPiAtCQloYWx0X25vZGUgPSBOVUxMOw0KPiAtCQlyZXR1cm4gZXJyOw0K
PiArCQlnb3RvIGVycl9wdXQ7DQo+ICAgCX0NCj4gICANCj4gICAJdHJpZ2dlciA9IChmbGFncyA9
PSBPRl9HUElPX0FDVElWRV9MT1cpOw0KPiBAQCAtMTA1LDE1ICsxMDksMTQgQEAgc3RhdGljIGlu
dCBncGlvX2hhbHRfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikNCj4gICAJZ3Bp
b19kaXJlY3Rpb25fb3V0cHV0KGdwaW8sICF0cmlnZ2VyKTsNCj4gICANCj4gICAJLyogTm93IGdl
dCB0aGUgSVJRIHdoaWNoIHRlbGxzIHVzIHdoZW4gdGhlIHBvd2VyIGJ1dHRvbiBpcyBoaXQgKi8N
Cj4gLQlpcnEgPSBpcnFfb2ZfcGFyc2VfYW5kX21hcChoYWx0X25vZGUsIDApOw0KPiArCWlycSA9
IGlycV9vZl9wYXJzZV9hbmRfbWFwKGNoaWxkX25vZGUsIDApOw0KPiAgIAllcnIgPSByZXF1ZXN0
X2lycShpcnEsIGdwaW9faGFsdF9pcnEsIElSUUZfVFJJR0dFUl9SSVNJTkcgfA0KPiAtCQkJICBJ
UlFGX1RSSUdHRVJfRkFMTElORywgImdwaW8taGFsdCIsIGhhbHRfbm9kZSk7DQo+ICsJCQkgIElS
UUZfVFJJR0dFUl9GQUxMSU5HLCAiZ3Bpby1oYWx0IiwgY2hpbGRfbm9kZSk7DQo+ICAgCWlmIChl
cnIpIHsNCj4gICAJCXByaW50ayhLRVJOX0VSUiAiZ3Bpby1oYWx0OiBlcnJvciByZXF1ZXN0aW5n
IElSUSAlZCBmb3IgIg0KPiAgIAkJICAgICAgICJHUElPICVkLlxuIiwgaXJxLCBncGlvKTsNCj4g
ICAJCWdwaW9fZnJlZShncGlvKTsNCj4gLQkJaGFsdF9ub2RlID0gTlVMTDsNCj4gLQkJcmV0dXJu
IGVycjsNCj4gKwkJZ290byBlcnJfcHV0Ow0KPiAgIAl9DQo+ICAgDQo+ICAgCS8qIFJlZ2lzdGVy
IG91ciBoYWx0IGZ1bmN0aW9uICovDQo+IEBAIC0xMjMsNyArMTI2LDEyIEBAIHN0YXRpYyBpbnQg
Z3Bpb19oYWx0X3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpDQo+ICAgCXByaW50
ayhLRVJOX0lORk8gImdwaW8taGFsdDogcmVnaXN0ZXJlZCBHUElPICVkICglZCB0cmlnZ2VyLCAl
ZCINCj4gICAJICAgICAgICIgaXJxKS5cbiIsIGdwaW8sIHRyaWdnZXIsIGlycSk7DQo+ICAgDQo+
ICsJaGFsdF9ub2RlID0gY2hpbGRfbm9kZTsNCj4gICAJcmV0dXJuIDA7DQo+ICsNCj4gK2Vycl9w
dXQ6DQo+ICsJb2Zfbm9kZV9wdXQoY2hpbGRfbm9kZSk7DQo+ICsJcmV0dXJuIGVycjsNCj4gICB9
DQo+ICAgDQo+ICAgc3RhdGljIGludCBncGlvX2hhbHRfcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9k
ZXZpY2UgKnBkZXYpDQo+IEBAIC0xMzksNiArMTQ3LDcgQEAgc3RhdGljIGludCBncGlvX2hhbHRf
cmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpDQo+ICAgDQo+ICAgCQlncGlvX2Zy
ZWUoZ3Bpbyk7DQo+ICAgDQo+ICsJCW9mX25vZGVfcHV0KGhhbHRfbm9kZSk7DQo+ICAgCQloYWx0
X25vZGUgPSBOVUxMOw0KPiAgIAl9DQo+ICAg