Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 17 Jun 2022 15:47:34 +0800
From:   Muchun Song <songmuchun@bytedance.com>
To:     Christophe Leroy <christophe.leroy@csgroup.eu>
Cc:     "mike.kravetz@oracle.com" <mike.kravetz@oracle.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: hugetlb: rework hugetlb cmdline parsing
Message-ID: <Yqwxlo7HYFv4jHco@FVFYT0MHHV2J.usts.net>
References: <20220616071827.3480-1-songmuchun@bytedance.com>
 <f175d757-e76c-085d-2001-68ae275475a3@csgroup.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f175d757-e76c-085d-2001-68ae275475a3@csgroup.eu>
Precedence: bulk

On Thu, Jun 16, 2022 at 08:00:58AM +0000, Christophe Leroy wrote:
> 
> 
> Le 16/06/2022 ? 09:18, Muchun Song a ?crit?:
> > I often get lost in the logic interleaved between numerous global
> > variables for parsing cmdline.  It is not easy to be maintained.
> > This patch aims to rework cmdline parsing to simlify the code and
> > make the code more readable.
> 
> This patch is quite big.
> 
> Can you explain in the commit description in more details what are the 
> changes performed by this patch ?
> 
> Otherwise I have absolutely no idea of what to review or what to test.
>

Sorry for the confusing, I'll rework the commit message in v2.

Thanks.