Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp252836iog; Fri, 17 Jun 2022 03:01:19 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sRWCzFZQuOzsfnYoXBDOVROkloODuMzFSQNNAIDhZQqOd52Z/CGP7f4mMjzMdoReF2fdDx X-Received: by 2002:a17:906:4f:b0:712:af2:29d9 with SMTP id 15-20020a170906004f00b007120af229d9mr8535644ejg.751.1655460078809; Fri, 17 Jun 2022 03:01:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655460078; cv=none; d=google.com; s=arc-20160816; b=b4uJ+nAaX403uic4pwZIJ7Vi9l/i71apZ4rz0eriv7sSblyDn2euIooz6+hRh10RDd 83F1ZGFo2664iN09Kr5Qfa5XFhfTqh9FK05090430zyJM+mQufsMwS74AX97f4PJZU2P /1sss/KPKlllGREnGDs0M8vh8271v2H8waq+ArGutjgnzuRPZNlgKK+Ii/RGGLOsrshO HSiZfooRs7lQn6+aVWyiP9T4hJWdCsqdcR7Xa6Wsf8nrmS22pHoL2WTL22Gt9VOdz9vL oWkKzaNkA05p2dYnZrGSO+TQFQxtjqvEIvBu/5beaux76ob1kBYoGTqqybHTrwREHOuo QNkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=FE+aj5ayNkTxoe9opWa9n6glT19c1FF/b31MXs+5Zh8=; b=O6DxNTcLup8vStAmJKbxJdMnoeYaU4zTryBv9JEQKHorkOZ0CjvENDTQC0b652h4ay U126MHvU0tLn3z8vXSjdvYjoJQmvsYN2OZnNTMqVcjUGwg1l1QsfNz05gbU+8/I7mtz8 ldYfLMp4hdGMXywbZCzHtwP3ikx8Pq4XV65Y6K4DHvxgOLMadzCtNGKLPq/itKOkZTDj 2Mjd1t5V88Mi6TQQGKfDPFBcwYmKtY7FJH+vwVI+Do4XxR6QE9ZNk9KQmsbA+U32dJE+ IMumqQmo6ssJSlWbaHIz5/6obDviDtm2tYbxHjbsnbz0if/VI9a75le2u1RIpy0U+JjV vC6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z3-20020a056402274300b0043343af5d52si1588305edd.409.2022.06.17.03.00.40; Fri, 17 Jun 2022 03:01:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235272AbiFQJSF (ORCPT + 99 others); Fri, 17 Jun 2022 05:18:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230200AbiFQJSE (ORCPT ); Fri, 17 Jun 2022 05:18:04 -0400 Received: from zg8tmtyylji0my4xnjqunzqa.icoremail.net (zg8tmtyylji0my4xnjqunzqa.icoremail.net [162.243.164.74]) by lindbergh.monkeyblade.net (Postfix) with SMTP id A647B1F2F1 for ; Fri, 17 Jun 2022 02:17:59 -0700 (PDT) Received: from fedora33.wangsu.com (unknown [59.61.78.232]) by app2 (Coremail) with SMTP id SyJltAC3vuK9RqxiNskEAA--.8183S2; Fri, 17 Jun 2022 17:17:55 +0800 (CST) From: Lin Feng To: gregkh@linuxfoundation.org, tj@kernel.org Cc: linux-kernel@vger.kernel.org, linf@wangsu.com Subject: [PATCH] kernfs/file.c: remove redundant error return counter assignment Date: Fri, 17 Jun 2022 17:17:46 +0800 Message-Id: <20220617091746.206515-1-linf@wangsu.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: SyJltAC3vuK9RqxiNskEAA--.8183S2 X-Coremail-Antispam: 1UD129KBjvdXoWrGr4kCw1rCF1kurWrtry8AFb_yoWxGFX_JF W8AryxCr4jvr1Iqr1kCw4Fvrn093Z3Zr1rK3y5tr1DKrn8X3yUGr9Yy3W5Ary5Jry3Gryk AFs8ur4Y9w4UtjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbxAFc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wA2ocxC64kI II0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7 xvwVC0I7IYx2IY6xkF7I0E14v26F4UJVW0owA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28E F7xvwVC2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F4 0EFcxC0VAKzVAqx4xG6I80ewAv7VACjcxG62k0Y48FwI0_Gr0_Cr1lYx0E74AGY7Cv6cx2 6r48McIj6xkF7I0En7xvr7AKxVW8Jr0_Cr1UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0x vY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc2xSY4AK67AK6r4fMxAIw28IcxkI 7VAKI48JMxAIw28IcVCjz48v1sIEY20_Gr4l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxV Aqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r12 6r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6x kF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AK xVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x0J UmzuAUUUUU= X-CM-SenderInfo: holqwq5zdqw23xof0z/ X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE,T_SPF_TEMPERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since previous 'rc = -EINVAL;', rc value doesn't change, so not necessary to re-assign it again. Signed-off-by: Lin Feng --- fs/kernfs/file.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c index e3abfa843879..54b2a13ac9a2 100644 --- a/fs/kernfs/file.c +++ b/fs/kernfs/file.c @@ -484,7 +484,6 @@ static int kernfs_fop_mmap(struct file *file, struct vm_area_struct *vma) * It is not possible to successfully wrap close. * So error if someone is trying to use close. */ - rc = -EINVAL; if (vma->vm_ops && vma->vm_ops->close) goto out_put; -- 2.31.1