Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp257572iog; Fri, 17 Jun 2022 03:06:30 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vugk97M8m7UfAvHilbEHw2sM5CT06uGOvXSbo/4SMLkcQmtaIOfXILooWfzVhyvKn+GAjg X-Received: by 2002:a17:906:90cf:b0:70b:43a2:658b with SMTP id v15-20020a17090690cf00b0070b43a2658bmr8651383ejw.450.1655460389969; Fri, 17 Jun 2022 03:06:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655460389; cv=none; d=google.com; s=arc-20160816; b=FKNDXbjqsvBNMOqdly0AuSbInJp3BB7+Ma3OIBd9JSac5rXg7dEUQOhV0L49qMqJ92 i0Sabi/Ulo3Ol37aYTB/qx8db4oYhFFgwFCSIMZ/KARrVX7QFJEHcz7HwSjJuWC8wopT DErvRfE6TwEyTcjycmmNk/mO0Q7bwBnPB5h0hsFwRQ9D3Hbxt4uDscv3i3nSR2d8kvzR 0hx25cqUwBR1VNuL48FotQLNkBnqLvqn/alNBc+f7ZouPxfgamEWE7ykPZN4WzswRIFC E3EX464KJ5LA5RAQXooeWndOrYNoYx8gug4gQNy5nVFrkdIqlP9kPlkWbC1vzAGpO7yW 2CMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=tBRYuZriPXQUXBu/QTN08SlWn7ePBFFTpukjNr+bCwg=; b=kiXxgmt60ZDxpz7Jts2RAO7xXSf+wtB4nYajBcv3QKQU+SlaPIChQIL+k0bwVbECuj FeAln1V80HQtcfwL9AWm9N4Q/dJ16+yruz3svgsRZtuhnZJN87OqX83TfRJsl9r5tF2H tNpk+0RpEjqySl2kKDa2g0uhdsYkLee3o4HzRDzCgjMjzifjHVN1gehDzSC0MwToi/NA vcdJLp0IlFctlnHgIQZlrmdZ46wLQqcuJgCbsEiKjk29lVv2R0z45x1eaazeorFVZk4N nMHsmTClxOd9kFWc5WWAX70AkSLu00FdVv2VdRQQkZelsHVL9IpN1Vts36dsb1BGgtZd 6E7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=xzqEv2yP; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=65juJAIL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h6-20020a0564020e0600b00435651c4a02si728527edh.493.2022.06.17.03.05.44; Fri, 17 Jun 2022 03:06:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=xzqEv2yP; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=65juJAIL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381250AbiFQJsn (ORCPT + 99 others); Fri, 17 Jun 2022 05:48:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1381458AbiFQJsm (ORCPT ); Fri, 17 Jun 2022 05:48:42 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F5406970A; Fri, 17 Jun 2022 02:48:40 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C46411F8F0; Fri, 17 Jun 2022 09:48:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1655459318; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tBRYuZriPXQUXBu/QTN08SlWn7ePBFFTpukjNr+bCwg=; b=xzqEv2yP28ye8lDXCCfLZWDcafj9XrD1X2CCACIO+QbXIj7EvEl1SnHEDaeeompDvdJSt/ CERpE3v22+kMj8Kgs1OU1//4D8i2ZKOUFC+Y3LwivArhMBTrpy6wlMTjRWlWhGHo/GKlgE DskYf0aIrF/TGgnpim38UDjf8MtIl0s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1655459318; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tBRYuZriPXQUXBu/QTN08SlWn7ePBFFTpukjNr+bCwg=; b=65juJAIL7Ubircvln21ZYXzi/26mcJv9KTmM4uVmpChAel/X3rOsLJGBzs1PDnXDZ37oeU AshWbqj5sXIMyBDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 279701348E; Fri, 17 Jun 2022 09:48:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9+bfBvZNrGJJOQAAMHmgww (envelope-from ); Fri, 17 Jun 2022 09:48:38 +0000 Date: Fri, 17 Jun 2022 11:48:36 +0200 From: Oscar Salvador To: Muchun Song Cc: David Hildenbrand , corbet@lwn.net, akpm@linux-foundation.org, paulmck@kernel.org, mike.kravetz@oracle.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, smuchun@gmail.com Subject: Re: [PATCH v2 2/2] mm: memory_hotplug: introduce SECTION_CANNOT_OPTIMIZE_VMEMMAP Message-ID: References: <20220520025538.21144-1-songmuchun@bytedance.com> <20220520025538.21144-3-songmuchun@bytedance.com> <53024884-0182-df5f-9ca2-00652c64ce36@redhat.com> <24d5ec20-9c9e-93aa-11f4-c4619f51f7d1@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 17, 2022 at 03:28:10PM +0800, Muchun Song wrote: > I think here needs a loop if it is a 1GB page (spans multiple sections). > Right? Here is an implementation based on another approach. But I think > your implementation is more simpler and efficient. Would you mind me > squash your diff into my patch and with your "Co-developed-by"? Sure, fine by me. -- Oscar Salvador SUSE Labs