Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 17 Jun 2022 11:28:14 +0200
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Joel Stanley <joel@jms.id.au>,
        Paul Menzel <pmenzel@molgen.mpg.de>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Lubomir Rintel <lkundrak@v3.sk>,
        Robert Jarzmik <robert.jarzmik@free.fr>,
        Hector Martin <marcan@marcan.st>,
        Conor Dooley <conor.dooley@microchip.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Sven Peter <sven@svenpeter.dev>,
        Heiko Stuebner <heiko@sntech.de>,
        Brian Norris <briannorris@chromium.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] soc: nuvoton: Add SoC info driver for WPCM450
Message-ID: <YqxJLhkCQ2WcHdAp@latitude>
References: <20220609213513.88479-1-j.neuschaefer@gmx.net>
 <CAK8P3a0-m1iQ2bP+dsoGTPZGMNBKqB5a6315jdgaT3tuR4WfTw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="jKjRAf+U0chs2ccJ"
Content-Disposition: inline
In-Reply-To: <CAK8P3a0-m1iQ2bP+dsoGTPZGMNBKqB5a6315jdgaT3tuR4WfTw@mail.gmail.com>
Precedence: bulk


--jKjRAf+U0chs2ccJ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 15, 2022 at 04:00:17PM +0200, Arnd Bergmann wrote:
> On Thu, Jun 9, 2022 at 11:35 PM Jonathan Neusch=C3=A4fer
> <j.neuschaefer@gmx.net> wrote:
> >
> > Add a SoC information driver for Nuvoton WPCM450 SoCs. It provides
> > information such as the SoC revision.
> >
> > Usage example:
> >
> >   # grep . /sys/devices/soc0/*
> >   /sys/devices/soc0/family:Nuvoton NPCM
> >   /sys/devices/soc0/revision:A3
> >   /sys/devices/soc0/soc_id:WPCM450
> >
> > Signed-off-by: Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net>
> > Reviewed-by: Joel Stanley <joel@jms.id.au>
> > Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
>=20
> Looks good overall.
>=20
> > +menuconfig WPCM450_SOC
> > +       bool "Nuvoton WPCM450 SoC driver"
> > +       default y if ARCH_WPCM450
>=20
> It would be nice to make this a tristate option, as we generally
> like to keep optional drivers out of the allmodconfig vmlinux file,
> even if this is a tiny one.

Ok.

> Just add the trivial cleanup function and MODULE_LICENSE() etc tags.

The right thing to do seems to be to unregister the SoC device in the
cleanup function. Is that what you mean?


Jonathan

--jKjRAf+U0chs2ccJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmKsSQoACgkQCDBEmo7z
X9v7ag//ULZktidbg2z7RnwVy6ePYuuYsXSdl2wtC3kdzVwdJwgt+0M/BezrQ1/6
lHXqtAcjtyaRtAJ5yw8fRtCEx9zdz1jL0bdgFA6CxcaHPP9Nr9NHTOSWNevFIg4w
7lj6RvlbkLie8799JAmgZDVQBzsMByQaZueA2dXcFddaANmqGTQP0RdKu2SqF1eR
IJEq78QnqjguDz+wLrnqcU4j+WWVTmZw6VCUImmQvur1X9wmJ9CvikZt0GCMhmw/
7QjTpAMGrGl/iN+b9OZrdtytbHj+YsNBlZGuTFoPLtN6hItyxb1ISLaiEKRVCVtQ
egswr9lXGrMqwK9A7435DdcmrWoYdQ/7VlbXSVwbDYNsPjZRbAy7rGsWXOsiM1fA
RPbYmoxxi2ZrLeINT900xtXHovtRM4ICWbj5uJPdLJu/IJNvRfYmYlJKisnr+xU1
RGp+97USsPZTn3pnqEKH7nAkLV3zO7LPXWsaDRAvhn1a9E5KTrKhg/yqWj6RTMOJ
trsl9UB8kKeekcP8Z3/DAjF9g8H7dR5pnpmLXSRMVBH3L08P22Ot8S8BTmELpt+F
yAZenVbFBhnVQ3huJTd6QTzAvW+q3DxCR+1eE+PYJzghYfcae1jDl8hm9zFfbn3d
rw0B0QUEf9m3aXP+lZlOrZfNKEgpQWG4napZVoPxvGtlkUV6u9M=
=8EJF
-----END PGP SIGNATURE-----

--jKjRAf+U0chs2ccJ--