Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp305075iog; Fri, 17 Jun 2022 04:05:40 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sEk08Z591XYlEpt3KwcX+lq6JHNeSrSelZLwfSTF59+CCdA2c5bDrqz5/nLsfvVOfnANNo X-Received: by 2002:a17:903:25c1:b0:164:1517:e8c3 with SMTP id jc1-20020a17090325c100b001641517e8c3mr9072893plb.116.1655463939862; Fri, 17 Jun 2022 04:05:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655463939; cv=none; d=google.com; s=arc-20160816; b=Xi/2SPnRlwib5MGJRY/x57dEZKRhsW5K1wbnf3H7m7ld7xSB3RDUh5cdZv7E8IHO0r 2qKQKBIFQiEu0mX6F5J+94aH6ezBk0vcZf9kf29FxAY7fvH/8mgFsihmb7DQVyBjHA03 z3pphYpiuvwkWcNzuISguDN4wDXBAFUrVXdA7dspffJYbEQN+vZRs14kAWQpaP2TNMl2 kWgWjEEZ0AmoEr3APhx77bKuMKpuZQ/uUnXcIVESFTV+3x7c0Tm3D9oh/9k5U+0osSUQ YEdSkB5HmZyTqdiePGh5BLG5Qv0DzfsQ4wCKvSEDX/qJsL6YGv9Dhg3aCaEivU92u5yv tKYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=FyWzdfVky9uAv9Eg8U1j67Ir5Jy3T29WrrSU3S19oyA=; b=VBlra7fROS1fqD/I/7JXc9qOGrLTYURswo0CrxclMz1Pkiuq4OoxEayUbLyk8nXyOC dyL2aZFbqOXObJK0UVYUeruKXxhj5lzwMha4C9eeNVjTPwo641CuqNm4wiQJvVQRKgHL 4hOyyGcfl7OZH1vd4ou4fd0d3XxwsjzavcRo7k6vh200zbkmldxG8h6cRGiYmKT54b9c AtgpruwBz7cVN/uSFcf8o86UQyzWHmbb7fQMkk+OcL65BkEkxlYQqQOxeKOCHDOq+e7m juYY0dd1Uux7ZHdqJCmEwDqUF1I0tBJOAlAmx8kHvElk1UntAH7W12SYZG7XE+BLxET8 yNug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v10-20020a63610a000000b0040c662ac0e9si168557pgb.572.2022.06.17.04.05.05; Fri, 17 Jun 2022 04:05:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382250AbiFQKqG (ORCPT + 99 others); Fri, 17 Jun 2022 06:46:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1382151AbiFQKpk (ORCPT ); Fri, 17 Jun 2022 06:45:40 -0400 Received: from inva020.nxp.com (inva020.nxp.com [92.121.34.13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E15786B7EE; Fri, 17 Jun 2022 03:45:32 -0700 (PDT) Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 7E82F1A0052; Fri, 17 Jun 2022 12:45:31 +0200 (CEST) Received: from aprdc01srsp001v.ap-rdc01.nxp.com (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 466491A00AC; Fri, 17 Jun 2022 12:45:31 +0200 (CEST) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id 9EB3B180219B; Fri, 17 Jun 2022 18:45:29 +0800 (+08) From: Richard Zhu To: l.stach@pengutronix.de, bhelgaas@google.com, robh+dt@kernel.org, broonie@kernel.org, lorenzo.pieralisi@arm.com, festevam@gmail.com, francesco.dolcini@toradex.com Cc: hongxing.zhu@nxp.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: [PATCH v13 15/15] PCI: imx6: Disable clocks in reverse order of enable Date: Fri, 17 Jun 2022 18:31:14 +0800 Message-Id: <1655461874-16908-16-git-send-email-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1655461874-16908-1-git-send-email-hongxing.zhu@nxp.com> References: <1655461874-16908-1-git-send-email-hongxing.zhu@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjorn Helgaas imx6_pcie_clk_enable() enables clocks in the order: pcie_phy pcie_bus pcie imx6_pcie_enable_ref_clk Change imx6_pcie_clk_disable() to disable them in the reverse order. Signed-off-by: Bjorn Helgaas Acked-by: Richard Zhu --- drivers/pci/controller/dwc/pci-imx6.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 363bfc4742cf..94ce77b674a3 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -655,10 +655,10 @@ static int imx6_pcie_clk_enable(struct imx6_pcie *imx6_pcie) static void imx6_pcie_clk_disable(struct imx6_pcie *imx6_pcie) { + imx6_pcie_disable_ref_clk(imx6_pcie); clk_disable_unprepare(imx6_pcie->pcie); - clk_disable_unprepare(imx6_pcie->pcie_phy); clk_disable_unprepare(imx6_pcie->pcie_bus); - imx6_pcie_disable_ref_clk(imx6_pcie); + clk_disable_unprepare(imx6_pcie->pcie_phy); } static void imx6_pcie_assert_core_reset(struct imx6_pcie *imx6_pcie) -- 2.25.1