Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9f36c019-dff7-7fa8-b8c8-ed118cef716e@gmail.com>
Date:   Fri, 17 Jun 2022 12:26:34 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 5/7] soc: mediatek: mt8365-mmsys: add DPI/HDMI display
 path
Content-Language: en-US
To:     CK Hu <ck.hu@mediatek.com>, Fabien Parent <fparent@baylibre.com>,
        jitao.shi@mediatek.com, krzysztof.kozlowski+dt@linaro.org,
        robh+dt@kernel.org
Cc:     chunkuang.hu@kernel.org, p.zabel@pengutronix.de, airlied@linux.ie,
        daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
        linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
References: <20220530201436.902505-1-fparent@baylibre.com>
 <20220530201436.902505-5-fparent@baylibre.com>
 <3b5e4d1e3b8dd8593c4a0cf0edbb0cee4538fa8e.camel@mediatek.com>
From:   Matthias Brugger <matthias.bgg@gmail.com>
In-Reply-To: <3b5e4d1e3b8dd8593c4a0cf0edbb0cee4538fa8e.camel@mediatek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 17/06/2022 07:53, CK Hu wrote:
> Hi, Fabien:
> 
> On Mon, 2022-05-30 at 22:14 +0200, Fabien Parent wrote:
>> Right now only the DSI path connections are described in the mt8365
>> mmsys driver. The external path will be DPI/HDMI. This commit adds
>> the connections for DPI/HDMI.
> 
> Reviewed-by: CK Hu <ck.hu@mediatek.com>
> 


Applied, thanks!

>>
>> Signed-off-by: Fabien Parent <fparent@baylibre.com>
>> ---
>>   drivers/soc/mediatek/mt8365-mmsys.h | 22 ++++++++++++++++++++++
>>   1 file changed, 22 insertions(+)
>>
>> diff --git a/drivers/soc/mediatek/mt8365-mmsys.h
>> b/drivers/soc/mediatek/mt8365-mmsys.h
>> index 24129a6c25f8..7abaf048d91e 100644
>> --- a/drivers/soc/mediatek/mt8365-mmsys.h
>> +++ b/drivers/soc/mediatek/mt8365-mmsys.h
>> @@ -10,6 +10,9 @@
>>   #define MT8365_DISP_REG_CONFIG_DISP_RDMA0_RSZ0_SEL_IN	0xf60
>>   #define MT8365_DISP_REG_CONFIG_DISP_COLOR0_SEL_IN	0xf64
>>   #define MT8365_DISP_REG_CONFIG_DISP_DSI0_SEL_IN		0xf68
>> +#define MT8365_DISP_REG_CONFIG_DISP_RDMA1_SOUT_SEL	0xfd0
>> +#define MT8365_DISP_REG_CONFIG_DISP_DPI0_SEL_IN		0xfd8
>> +#define MT8365_DISP_REG_CONFIG_DISP_LVDS_SYS_CFG_00	0xfdc
>>   
>>   #define MT8365_RDMA0_SOUT_COLOR0			0x1
>>   #define MT8365_DITHER_MOUT_EN_DSI0			0x1
>> @@ -18,6 +21,10 @@
>>   #define MT8365_RDMA0_RSZ0_SEL_IN_RDMA0			0x0
>>   #define MT8365_DISP_COLOR_SEL_IN_COLOR0			0x0
>>   #define MT8365_OVL0_MOUT_PATH0_SEL			BIT(0)
>> +#define MT8365_RDMA1_SOUT_DPI0				0x1
>> +#define MT8365_DPI0_SEL_IN_RDMA1			0x0
>> +#define MT8365_LVDS_SYS_CFG_00_SEL_LVDS_PXL_CLK		0x1
>> +#define MT8365_DPI0_SEL_IN_RDMA1			0x0
>>   
>>   static const struct mtk_mmsys_routes mt8365_mmsys_routing_table[] =
>> {
>>   	{
>> @@ -55,6 +62,21 @@ static const struct mtk_mmsys_routes
>> mt8365_mmsys_routing_table[] = {
>>   		MT8365_DISP_REG_CONFIG_DISP_RDMA0_RSZ0_SEL_IN,
>>   		MT8365_RDMA0_RSZ0_SEL_IN_RDMA0,
>> MT8365_RDMA0_RSZ0_SEL_IN_RDMA0
>>   	},
>> +	{
>> +		DDP_COMPONENT_RDMA1, DDP_COMPONENT_DPI0,
>> +		MT8365_DISP_REG_CONFIG_DISP_LVDS_SYS_CFG_00,
>> +		MT8365_LVDS_SYS_CFG_00_SEL_LVDS_PXL_CLK,
>> MT8365_LVDS_SYS_CFG_00_SEL_LVDS_PXL_CLK
>> +	},
>> +	{
>> +		DDP_COMPONENT_RDMA1, DDP_COMPONENT_DPI0,
>> +		MT8365_DISP_REG_CONFIG_DISP_DPI0_SEL_IN,
>> +		MT8365_DPI0_SEL_IN_RDMA1, MT8365_DPI0_SEL_IN_RDMA1
>> +	},
>> +	{
>> +		DDP_COMPONENT_RDMA1, DDP_COMPONENT_DPI0,
>> +		MT8365_DISP_REG_CONFIG_DISP_RDMA1_SOUT_SEL,
>> +		MT8365_RDMA1_SOUT_DPI0, MT8365_RDMA1_SOUT_DPI0
>> +	},
>>   };
>>   
>>   #endif /* __SOC_MEDIATEK_MT8365_MMSYS_H */
>