Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220613111146.25221-1-peterwu.pub@gmail.com> <20220613111146.25221-7-peterwu.pub@gmail.com>
 <1655127197.567546.3564136.nullmailer@robh.at.kernel.org>
In-Reply-To: <1655127197.567546.3564136.nullmailer@robh.at.kernel.org>
From:   ChiaEn Wu <peterwu.pub@gmail.com>
Date:   Fri, 17 Jun 2022 19:15:49 +0800
Message-ID: <CABtFH5JPu5tOg4wGJf5ay1-NJHLcPTK4XxADGTksHW1-6wjMRQ@mail.gmail.com>
Subject: Re: [PATCH v2 06/15] dt-bindings: mfd: Add Mediatek MT6370
To:     Rob Herring <robh@kernel.org>
Cc:     pavel@ucw.cz, robh+dt@kernel.org, linux-pm@vger.kernel.org,
        dri-devel@lists.freedesktop.org, krzysztof.kozlowski+dt@linaro.org,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        linux-mediatek@lists.infradead.org, szunichen@gmail.com,
        lars@metafoo.de, matthias.bgg@gmail.com,
        Daniel Thompson <daniel.thompson@linaro.org>,
        lee.jones@linaro.org, ChiYuan Huang <cy_huang@richtek.com>,
        linux-leds@vger.kernel.org, linux-fbdev@vger.kernel.org,
        jingoohan1@gmail.com, devicetree@vger.kernel.org, jic23@kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Rob,

Rob Herring <robh@kernel.org> =E6=96=BC 2022=E5=B9=B46=E6=9C=8813=E6=97=A5 =
=E9=80=B1=E4=B8=80 =E6=99=9A=E4=B8=8A9:33=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On Mon, 13 Jun 2022 19:11:37 +0800, ChiaEn Wu wrote:
> > From: ChiYuan Huang <cy_huang@richtek.com>
> >
> > Add Mediatek MT6370 binding documentation.
> >
> > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > ---
> >  .../bindings/mfd/mediatek,mt6370.yaml         | 279 ++++++++++++++++++
> >  .../dt-bindings/iio/adc/mediatek,mt6370_adc.h |  18 ++
> >  2 files changed, 297 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mt63=
70.yaml
> >  create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6370_adc.h
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=3D-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> ./Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml: Unable to f=
ind schema file matching $id: http://devicetree.org/schemas/leds/backlight/=
mediatek,mt6370-backlight.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/=
mediatek,mt6370.example.dtb: pmic@34: backlight: False schema does not allo=
w {'compatible': ['mediatek,mt6370-backlight'], 'mediatek,bled-channel-use'=
: b'\x0f'}
>         From schema: /builds/robherring/linux-dt-review/Documentation/dev=
icetree/bindings/mfd/mediatek,mt6370.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/=
mediatek,mt6370.example.dtb: pmic@34: charger: False schema does not allow =
{'compatible': ['mediatek,mt6370-charger'], 'interrupts': [[48], [68], [6]]=
, 'interrupt-names': ['attach_i', 'uvp_d_evt', 'mivr'], 'io-channels': [[1,=
 5]], 'usb-otg-vbus-regulator': {'regulator-name': ['mt6370-usb-otg-vbus'],=
 'regulator-min-microvolt': [[4350000]], 'regulator-max-microvolt': [[58000=
00]], 'regulator-min-microamp': [[500000]], 'regulator-max-microamp': [[300=
0000]], 'phandle': [[2]]}}
>         From schema: /builds/robherring/linux-dt-review/Documentation/dev=
icetree/bindings/mfd/mediatek,mt6370.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/=
mediatek,mt6370.example.dtb: pmic@34: tcpc: False schema does not allow {'c=
ompatible': ['mediatek,mt6370-tcpc'], 'interrupts-extended': [[4294967295, =
4, 8]], 'connector': {'compatible': ['usb-c-connector'], 'label': ['USB-C']=
, 'vbus-supply': [[2]], 'data-role': ['dual'], 'power-role': ['dual'], 'try=
-power-role': ['sink'], 'source-pdos': [[570527844]], 'sink-pdos': [[570527=
944]], 'op-sink-microwatt': [[10000000]], 'ports': {'#address-cells': [[1]]=
, '#size-cells': [[0]], 'port@0': {'reg': [[0]], 'endpoint': {'remote-endpo=
int': [[4294967295]]}}, 'port@1': {'reg': [[1]], 'endpoint': {'remote-endpo=
int': [[4294967295]]}}, 'port@2': {'reg': [[2]], 'endpoint': {'remote-endpo=
int': [[4294967295]]}}}}}
>         From schema: /builds/robherring/linux-dt-review/Documentation/dev=
icetree/bindings/mfd/mediatek,mt6370.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/=
mediatek,mt6370.example.dtb: pmic@34: indicator: False schema does not allo=
w {'compatible': ['mediatek,mt6370-indicator'], '#address-cells': [[1]], '#=
size-cells': [[0]], 'multi-led@0': {'reg': [[0]], 'function': ['indicator']=
, 'color': [[9]], 'led-max-microamp': [[24000]], '#address-cells': [[1]], '=
#size-cells': [[0]], 'led@0': {'reg': [[0]], 'color': [[1]]}, 'led@1': {'re=
g': [[1]], 'color': [[2]]}, 'led@2': {'reg': [[2]], 'color': [[3]]}}, 'led@=
3': {'reg': [[3]], 'function': ['indicator'], 'color': [[0]], 'led-max-micr=
oamp': [[6000]]}}
>         From schema: /builds/robherring/linux-dt-review/Documentation/dev=
icetree/bindings/mfd/mediatek,mt6370.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/=
mediatek,mt6370.example.dtb: pmic@34: flashlight: False schema does not all=
ow {'compatible': ['mediatek,mt6370-flashlight'], '#address-cells': [[1]], =
'#size-cells': [[0]], 'led@0': {'reg': [[0]], 'led-sources': [[0]], 'functi=
on': ['flash'], 'color': [[0]], 'function-enumerator': [[1]], 'led-max-micr=
oamp': [[200000]], 'flash-max-microamp': [[500000]], 'flash-max-timeout-us'=
: [[1248000]]}, 'led@1': {'reg': [[1]], 'led-sources': [[1]], 'function': [=
'flash'], 'color': [[0]], 'function-enumerator': [[2]], 'led-max-microamp':=
 [[200000]], 'flash-max-microamp': [[500000]], 'flash-max-timeout-us': [[12=
48000]]}}
>         From schema: /builds/robherring/linux-dt-review/Documentation/dev=
icetree/bindings/mfd/mediatek,mt6370.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/=
mediatek,mt6370.example.dtb: backlight: mediatek,bled-channel-use: b'\x0f' =
is not of type 'object', 'array', 'boolean', 'null'
>         From schema: /usr/local/lib/python3.10/dist-packages/dtschema/sch=
emas/dt-core.yaml
> Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb:0:0: /e=
xample-0/i2c/pmic@34/backlight: failed to match any schema with compatible:=
 ['mediatek,mt6370-backlight']
> Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb:0:0: /e=
xample-0/i2c/pmic@34/charger: failed to match any schema with compatible: [=
'mediatek,mt6370-charger']
> Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb:0:0: /e=
xample-0/i2c/pmic@34/indicator: failed to match any schema with compatible:=
 ['mediatek,mt6370-indicator']
> Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb:0:0: /e=
xample-0/i2c/pmic@34/flashlight: failed to match any schema with compatible=
: ['mediatek,mt6370-flashlight']
> Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb:0:0: /e=
xample-0/i2c/pmic@34/tcpc: failed to match any schema with compatible: ['me=
diatek,mt6370-tcpc']
>

Before we submitted these patches, we had already checked by running
this command below,
"make DT_CHECKER_FLAGS=3D-m dt_binding_check
DT_SCHEMA_FILES=3DDocumentation/devicetree/bindings/mfd/mediatek,mt6370.yam=
l".
But we could not find any errors like your error msg after the checking pro=
cess.

Our mfd dt-binding patch is dependent on "backlight dt-binding",
"charger dt-binding", "tcpc dt-binding", "indicator dt-binding" and
"flashlight dt-binding" patches.
Would you please apply them before you check mfd dt-binding patch?
Thank you so much!

> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/patch/
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>

Best regards,
ChiaEn Wu