Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp357886iog; Fri, 17 Jun 2022 05:02:46 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sv3iE1h6+821JZugn651X/F3VYn5ZngXEEWIIlCsiAYUVC7P9lAuDYGIeKbY4NztnuzRCB X-Received: by 2002:a63:5c26:0:b0:405:2650:d202 with SMTP id q38-20020a635c26000000b004052650d202mr8926311pgb.276.1655467366565; Fri, 17 Jun 2022 05:02:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655467366; cv=none; d=google.com; s=arc-20160816; b=PiBdG4Qwg9P8zThhtySs5JXntGw4Hrs7/wI6KXl/rroXri2n6wPyN6WweqtautZmmC u195qySw1j1du8y/jUesjl9yjpCZPT0dZ1VSxUFnarSYhIwi8nXjQtVLwmi5GlGiQrGv uIsL8PYzg0lpuP6fEKXtP33AWAjszz/NHt6YnIsMUsBJKSnljrD1SzzbYbKr6fMutY7Q 48DDpMISJ2YVpZZMGhnZWzjUcD73wWb0gQx9mHAT7unFRDQEmc2ii+Ml5XXtb8gKXFp3 U0lpTlUINCxFg1fAVCJ+SXtc+/Jij7Ns9fE0nQZ6yEM9YI+MAMSb0aPytdR2bJp5Q/lC Lw7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=O/gfjiM+/dFXgLyDX8wONUfp/rIAwYsakkpB/GaAurk=; b=mHYb+DYqDC50ElY9oWlldQu7TyvGitcQtEzOQQta+olyR1QEf/s89ceZbqKHdyLNNL j50t7M9Mn+jr0XPTMk93bxILpPtfJnr27l9CJa2RGBAvLLx7NCEK2n6V6TqyRQ7oUHJw /J30EwvA5/YG5oq5gS4QBTl6l/tDbQYD6VxsG4ZJW2PdJibltVXgMASWjF/0DpmT429F 1kKkP4+mQbBGCvM4Fx91WroEWmN3xKKkE8YvZi8sEaJGs09Z4SY14CJPbJ7se19Kjt2e rGaaqWQUU0gojBz++TShM4JkPsPb++zWX6uAzr4/J9ir+wYqVAzVtBf/l74aHt/0uRyu tQSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@126.com header.s=s110527 header.b=Vr3o8xii; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=126.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u33-20020a634721000000b00401baa6d6a9si5437493pga.677.2022.06.17.05.02.26; Fri, 17 Jun 2022 05:02:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@126.com header.s=s110527 header.b=Vr3o8xii; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=126.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380358AbiFQL3O (ORCPT + 99 others); Fri, 17 Jun 2022 07:29:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235810AbiFQL3L (ORCPT ); Fri, 17 Jun 2022 07:29:11 -0400 Received: from m15114.mail.126.com (m15114.mail.126.com [220.181.15.114]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 315036CA81 for ; Fri, 17 Jun 2022 04:29:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=O/gfj iM+/dFXgLyDX8wONUfp/rIAwYsakkpB/GaAurk=; b=Vr3o8xiieKrrrlgnddW/w s9lxmQXAdM8azHPs8X4zP73tsYyzzomAKFUaoodb8Koskz0K52ppxEOXFj7WjG3s gj/Bmh67ql+61IR+ujsnV7CXfostj9RwIDUyOm4NdpUn7UlVV80Y1PAnLYLzxZV2 PVenFWunVvRjV+M2z4PweA= Received: from localhost.localdomain (unknown [124.16.139.61]) by smtp7 (Coremail) with SMTP id DsmowACn5_bsZKximyZLDg--.20485S2; Fri, 17 Jun 2022 19:26:38 +0800 (CST) From: Liang He To: mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, akpm@linux-foundation.org, rppt@kernel.org, christophe.leroy@csgroup.eu, wangkefeng.wang@huawei.com, gpiccoli@igalia.com, aneesh.kumar@linux.ibm.com, dmitry.osipenko@collabora.com Cc: windhl@126.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] powerpc: kernel: Change the order of of_node_put() Date: Fri, 17 Jun 2022 19:26:36 +0800 Message-Id: <20220617112636.4041671-1-windhl@126.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: DsmowACn5_bsZKximyZLDg--.20485S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7GF48Jw1UWw1UAFWUur1fXrb_yoWxKrX_t3 yxX3ZI9r4vyrsa9rsrAF4fXr1Dtw4kXr1Fk3Wv9w47t3Z8Xw4UAr98Z3WkJr9xuryUt39F 934Dtws8tF40vjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRM-eo7UUUUU== X-Originating-IP: [124.16.139.61] X-CM-SenderInfo: hzlqvxbo6rjloofrz/1tbi3A4jF1pEDvX86gAAsV X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In add_pcspkr(), it is better to call of_node_put() after the 'if(!np)' check. Signed-off-by: Liang He --- arch/powerpc/kernel/setup-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c index eb0077b302e2..761817d1f4db 100644 --- a/arch/powerpc/kernel/setup-common.c +++ b/arch/powerpc/kernel/setup-common.c @@ -563,9 +563,9 @@ static __init int add_pcspkr(void) int ret; np = of_find_compatible_node(NULL, NULL, "pnpPNP,100"); - of_node_put(np); if (!np) return -ENODEV; + of_node_put(np); pd = platform_device_alloc("pcspkr", -1); if (!pd) -- 2.25.1