Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2730b855-8f99-5a9e-707e-697d3bd9811d@redhat.com>
Date:   Fri, 17 Jun 2022 11:00:27 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] locking/rwlocks: do not starve writers
Content-Language: en-US
To:     Shakeel Butt <shakeelb@google.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Eric Dumazet <eric.dumazet@gmail.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Ingo Molnar <mingo@redhat.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        Will Deacon <will@kernel.org>, Roman Penyaev <rpenyaev@suse.de>
References: <20220617091039.2257083-1-eric.dumazet@gmail.com>
 <YqxufxqsnHjVfQOs@worktop.programming.kicks-ass.net>
 <2dd754f9-3a79-ed17-e423-6b411c3afb69@redhat.com>
 <CALvZod5ijDz=coEE8G8v_haPaKuUa5jHYzEwKvLVxHGphixsFA@mail.gmail.com>
From:   Waiman Long <longman@redhat.com>
In-Reply-To: <CALvZod5ijDz=coEE8G8v_haPaKuUa5jHYzEwKvLVxHGphixsFA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/17/22 10:57, Shakeel Butt wrote:
> On Fri, Jun 17, 2022 at 7:43 AM Waiman Long <longman@redhat.com> wrote:
>> On 6/17/22 08:07, Peter Zijlstra wrote:
>>> On Fri, Jun 17, 2022 at 02:10:39AM -0700, Eric Dumazet wrote:
>>>> --- a/kernel/locking/qrwlock.c
>>>> +++ b/kernel/locking/qrwlock.c
>>>> @@ -23,16 +23,6 @@ void queued_read_lock_slowpath(struct qrwlock *lock)
>>>>       /*
>>>>        * Readers come here when they cannot get the lock without waiting
>>>>        */
>>>> -    if (unlikely(in_interrupt())) {
>>>> -            /*
>>>> -             * Readers in interrupt context will get the lock immediately
>>>> -             * if the writer is just waiting (not holding the lock yet),
>>>> -             * so spin with ACQUIRE semantics until the lock is available
>>>> -             * without waiting in the queue.
>>>> -             */
>>>> -            atomic_cond_read_acquire(&lock->cnts, !(VAL & _QW_LOCKED));
>>>> -            return;
>>>> -    }
>>>>       atomic_sub(_QR_BIAS, &lock->cnts);
>>>>
>>>>       trace_contention_begin(lock, LCB_F_SPIN | LCB_F_READ);
>>> This is known to break tasklist_lock.
>>>
>> We certainly can't break the current usage of tasklist_lock.
>>
>> I am aware of this problem with networking code and is thinking about
>> either relaxing the check to exclude softirq or provide a
>> read_lock_unfair() variant for networking use.
> read_lock_unfair() for networking use or tasklist_lock use?

I mean to say read_lock_fair(), but it could also be the other way 
around. Thanks for spotting that.

Cheers,
Longman