Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 17 Jun 2022 08:02:27 -0700
From:   Matt Ranostay <mranostay@ti.com>
To:     Marc Zyngier <maz@kernel.org>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Robin Murphy <robin.murphy@arm.com>, Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-j721s2: fix overlapping GICD
 memory region
Message-ID: <YqyXg2//cglzV7eF@ubuntu>
References: <20220617140207.444298-1-mranostay@ti.com>
 <87tu8j2x9u.wl-maz@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <87tu8j2x9u.wl-maz@kernel.org>
Precedence: bulk

On Fri, Jun 17, 2022 at 03:13:33PM +0100, Marc Zyngier wrote:
> On Fri, 17 Jun 2022 15:02:07 +0100,
> Matt Ranostay <mranostay@ti.com> wrote:
> > 
> > GICD region was overlapping with GICR causing the latter to not map
> > successfully, and in turn the gic-v3 driver would fail to initialize.
> > 
> > This issue was hidden till commit 2b2cd74a06c3 ("irqchip/gic-v3: Claim iomem resources")
> > replaced of_iomap() calls with of_io_request_and_map() that internally
> > called request_mem_region().
> 
> Please correctly wrap long lines in the commit message.
> 
> > 
> > Respective console output before this patchset:
> > 
> > [    0.000000] GICv3: /bus@100000/interrupt-controller@1800000: couldn't map region 0
> > 
> > Fixes: 2b2cd74a06c3 ("irqchip/gic-v3: Claim iomem resources")
> 
> No, that's the wrong target for this. Your patch fixes the *original*
> submission of the DT, and this should carry a:
> 
> Fixes: b8545f9d3a54 ("arm64: dts: ti: Add initial support for J721S2 SoC")
>

Ah right. Not sure I was thinking there.. will fix in v3.

- Matt


> Please also consider adding a
> 
> Cc: stable@vger.kernel.org
> 
> Thanks,
> 
> 	M.
> 
> -- 
> Without deviation from the norm, progress is not possible.