Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ed0379a0-1360-4271-16bd-cde2e4b3372b@amd.com>
Date:   Fri, 17 Jun 2022 11:06:05 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v2] HID: usbhid: set mouse as a wakeup resource
Content-Language: en-US
To:     David Laight <David.Laight@ACULAB.COM>,
        'Alan Stern' <stern@rowland.harvard.edu>,
        Greg KH <gregkh@linuxfoundation.org>
Cc:     Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        "open list:USB HID/HIDBP DRIVERS [USB KEYBOARDS, MICE, REM..." 
        <linux-usb@vger.kernel.org>,
        "open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Richard Gong <richard.gong@amd.com>
References: <20220616183142.14472-1-mario.limonciello@amd.com>
 <YqugZQiDu35Y8lTu@kroah.com> <YqyYIt2MLmoCRSA9@rowland.harvard.edu>
 <419f8edc2a7744ecbfaa0728227db180@AcuMS.aculab.com>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <419f8edc2a7744ecbfaa0728227db180@AcuMS.aculab.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZyszYUJiaGpBVTVNVjVDNUczUlhCNmhxWWxOVmJ4YnJBWkRUVDh3bjFTczhp?=
 =?utf-8?B?REl6TlFjNzB0VVpWSXEvNC9uQVNiakFrY2VDNEdjYjhvdStCL2dPMFFBUjJU?=
 =?utf-8?B?MFhUMTB4T0FRY2pKOWZ2NEJKNkF5YnFFSW0yYjhoZnZhcWlUa2g2ZWt6UEth?=
 =?utf-8?B?aXVaR3BkazFGdFpNM25NZkI4eFBPMVMzdktUUlIrTFZvbTdVSjZlYVpjbkdm?=
 =?utf-8?B?ZFd2elY5NDNGbWZHUUk2bktjNEw2L3FyTmY2bU5ZaHpMOSsrSUJWcnhiR2dK?=
 =?utf-8?B?NTNOVmVGdk1JQ1lZUXBvTGVKOXp2NXl0RmxsWmpLVFJrZWR3SGE5Mk9kY1A4?=
 =?utf-8?B?NlNKY054MnNBbzlpVjNyT3l6N0RxbTdaby96OWVxVS9GSk5TMjdMT3MxbllW?=
 =?utf-8?B?QTdxa3FGQ3ZudW5hbHdzb2NyT3AzbXZnRXVtVnVxSkVmTWZUOVdtWDkveCtL?=
 =?utf-8?B?bzFtd2ZyRmVWS0R0WEJsSmRjSkRJZWV0QkNCd0pZME5kWisyWTBka3oxRTA5?=
 =?utf-8?B?Yld1My9QdEhSSldzb3BBWEV5L2lZVnR6Uk4ySzdSNysrMHRLNW90UVc1SUN1?=
 =?utf-8?B?TWdjTlRIYkVwWThzdTRlSXlpbUhnMmMvaC9mbHp2elBKOGRGdWV4VjFQMFNu?=
 =?utf-8?B?eDJqayticFFsV0pSMEIxNHAwR3lNZVlYa0ljRURyMlZkc3BOTEY5Zm5pSHhN?=
 =?utf-8?B?OFRFZWpJbEdDeGx3R3RWb0g4L0YrbFdPUzNwK0lORVg4TTBFZG9uK3huRVVx?=
 =?utf-8?B?ZSt3OHdxSCsxc0VhZW0zSlhPdnVHL0lMTXlEUkYrM2hHZ2RwYmlOd0tGckNu?=
 =?utf-8?B?V1Y5NGZtTjY3RnExcmw4MU9STVJxRXR2Q1cyMVFKMmJjMUp5ZHBwMnRWUTFu?=
 =?utf-8?B?LzkvcEVrVUF4aDNGRE9KanpWUXg3YS9ZV3dzRncxSndTdU16UjdJWk5SOWJz?=
 =?utf-8?B?SmlEcG1EeFBkendqbTY2SnhBcUw0QVlMSGpCU0dMUVVVK1p3Y3hWT1VGRlZP?=
 =?utf-8?B?OUdrTzRhWFdaanFNTy9FbkFGZkxvZGN4amMwM2M0SFpyekxaY0g5akYrSTc1?=
 =?utf-8?B?NTFBSWxSZk1sWkdCbzJLd0JEWkVpQ25CN1p6SmcvU1JlNjdTWUJPaTNTait3?=
 =?utf-8?B?NGY0L0tEWk1VTjQ1KzdNQkZwYzlpODJFcStFNVc1QlRnTVJnWGhEbTdidWxl?=
 =?utf-8?B?b21qN3VoQng4ZGJoTmp4UytmNWFYMDNDRUFISjhnYWVTUzZhN3Y0SGxmckM5?=
 =?utf-8?B?Znp6QVFSZlBjWWxDYjg3NmVlMjZwQURPVFhzbWh1dnlXYjJRc0ZtR3pUVUg1?=
 =?utf-8?B?N3B3RWpKRk1YSDBBZUNuV08xV2lscFovdHF6YmhORTJSQ0ZLZFRjNFJMVk90?=
 =?utf-8?B?eUo2RUZIQW8rS2lHYjRvZC95SHBZblAvcGd2ZVdOK3pkRkRDT0RzaU41NkYv?=
 =?utf-8?B?QXd4YnE2VXVQWnNoeUo2QnI3RVFDRGZZUWN2NVltNzlQN2xzb09EU0l4ek1P?=
 =?utf-8?B?VUNPZTZFTUo3WSs3czQyeXVvV3JGczNSamVaSHhYckdGZVFZTkZibGJJVUlj?=
 =?utf-8?B?dUVWR2M1NEZ5cTQ4WFYra0JSQ1J5eXVxWGIwOHhCUTZSQlZUNy90VVA5NmR6?=
 =?utf-8?B?c3pKbGpVZm1NMC9hbjZsUUlmaWYvamR2OHhhYTRYZlFITzAvTHFLL3BPWlNv?=
 =?utf-8?B?cEV0SFk0K2FINWZEN0RHeWRVQWRtWE4wcjBlUzY1T0krdHYwSGVvRnRiSHRF?=
 =?utf-8?B?QnZyOFh3V1l2bVlDT2RrSWNoUHNrczVlQlhlSGRmeE1DMXFmemVwUHlpL0dW?=
 =?utf-8?B?SFJOaGFXWkpOTHdlekxKcUVQU1p5SVVzUjNrMmY0c1ZMMFk1M1YvQ2tvSXdO?=
 =?utf-8?B?eDMxVEVUVWJnR0tIZnF2S1RLcG0zeEJsMXNYSks5eTRHNGlMK3lMN0ZNSWFJ?=
 =?utf-8?B?YjVZOVNHamcwSXhaN3dJZmpzU3pBejBkK3B6eWlsbElVOE1UVVZnUG9zdFI2?=
 =?utf-8?B?cWhkdkJGc3V1a2lHQTF6bTF5NzR0Q2dyZVI5eUJvUjNDc2txUVlkRDNZeTBo?=
 =?utf-8?B?VkhLbHdSWnVEbU03Q0V2aWtEU250R092VGowRmhUc0ZwU1JQS3Z1eTVLVHUz?=
 =?utf-8?B?UjVQWWRITVFXQVFKRDI5bThjczV1TU9OeVNtSmhNMDhPSUlmUXNWN0JibXZi?=
 =?utf-8?B?VHZsZzJiSGhGSURYQlJncFFMbGdZdjhTMUprbVZscVVreEEvamxud0tzQjRK?=
 =?utf-8?B?VDhCK3UxUzhXQ0hwUjV2eElGdG9yZys0MEREYXZaVGZHTEhNM1YrcllWaEpw?=
 =?utf-8?B?MlFBUUZmdjJPa0pKWnhOSVZQaS80Q3Rnc0tDNDd4Y2NpaVNHZERDUT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b88424d-0d2e-46ec-9411-08da507b4a05
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2022 16:06:08.0206
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d+hxSJR0bNiGGU/N6sw4JOO8aQ1bN5UHm2aZYVZl9tRoPL7iyywtnTsOm6mnkVQZh3wG/kyIni++1OEWTIOcUw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3396
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/17/2022 10:39, David Laight wrote:
> From: Alan Stern
>> Sent: 17 June 2022 16:05
> ...
>> Another issue is whether wakeup for a mouse means pressing a button or
>> just moving the mouse.  For a mouse that uses LEDs to sense motion,
>> moving it won't generate a wakeup request -- USB suspend does not allow
>> the mouse to use enough current to keep the LEDs illuminated.  On the
>> other hand, there's no reason why wakeup by pressing a button shouldn't
>> always work.
> 

At least one of the Logitech wireless mice I have here works to wake 
either by clicking the buttons or moving the mouse, presumably because 
the mouse is battery powered.  One of my wired ones works only by 
clicking (which is as you describe).

I don't believe there is going to be a way to have granularity of which 
type of event will wake the system; it will be hardware dependent.

> I'm not even sure I want a system to wake up because it's mouse
> gets knocked.
> I guess a mouse could include accelerometers so that you can shake it!
> 

I'm completely opposite.  As soon as I sit down at my desk which has a a 
closed docked laptop, the first thing I do is use the mouse which will 
wake the system.

And if you take a step further and consider desktops if you *don't* do 
this you'll have to find your power button or use the keyboard.

> I've an idea that one of my systems manages to boot if the mouse
> is knocked (and it was last shutdown from windows).
> At least, that it why I think it is sometimes booting up.
> 

It was probably hibernated from Windows rather than shutdown.  Windows 
tends to make this "invisible" to the user.  Some systems can wake from 
S4 on certain devices, and I would expect some registers on your system 
have been programmed to work that way.