Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f8647bec-eca7-b318-4f79-bc4bae721004@linux.intel.com>
Date:   Fri, 17 Jun 2022 15:59:42 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.10.0
Subject: Re: [PATCHv5 1/2] i2c: designware: introduce a custom scl recovery
 for SoCFPGA platforms
Content-Language: en-US
To:     Dinh Nguyen <dinguyen@kernel.org>
Cc:     andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com,
        robh+dt@kernel.org, krzk+dt@kernel.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
References: <20220616141230.858409-1-dinguyen@kernel.org>
From:   Jarkko Nikula <jarkko.nikula@linux.intel.com>
In-Reply-To: <20220616141230.858409-1-dinguyen@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi

On 6/16/22 17:12, Dinh Nguyen wrote:
> The I2C pins on the SoCFPGA platforms do not go through a GPIO module,
> thus cannot be recovered by the default method of by doing a GPIO access.
> Only a reset of the I2C IP block can a recovery be successful.
> 
One thing what is unclear to me how does this release the I2C slave that 
potentially keeps the SDA stuck low. Does platform specific reset 
sequence send 9 SCL pulses, toggle HW reset of the clients or cycle 
power of them?

If recovery is only controller point of view then worth to emphasis it 
in the commit log and perhaps add a comment too into 
i2c_socfpga_scl_recovery(). Some might hit an issue that I2C client is 
stuck and wonder why recovery won't work.

> The assignment of the recover_bus needs to get done before the call to
> devm_gpiod_get_optional(), otherwise, the assignment is not taking place
> because of an error after returning from devm_gpiod_get_optional().
> 
This sentence no longer true after v3?

Otherwise code looks good to me.

Jarkko