Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fa35e955-41be-bb4b-d1f0-85acec03e0a0@gmail.com>
Date:   Sat, 18 Jun 2022 03:09:30 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v4 4/4] PM / devfreq: Mute warning on governor PROBE_DEFER
Content-Language: en-US
To:     Ansuel Smith <ansuelsmth@gmail.com>
Cc:     MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Sibi Sankar <sibis@codeaurora.org>,
        Saravana Kannan <skannan@codeaurora.org>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220614230950.426-1-ansuelsmth@gmail.com>
 <20220614230950.426-5-ansuelsmth@gmail.com>
 <8dd8bfa2-0843-269b-2d55-e3cbdbf6a5e1@gmail.com>
 <62a9b027.1c69fb81.5ae2b.4f85@mx.google.com>
From:   Chanwoo Choi <cwchoi00@gmail.com>
In-Reply-To: <62a9b027.1c69fb81.5ae2b.4f85@mx.google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 22. 6. 15. 18:22, Ansuel Smith wrote:
> On Wed, Jun 15, 2022 at 03:56:31PM +0900, Chanwoo Choi wrote:
>> On 22. 6. 15. 08:09, Christian 'Ansuel' Marangi wrote:
>>> Don't print warning when a governor PROBE_DEFER as it's not a real
>>> GOV_START fail.
>>>
>>> Fixes: a03dacb0316f ("PM / devfreq: Add cpu based scaling support to passive governor")
>>> Signed-off-by: Christian 'Ansuel' Marangi <ansuelsmth@gmail.com>
>>> ---
>>>  drivers/devfreq/devfreq.c | 5 +++--
>>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
>>> index 2e2b3b414d67..6a39638ed064 100644
>>> --- a/drivers/devfreq/devfreq.c
>>> +++ b/drivers/devfreq/devfreq.c
>>> @@ -931,8 +931,9 @@ struct devfreq *devfreq_add_device(struct device *dev,
>>>  	err = devfreq->governor->event_handler(devfreq, DEVFREQ_GOV_START,
>>>  						NULL);
>>>  	if (err) {
>>> -		dev_err(dev, "%s: Unable to start governor for the device\n",
>>> -			__func__);
>>> +		dev_err_probe(dev, err,
>>> +			      "%s: Unable to start governor for the device\n",
>>> +			      __func__);
>>>  		goto err_init;
>>>  	}
>>>  	create_sysfs_files(devfreq, devfreq->governor);
>>
>>
>> In order to keep the left-align with above error log
>> when try_then_request_governor() is failed,
>> I recommend to use the tab without space indentation as following:
>>
>> If you have no objection, I'll merge this change.
>>
> 
> Sure, good for me. Anyway I wonder if we can relax the hard limit for 80
> for error print since we now can use 100, but your choice.

My suggestion is not over 80 line. Applied it. 

> 
>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
>> index 01474daf4548..80a1235ef8fb 100644
>> --- a/drivers/devfreq/devfreq.c
>> +++ b/drivers/devfreq/devfreq.c
>> @@ -932,8 +932,9 @@ struct devfreq *devfreq_add_device(struct device *dev,
>>         err = devfreq->governor->event_handler(devfreq, DEVFREQ_GOV_START,
>>                                                 NULL);
>>         if (err) {
>> -               dev_err(dev, "%s: Unable to start governor for the device\n",
>> -                       __func__);
>> +               dev_err_probe(dev, err,
>> +                       "%s: Unable to start governor for the device\n",
>> +                        __func__);
>>                 goto err_init;
>>         }
>>         create_sysfs_files(devfreq, devfreq->governor);
>>
>>
>>
>>
>>
>> -- 
>> Best Regards,
>> Samsung Electronics
>> Chanwoo Choi
> 


-- 
Best Regards,
Samsung Electronics
Chanwoo Choi