Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 17 Jun 2022 19:12:37 +0100
From:   Mark Brown <broonie@kernel.org>
To:     David Owens <daowens01@gmail.com>
Cc:     Peter Ujfalusi <peter.ujfalusi@gmail.com>,
        Jarkko Nikula <jarkko.nikula@bitmer.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        David Owens <dowens@precisionplanting.com>,
        alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ASoC: ti: omap-mcbsp: duplicate sysfs error
Message-ID: <YqzEFX1rIRIwJCnl@sirena.org.uk>
References: <20220616202645.1645972-1-dowens@precisionplanting.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="u2XbzTKFvyqRa/q5"
Content-Disposition: inline
In-Reply-To: <20220616202645.1645972-1-dowens@precisionplanting.com>
Precedence: bulk


--u2XbzTKFvyqRa/q5
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 16, 2022 at 03:26:45PM -0500, David Owens wrote:
> Convert to managed versions of sysfs and clk allocation to simplify
> unbinding and error handling in probe.  Managed sysfs node
> creation specifically addresses the following error seen the second time
> probe is attempted after sdma_pcm_platform_register() previously requested
> probe deferral:

This breaks an x86 allmodconfig build:

In file included from /build/stage/linux/include/linux/kobject.h:20,
                 from /build/stage/linux/include/linux/module.h:21,
                 from /build/stage/linux/sound/soc/ti/omap-mcbsp.c:12:
/build/stage/linux/sound/soc/ti/omap-mcbsp.c:604:18: error: =E2=80=98additi=
onal_groups=E2=80=99 defined but not used [-Werror=3Dunused-variable]
  604 | ATTRIBUTE_GROUPS(additional);
      |                  ^~~~~~~~~~
/build/stage/linux/include/linux/sysfs.h:154:38: note: in definition of mac=
ro =E2=80=98__ATTRIBUTE_GROUPS=E2=80=99
  154 | static const struct attribute_group *_name##_groups[] =3D {       \
      |                                      ^~~~~
/build/stage/linux/sound/soc/ti/omap-mcbsp.c:604:1: note: in expansion of m=
acro =E2=80=98ATTRIBUTE_GROUPS=E2=80=99
  604 | ATTRIBUTE_GROUPS(additional);
      | ^~~~~~~~~~~~~~~~
In file included from /build/stage/linux/include/linux/kobject.h:20,
                 from /build/stage/linux/include/linux/module.h:21,
                 from /build/stage/linux/sound/soc/ti/omap-mcbsp-st.c:12:
/build/stage/linux/sound/soc/ti/omap-mcbsp-st.c:299:18: error: =E2=80=98sid=
etone_groups=E2=80=99 defined but not used [-Werror=3Dunused-variable]
  299 | ATTRIBUTE_GROUPS(sidetone);
      |                  ^~~~~~~~
/build/stage/linux/include/linux/sysfs.h:154:38: note: in definition of mac=
ro =E2=80=98__ATTRIBUTE_GROUPS=E2=80=99
  154 | static const struct attribute_group *_name##_groups[] =3D {       \
      |                                      ^~~~~
/build/stage/linux/sound/soc/ti/omap-mcbsp-st.c:299:1: note: in expansion o=
f macro =E2=80=98ATTRIBUTE_GROUPS=E2=80=99
  299 | ATTRIBUTE_GROUPS(sidetone);
      | ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

--u2XbzTKFvyqRa/q5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKsxBQACgkQJNaLcl1U
h9CbVAf/bLEYqN9UltUUtE4QfUjkIThFiIGPqM6T7Lr0oitKtqpZGp9i2uqREP8Y
67Eks5a6Zs3SZr7ERZ4nYj/rurE+Jd5YgjxQ5SnGtj8tEFEe6/bzOmCzql0eyRX/
VuFTxyaDKi7QwfejecS3lQIxtWKLbUKw3rRBTF8LMH55Hnw2/oCNYL9djV80lena
GoaJVJYcxFU5Glv4J0ISgs1Oih1rHpI8SegCxqpdiHH2mPELxGB7BcyIyLS3x9yb
BL0dxS8LNRDmakViC8B2csXBjMIq310UogmzfMGyTtV2o/bijJ2eM0LiORCPOAGh
EdOyjsMBlX00w5lh3tyDdOYltpf8IQ==
=VZEL
-----END PGP SIGNATURE-----

--u2XbzTKFvyqRa/q5--