Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp777788iog; Fri, 17 Jun 2022 13:26:36 -0700 (PDT) X-Google-Smtp-Source: AGRyM1va1AYgl6gq9yMN8MTP3AIXMfqot+gMFzYhqdmNy0aNz7Hxsn14MJmWZYi/U+Woyx0UheH6 X-Received: by 2002:a17:906:1109:b0:711:d8fe:fe56 with SMTP id h9-20020a170906110900b00711d8fefe56mr10918504eja.261.1655497595808; Fri, 17 Jun 2022 13:26:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655497595; cv=none; d=google.com; s=arc-20160816; b=VGoXNC7i44Lx+4fMThCMIpoHzQmtpHbAfx/wx+fpw6DRLNq4i1rBdENgWZNydXsoju NsjZVfq80DH6TzrPJmnTxGjtiXecOEeZY7Cxd6dDRJYMoJJyGHYVMXEAuMvqgmyqn9tR lL8KxzmYIuhQTMyipWxD8ImvXVIDZsMsq3znN3KWLN10pyUc4qcGQ3q0SkWUd1uEt71/ WvPlZsonZgEywJyBgp3lRCMcnlXBzSwl/q1vOIectS/wp/s+N+DKHDMotDzkksFeBNa9 3+g41BRjjRSqll4Jle8FAutHtrAjyCrv4m/kPG3y6/p3/1smyyjKAznZuo6V5z/SOgLS TD8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=GdcsyfertH0VgtTwWwQb6+sxjYObLiKFDmZR3hIcmqY=; b=kiphUFblahrG8nt+PE+Hcs3HgHDAFJBu3O5CxySHDUM+tDXVWP6lMQn/vTKpu+vzAN h3cYNMRHDTSWkr6VfVjgZor7Q2Zoe/dt3dyGvC7TFCAyw3IPaDJ195O1UhNpqRCjAGGU DBKfx+/d//3Co5Z+zm2qOCvPYQL4x1rpRi45EgYdRMxMO3dxsOS8xSx8BDRFlxw8K8sD 7YWIYJ5VkGJyCAJOPJyWbrijd9j6c3N+ISXl5Fe21RUm4WCc2crpzJ730ae+PjCwBzs2 Nf3hD6Mkov7UAE4dPqlJ3HUqRZoUKaLmT5mnmOuu7qRFFAutF1dSaAMulshkxRYn/KF0 XySA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qf38-20020a1709077f2600b006fed9433169si6712200ejc.826.2022.06.17.13.25.57; Fri, 17 Jun 2022 13:26:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234627AbiFQT7U (ORCPT + 99 others); Fri, 17 Jun 2022 15:59:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231723AbiFQT7R (ORCPT ); Fri, 17 Jun 2022 15:59:17 -0400 Received: from www62.your-server.de (www62.your-server.de [213.133.104.62]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D0B259B92; Fri, 17 Jun 2022 12:59:16 -0700 (PDT) Received: from sslproxy05.your-server.de ([78.46.172.2]) by www62.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1o2I7W-000Caq-Jx; Fri, 17 Jun 2022 21:59:06 +0200 Received: from [85.1.206.226] (helo=linux-3.home) by sslproxy05.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o2I7W-0002t7-Bo; Fri, 17 Jun 2022 21:59:06 +0200 Subject: Re: [PATCH] tracing/kprobes: Check whether get_kretprobe() returns NULL in kretprobe_dispatcher() To: Steven Rostedt Cc: "Masami Hiramatsu (Google)" , Peter Zijlstra , Ingo Molnar , Yonghong Song , bpf , Kernel Team , linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <165366693881.797669.16926184644089588731.stgit@devnote2> <0204f480-cdb0-e49f-9034-602eced02966@iogearbox.net> <7619DB57-C39B-4A49-808C-7ACF12D58592@goodmis.org> <20220608091017.0596dade@gandalf.local.home> <3d535ae1-69cd-dbae-32f6-7d571a88c2d8@iogearbox.net> <20220617120254.30bb0f15@gandalf.local.home> <26a91f26-8d9c-e5e4-0a2f-4f17746c28b8@iogearbox.net> <20220617134815.5e1a97de@gandalf.local.home> From: Daniel Borkmann Message-ID: Date: Fri, 17 Jun 2022 21:59:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20220617134815.5e1a97de@gandalf.local.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.6/26575/Fri Jun 17 10:08:05 2022) X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/17/22 7:48 PM, Steven Rostedt wrote: > On Fri, 17 Jun 2022 18:09:44 +0200 > Daniel Borkmann wrote: > >>> Sorry, between traveling for conferences and PTO I fell behind. I'll pull >>> this into my urgent queue and start running my tests on it. >> >> Okay, if you pick these fixes up today then I'll toss them from our bpf patchwork. > > This patch I'll take, but please keep the fprobe/rethook one, as that's > specific to your tree. Ok, sounds good to me. I just applied them with the comment suggestion added.