Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <817b6158-a6fc-bcf8-7b0d-b58f8e5a837e@amd.com>
Date:   Sat, 18 Jun 2022 02:01:41 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH V3] selftests/vm: Add protection_keys tests to run_vmtests
Content-Language: en-US
To:     Shuah Khan <skhan@linuxfoundation.org>, akpm@linux-foundation.org,
        shuah@kernel.org, linux-mm@kvack.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220617111019.476-1-kalpana.shetty@amd.com>
 <f73fd7c9-cb9c-1e89-4e22-e6931172eb91@linuxfoundation.org>
From:   "Shetty, Kalpana" <kalpana.shetty@amd.com>
In-Reply-To: <f73fd7c9-cb9c-1e89-4e22-e6931172eb91@linuxfoundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2ZqNXIwUiswKzM1ME05T3E1WmVLb3lXbVpoRm1hdUl6TXFKbDlsOVZ0Yk5T?=
 =?utf-8?B?WkVZbmdNTWVxVDJDRmM2WDhCZGJ3dEtQNnlvT1RpWUdqWXA4MVF1TVM1MHpu?=
 =?utf-8?B?SEM2OUVFaitFOTdDaWJaQmpQMzladFExcmIwRzJuQUI0Rys1SndSVTNhUXZM?=
 =?utf-8?B?L2tWUHErYUJOR2pXU21laW51cEtxNStUS0NoZklKdUQ3a0ZkN245bm94ZEp4?=
 =?utf-8?B?aFpmMU43S0gwdFF0eFMyTkxDNGU4RS9aU2FkNWw1bXVIaEUvWUdJRkNzdVE5?=
 =?utf-8?B?YkpkcDFsU1o3ZGhvYTArcGFacW1td0M2VVlqU2tOQU1tV3EwbGQ0QzEzMzl4?=
 =?utf-8?B?WkFjWkJDZ2tKL0I1a2syb1RLNEd3T0V4UjdGRllCVkIyR244ZTFOTWlERk9L?=
 =?utf-8?B?SzM2MWlNbFhzYlllcCtCek1hTkwwYStvM3hGSzFRcmRHQ2tvZ3JYVnRWaC9H?=
 =?utf-8?B?bC9xdTBYL0ZFSFhFNzlmeWxSdmUxQ3FuL1p1eEk3bEMvb1YwL1FQWU9zeTlo?=
 =?utf-8?B?ZEtBNkhtWm91dGFqL0QzY2F6YUZPbnpuaWdhODd1QUNLOGxIU1pzclZQYzVw?=
 =?utf-8?B?cU12ZjRrZi81cCtpNEk2K0VmOFo5eHQ4NFU3b1JTS1R6VkdtRWUxMUw4SjNQ?=
 =?utf-8?B?b1V1MVE4TEJOYllTNW8xZXlqOHBMcjdKWmJkcklhOUgrc1FlSzVZcVg3bjY5?=
 =?utf-8?B?WTFMcnpzamF4azJEeVYzSVM5UTliTStJcVR1VUxjbmJKVmxrQnN5eW5vVWtl?=
 =?utf-8?B?VjFScEVqRG0rMnNLMUFvL1BYRm1BY2xOTDFtekZ1bFRMcjBTZ21KNjFWRTF4?=
 =?utf-8?B?K1pnNUFQR0NwaFVKZFk4dzluYVdNTGlIODNiSUF6Z3JZNFp1SzZEcXJ5cDhS?=
 =?utf-8?B?V01jR1lMcmsxdVVTQ0h4ODZsTzhGd0hCaFFrb3dPb3B3d1phT2owbGFEUkhF?=
 =?utf-8?B?amlwWnhvKzZKWGNTTU53TUk5Q3J4MDRkQ3M3b2V3K1MxUU1zU3ZqR24rRThh?=
 =?utf-8?B?ekFUU1hMRmFRcHVLeWQ0VVBmVGhRVHg2RmdyMllXem41ZXczTmZVaE56NnR0?=
 =?utf-8?B?YUhjc2I2b1V4K1dwT0ZDZFNJZVFtb2NuWWxvckZRYXJSZURNNW1VS0d0Rm00?=
 =?utf-8?B?aXBnUUFKV3BHbllZQVFVUC9QcU9MNUFyK1RaSGR3THlWQTlRR3BWbjJMdXlE?=
 =?utf-8?B?TTdKcXM5RWRwVHNUbXVkSnJxbXBRWkEwTmxteFJUeTNQR3FXMEJyT1o2VnJW?=
 =?utf-8?B?ZFN3L1Q4cWkzQWRtKzBKWUx3WVREdk5oK2J2S0V6WWV0ZklCS0cyMUtPSy91?=
 =?utf-8?B?aXVBUk54UnBzK0dvNFRzbzJQb1JFenh4OUtPZWlPNUZ6Y2RJSzlreVRWNDBG?=
 =?utf-8?B?R3U1R05NcURteWlsdzZvYS9SZlFsK2kwRXZTcUwwcU1IM2U2dHhOeXRERFNx?=
 =?utf-8?B?anFGQWEvT3BJaFNOTjhWWkFiTkhoWFhRMDA0UmhoRnJjQnJYd3ZFN0ZSL3VT?=
 =?utf-8?B?ckpub2dsVk9HV0Qxc0hWUHhCR0ptUjVSWUpuT09RcjZFOWRDdTVIczFMWU15?=
 =?utf-8?B?YmdXSzJMUHFRVlp4WG1sSmFGZ1JXVFF0d2FJK2ZReUc0QVNOeDhFVWxWYnJw?=
 =?utf-8?B?dzcxYjk4em9HaGNtS2FyTkRReGVLeTVSQll2enZPYm5mM3c3MENDelZ6L2x0?=
 =?utf-8?B?aUg1MjJBeXNVWkI0bW0yQk8wQkJIZUdSS3Z4WFlzNTJpKzJBd3pUTHdVc3Vr?=
 =?utf-8?B?a0RQK1VzcWZWMkJ0Vkx2RVFsaHFWVTRsREhPRFcvekFRRTVIbms0K3pVYTdE?=
 =?utf-8?B?QnpSRG9UQlJFVFl6QkN2aGRtSGdlVjhvdm5HaTIyZEtBZGFUSlpJMlJJb0dK?=
 =?utf-8?B?eG4xcEhPTCt5aWJQNmFLNENnM3Y2ZllJMjBoZjB6aGZmeGxBZHhFMGdpOW1S?=
 =?utf-8?B?ZkdKRHdtcFQ2YWJuOU56UHNaRTZIWitRR0ttSEo3THZCMVIzdzFKU2NPQlVy?=
 =?utf-8?B?MzBXZ2ViNU1pVmxrL3RTcURpaDE4dVhtYjlFdkw0YzArRVdaZjhPdnU4OFBM?=
 =?utf-8?B?WllYa0JLWnQ1aSt6VmV1a1R6U3FKc0kyZ0tSYTNlWGlIeWorRlpFVjluRXBI?=
 =?utf-8?B?QUI4WFhQLzdvU2xLUC9yUTBCNEFTSE5GczZ1RUNSc1A1dysvdWhuSjlGT0Js?=
 =?utf-8?B?ZnZmaEtTelMyWVNuUnNIb3hjTFdub0pYVEZ6eThQL3Nxb1M2Y3VxVGVMbFI2?=
 =?utf-8?B?eGxMbkVOZVZ3SlM3ZDRsZENKSXpGZHVCUmUxMlNINWk3c2M3b1Vham5PYlo4?=
 =?utf-8?B?WDJrbDhaOWtHd01pc0JWQ20rYXFDY0gvTDNYTEdNV2oyS3NWbGNzUT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7949728f-23f2-4bcc-c59e-08da50a06860
X-MS-Exchange-CrossTenant-AuthSource: BL3PR12MB6449.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2022 20:31:50.5320
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XcpzFuxjPlCIw2wvghcgUAdpa3nPHti/8iwvsAmU83jEgoVXay3BZeJjY/WQa30L7Cn2VWwexRYJsD8MK/IM8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2935
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/18/2022 1:01 AM, Shuah Khan wrote:
> On 6/17/22 5:10 AM, Kalpana Shetty wrote:
>> Adding "protected_keys" tests to "run_vmtests.sh" would help out to 
>> run all VM related tests
>> from a single shell script.
>>
>> Signed-off-by: Kalpana Shetty <kalpana.shetty@amd.com>
>> ---
>> Changes in V3:
>>   Shuah Khan's review comments incorporated, added protection_keys 
>> binary check.
>>
>>   tools/testing/selftests/vm/run_vmtests.sh | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/tools/testing/selftests/vm/run_vmtests.sh 
>> b/tools/testing/selftests/vm/run_vmtests.sh
>> index 41fce8bea929..b19c6b1b84c4 100755
>> --- a/tools/testing/selftests/vm/run_vmtests.sh
>> +++ b/tools/testing/selftests/vm/run_vmtests.sh
>> @@ -179,4 +179,15 @@ run_test ./ksm_tests -N -m 1
>>   # KSM test with 2 NUMA nodes and merge_across_nodes = 0
>>   run_test ./ksm_tests -N -m 0
>>   +# protection_keys tests
>> +if ./protection_keys_32 &> /dev/null
>> +then
>> +    run_test ./protection_keys_32
>> +fi
>> +
>> +if ./protection_keys_64 &> /dev/null
>> +then
>> +    run_test ./protection_keys_64
>> +fi
>> +
>>   exit $exitcode
>>
>
> Why not use file test operators. -x works for this case.
> There is no need to run attempt to run the test.
Sure; thanks for the suggestion. Sent V4 patch.
>
> thanks,
> -- Shuah

Thanks,

Kalpana